Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kibana maps shows MVT borders if the geometry border style is greater than 1 #150187

Closed
craigtaverner opened this issue Feb 2, 2023 · 3 comments · Fixed by #150497
Closed

Kibana maps shows MVT borders if the geometry border style is greater than 1 #150187

craigtaverner opened this issue Feb 2, 2023 · 3 comments · Fixed by #150497
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@craigtaverner
Copy link

craigtaverner commented Feb 2, 2023 •
edited
Loading

While testing kibana and ES for 8.7.0 release, I noticed that when adding document layer with polygon geometries and I set the layer style border width to a value greater than 1, the border got thicker as expected, but also the borders of the vector tiles became visible. This would seem to indicate that the vector tile buffer is being overridden. The buffer should default to 5 pixels, allowing us to increase the border quite a bit before it becomes visible.

Screenshot 2023-02-02 at 16 12 01

I used the inspector to look at the MVT query, and this made be think of two fields that could affect this:

  • extent: I see a value of 4096 which is the default, so does not really need to be sent
  • buffer: this is not set in the query, so defaults to 5, but perhaps it should be sent, based on the border thickness

Could it be that since the vector tiles are much smaller than 4096 pixels, they are being scaled down, and therefor the 5 pixel buffer is too small a fraction of the 4096 to be enough for the increased border? I think either reduce the extent, or increase the buffer.
@craigtaverner craigtaverner added bug Fixes for quality problems that affect the customer experience Feature:Maps labels Feb 2, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 2, 2023
@nreese nreese added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Feb 2, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 2, 2023
@nreese nreese added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Feb 2, 2023
@nreese
Copy link
Contributor

nreese commented Feb 7, 2023

Ran an investigation to find buffer value for various border sizes that did not show lines. Below are the results. The function Ceil(3.5 * borderWidth) provides buffer values that reasonablly fit the table below.

buffer 4
no lines <= 1
lines > 1

buffer 7
no lines <= 2
lines > 2

buffer 10
no lines <=3
lines > 3

buffer 14
no lines <= 4
lines > 4

buffer 17
no lines <= 5
lines > 5

buffer 20
no lines <= 6
lines > 6

buffer 25
no lines <= 7
lines > 7

buffer 28
no lines <= 8
lines > 8

@nreese nreese mentioned this issue Feb 7, 2023
Merged
@nreese nreese self-assigned this Feb 7, 2023
@ThomThomson ThomThomson added the loe:medium Medium Level of Effort label Feb 9, 2023
nreese added a commit that referenced this issue Feb 9, 2023
@nreese @kibanamachine
[Maps] fixes Kibana maps shows MVT borders if the geometry border sty…
f439bdc 
…le is greater than 1 (#150497)

Fixes #150187

PR passes buffer to kibana MVT route which passes buffer to
Elasticsearch vector tile API. Buffer is set based on line width style
property.

<img width="600" alt="Screen Shot 2023-02-07 at 2 43 15 PM"
src="https://user-images.githubusercontent.com/373691/217373279-4d72e210-31ae-48cc-997f-dc05d330028b.png">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine pushed a commit that referenced this issue Feb 9, 2023
@nreese
[Maps] fixes Kibana maps shows MVT borders if the geometry border sty…
ef8bb19 
…le is greater than 1 (#150497)

Fixes #150187

PR passes buffer to kibana MVT route which passes buffer to
Elasticsearch vector tile API. Buffer is set based on line width style
property.

<img width="600" alt="Screen Shot 2023-02-07 at 2 43 15 PM"
src="https://user-images.githubusercontent.com/373691/217373279-4d72e210-31ae-48cc-997f-dc05d330028b.png">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit f439bdc)
kibanamachine referenced this issue Feb 9, 2023
@kibanamachine @nreese
[8.7] [Maps] fixes Kibana maps shows MVT borders if the geometry bord…
c4ebad6 
…er style is greater than 1 (#150497) (#150758)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Maps] fixes Kibana maps shows MVT borders if the geometry border
style is greater than 1
(#150497)](#150497)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2023-02-09T18:07:54Z","message":"[Maps]
fixes Kibana maps shows MVT borders if the geometry border style is
greater than 1 (#150497)\n\nFixes
https://github.com/elastic/kibana/issues/150187\r\n\r\nPR passes buffer
to kibana MVT route which passes buffer to\r\nElasticsearch vector tile
API. Buffer is set based on line width style\r\nproperty.\r\n\r\n<img
width=\"600\" alt=\"Screen Shot 2023-02-07 at 2 43 15
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/217373279-4d72e210-31ae-48cc-997f-dc05d330028b.png\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"f439bdc2b3fe7caa20ff5375460cc9659c6a76db","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","auto-backport","Feature:Maps","v8.7.0","v8.8.0"],"number":150497,"url":"https://github.com/elastic/kibana/pull/150497","mergeCommit":{"message":"[Maps]
fixes Kibana maps shows MVT borders if the geometry border style is
greater than 1 (#150497)\n\nFixes
https://github.com/elastic/kibana/issues/150187\r\n\r\nPR passes buffer
to kibana MVT route which passes buffer to\r\nElasticsearch vector tile
API. Buffer is set based on line width style\r\nproperty.\r\n\r\n<img
width=\"600\" alt=\"Screen Shot 2023-02-07 at 2 43 15
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/217373279-4d72e210-31ae-48cc-997f-dc05d330028b.png\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"f439bdc2b3fe7caa20ff5375460cc9659c6a76db"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150497","number":150497,"mergeCommit":{"message":"[Maps]
fixes Kibana maps shows MVT borders if the geometry border style is
greater than 1 (#150497)\n\nFixes
https://github.com/elastic/kibana/issues/150187\r\n\r\nPR passes buffer
to kibana MVT route which passes buffer to\r\nElasticsearch vector tile
API. Buffer is set based on line width style\r\nproperty.\r\n\r\n<img
width=\"600\" alt=\"Screen Shot 2023-02-07 at 2 43 15
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/217373279-4d72e210-31ae-48cc-997f-dc05d330028b.png\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"f439bdc2b3fe7caa20ff5375460cc9659c6a76db"}}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
@nreese nreese mentioned this issue May 9, 2024
Closed
@jmp601
Copy link

jmp601 commented May 15, 2024 •
edited
Loading

Here it is on our maps. I am running 8.13.4:
image
It only shows up for me when I use a border line thickness of 1 or 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
5 participants
@craigtaverner @nreese @ThomThomson @elasticmachine @jmp601