-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data view editor plugin uses Rollup Jobs internal API endpoint #152708
Comments
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
@yuliacech I could use your advice figuring out how to move forward on this. Data views code needs a way to get a list of rollup indices. Perhaps the rollup jobs plugin should make such functionality available on its plugin contract. I also need to do a deeper inventory of data view related code to see where we're we have rollup specific code. Has anything been said about how rollup data might be migrated? I guess I'm not really expecting an answer on that, but I do need to think of how I might handle data views defined on a rollup index. |
Hi @mattkime, thanks a lot for looking into this. |
Whats the user story regarding migration to the cloud? What happens if they attempt to migrate rollup data and saved objects? What happens if someone individually exports a rollup data view and imports it in an environment without rollup support? |
@mattkime @yuliacech could you follow up here so we can identify if there's stuff to do for 8.9. For me the main question is, what happens if a user imports a rollup data view in an environment without rollup support? This could be already tested, by disabling the rollup plugin |
@kertal We need to investigate this and define what we would like to happen. No thought has been put into user experience. |
@shubhaat could you please help answer this question? |
|
…s disabled (#162674) ## Summary Rollup functionality will be disabled on serverless instances. The `rollup` plugin will be disabled. While it won't be possible to create rollups on serverless, it will be possible to import data view saved objects which may be configured for use with rollups. We will make a 'best effort' to improve functionality as to help users transition away from rollups. - In classic environments, the `rollup` plugin will enable `dataViews` and `data` plugin rollup functionality. - The data plugin will run an async search instead of a rollup search. - The data views plugin will fetch normal fields, omitting a query for rollup fields - which would fail anyway. Closes #152708 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary Adds a comment that the API endpoint /rollup/indices is used by the data view plugin. With #162674 merged, the issue #152708 has been closed. The Data Discovery team is not planning any further work around rollup api use due to the feature being deprecated. I think adding a comment to the API code directly will help us remember this dependency for when we are going to edit or remove the endpoint.
…s disabled (elastic#162674) ## Summary Rollup functionality will be disabled on serverless instances. The `rollup` plugin will be disabled. While it won't be possible to create rollups on serverless, it will be possible to import data view saved objects which may be configured for use with rollups. We will make a 'best effort' to improve functionality as to help users transition away from rollups. - In classic environments, the `rollup` plugin will enable `dataViews` and `data` plugin rollup functionality. - The data plugin will run an async search instead of a rollup search. - The data views plugin will fetch normal fields, omitting a query for rollup fields - which would fail anyway. Closes elastic#152708 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
…#163432) ## Summary Adds a comment that the API endpoint /rollup/indices is used by the data view plugin. With elastic#162674 merged, the issue elastic#152708 has been closed. The Data Discovery team is not planning any further work around rollup api use due to the feature being deprecated. I think adding a comment to the API code directly will help us remember this dependency for when we are going to edit or remove the endpoint.
The Data view editor plugin relies on an internal API endpoint of the Rollup Jobs plugin (see here).
The API endpoint
/api/rollup/indices
is only intended for internal use by the Rollup jobs plugin's client-side. Since the dependency via API usage is not explicit, any changes to the API endpoint might not be immediately propagated to the dependent plugins. The plugin is also planned to be disabled for serverless.The text was updated successfully, but these errors were encountered: