[Rollup] Add a comment about api use by the data view plugin #163432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuliacech
added
Team:Kibana Management
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
alisonelizabeth
approved these changes
Aug 8, 2023
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Aug 9, 2023
…#163432) ## Summary Adds a comment that the API endpoint /rollup/indices is used by the data view plugin. With elastic#162674 merged, the issue elastic#152708 has been closed. The Data Discovery team is not planning any further work around rollup api use due to the feature being deprecated. I think adding a comment to the API code directly will help us remember this dependency for when we are going to edit or remove the endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a comment that the API endpoint /rollup/indices is used by the data view plugin.
With #162674 merged, the issue #152708 has been closed. The Data Discovery team is not planning any further work around rollup api use due to the feature being deprecated. I think adding a comment to the API code directly will help us remember this dependency for when we are going to edit or remove the endpoint.