Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error thrown while typing in Alert page search bar #155655

Closed
benakansara opened this issue Apr 24, 2023 · 1 comment · Fixed by #155796
Closed

Error thrown while typing in Alert page search bar #155655

benakansara opened this issue Apr 24, 2023 · 1 comment · Fixed by #155796
Assignees
@benakansara
Labels
bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0

Comments

@benakansara
Copy link
Contributor

Kibana version:
main

Original install method (e.g. download page, yum, from source, etc.):
source

Describe the bug:
Alert search bar throws an error when typing ":" after a field name in the search bar.

Steps to reproduce:

  1. Click on the Alert search bar
  2. Select any field from the dropdown
  3. Select ":" from the dropdown
  4. Error popup is shown

Screenshots:
Screenshot 2023-04-24 at 19 39 45
@benakansara benakansara added bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0 labels Apr 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@benakansara benakansara mentioned this issue Apr 25, 2023
Merged
@CoenWarmer CoenWarmer mentioned this issue Apr 25, 2023
Merged
4 tasks
@CoenWarmer CoenWarmer assigned benakansara and unassigned CoenWarmer May 1, 2023
benakansara added a commit that referenced this issue May 2, 2023
@benakansara
Fix search issue with Alert search bar (#155796)
44c40a3 
Fixes #155655

Added `onQuerySubmit` ~as optional~ parameter to `AlertsSearchBar` and
made `onQueryChange` as optional parameter as this is not needed for
Observability Alerts.

### [Observability] Alerts page:


https://user-images.githubusercontent.com/69037875/234622864-c18e338c-2ea3-4c79-9340-30c5e8fa470e.mov

### [Security] Alerts filter in action:


https://user-images.githubusercontent.com/69037875/234623243-c882a866-83fa-4d09-a1fb-d36588922f30.mov
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue May 2, 2023
@benakansara
Fix search issue with Alert search bar (elastic#155796)
f426ce4 
Fixes elastic#155655

Added `onQuerySubmit` ~as optional~ parameter to `AlertsSearchBar` and
made `onQueryChange` as optional parameter as this is not needed for
Observability Alerts.

### [Observability] Alerts page:

https://user-images.githubusercontent.com/69037875/234622864-c18e338c-2ea3-4c79-9340-30c5e8fa470e.mov

### [Security] Alerts filter in action:

https://user-images.githubusercontent.com/69037875/234623243-c882a866-83fa-4d09-a1fb-d36588922f30.mov
(cherry picked from commit 44c40a3)
kibanamachine referenced this issue May 2, 2023
@kibanamachine @benakansara
[8.8] Fix search issue with Alert search bar (#155796) (#156433)
9075d8b 
# Backport

This will backport the following commits from `main` to `8.8`:
- [Fix search issue with Alert search bar
(#155796)](#155796)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"69037875+benakansara@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-02T18:34:29Z","message":"Fix
search issue with Alert search bar (#155796)\n\nFixes
https://github.com/elastic/kibana/issues/155655\r\n\r\nAdded
`onQuerySubmit` ~as optional~ parameter to `AlertsSearchBar` and\r\nmade
`onQueryChange` as optional parameter as this is not needed
for\r\nObservability Alerts.\r\n\r\n### [Observability] Alerts
page:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/69037875/234622864-c18e338c-2ea3-4c79-9340-30c5e8fa470e.mov\r\n\r\n###
[Security] Alerts filter in
action:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/69037875/234623243-c882a866-83fa-4d09-a1fb-d36588922f30.mov","sha":"44c40a38e7dafe566823f56edb167d6b3b17a6f3","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","impact:high","Team:
Actionable
Observability","v8.8.0","v8.9.0"],"number":155796,"url":"https://github.com/elastic/kibana/pull/155796","mergeCommit":{"message":"Fix
search issue with Alert search bar (#155796)\n\nFixes
https://github.com/elastic/kibana/issues/155655\r\n\r\nAdded
`onQuerySubmit` ~as optional~ parameter to `AlertsSearchBar` and\r\nmade
`onQueryChange` as optional parameter as this is not needed
for\r\nObservability Alerts.\r\n\r\n### [Observability] Alerts
page:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/69037875/234622864-c18e338c-2ea3-4c79-9340-30c5e8fa470e.mov\r\n\r\n###
[Security] Alerts filter in
action:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/69037875/234623243-c882a866-83fa-4d09-a1fb-d36588922f30.mov","sha":"44c40a38e7dafe566823f56edb167d6b3b17a6f3"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155796","number":155796,"mergeCommit":{"message":"Fix
search issue with Alert search bar (#155796)\n\nFixes
https://github.com/elastic/kibana/issues/155655\r\n\r\nAdded
`onQuerySubmit` ~as optional~ parameter to `AlertsSearchBar` and\r\nmade
`onQueryChange` as optional parameter as this is not needed
for\r\nObservability Alerts.\r\n\r\n### [Observability] Alerts
page:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/69037875/234622864-c18e338c-2ea3-4c79-9340-30c5e8fa470e.mov\r\n\r\n###
[Security] Alerts filter in
action:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/69037875/234623243-c882a866-83fa-4d09-a1fb-d36588922f30.mov","sha":"44c40a38e7dafe566823f56edb167d6b3b17a6f3"}}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <69037875+benakansara@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benakansara benakansara

Labels
bug Fixes for quality problems that affect the customer experience Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix search issue with Alert search bar benakansara/kibana
3 participants
@CoenWarmer @elasticmachine @benakansara