Fix search issue with Alert search bar #155796

benakansara · 2023-04-25T20:42:55Z

Added onQuerySubmit ~~as optional~~ parameter to AlertsSearchBar and made onQueryChange as optional parameter as this is not needed for Observability Alerts.

[Observability] Alerts page:

Screen.Recording.2023-04-26.at.17.17.55.mov

[Security] Alerts filter in action:

Screen.Recording.2023-04-26.at.17.14.58.mov

elasticmachine · 2023-04-25T20:42:59Z

Pinging @elastic/actionable-observability (Team: Actionable Observability)

apmmachine · 2023-04-25T20:43:10Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

CoenWarmer · 2023-04-25T20:49:37Z

@benakansara thanks for investigating this. This was introduced by #154680. Removing this prop might break functionality introduced in that PR. Best to check with @Zacqary.

benakansara · 2023-04-25T20:54:58Z

@CoenWarmer that's right. The search bar is shared by other applications too, I didn't take that into account. Then this needs more investigation.

benakansara · 2023-04-25T21:09:17Z

at a second look, I think the change only applies to the alert search bar in Observability Alerts and APM Services -> Alerts. @maryam-saeidi do you know if this component is used elsewhere?

@Zacqary can we safely remove onQueryChange from AlertsSearchBar?

ersin-erdal · 2023-04-25T21:36:02Z

at a second look, I think the change only applies to the alert search bar in Observability Alerts and APM Services -> Alerts. @maryam-saeidi do you know if this component is used elsewhere?

@Zacqary can we safely remove onQueryChange from AlertsSearchBar?

I added it there because if a user changes the query and clicks directly on the save button it doesn't save the new value.
Without onChange method the only way to set the new value in the state is onBlur...

benakansara · 2023-04-26T09:09:56Z

I added it there because if a user changes the query and clicks directly on the save button it doesn't save the new value. Without onChange method the only way to set the new value in the state is onBlur...

How can I verify if the new value is set correctly? I tested after removing onQueryChange. I can see the value updated in the query string when I click on Update/Refresh button or press Enter. It is not updating as I type (which was causing the error).

ersin-erdal · 2023-04-26T09:32:38Z

I added it there because if a user changes the query and clicks directly on the save button it doesn't save the new value. Without onChange method the only way to set the new value in the state is onBlur...

How can I verify if the new value is set correctly? I tested after removing onQueryChange. I can see the value updated in the query string when I click on Update/Refresh button or press Enter. It is not updating as I type (which was causing the error).

It's not happening on the "Alerts" page but on the new alerts filter query input. I think the same search component is used in the both components. On Alerts page it's used as a search bar (as it is developed for) but on actions tab of a rule it's used as a query input box...

maryam-saeidi · 2023-04-26T10:16:18Z

@benakansara Places where we have an alert search bar are:

Alerts page
Rule details page > Alerts tab
APM Services -> Alerts
~~Hosts > Alerts tab~~ sorry this has alerts table not search bar

maryam-saeidi · 2023-04-26T10:19:50Z

It's not happening on the "Alerts" page but on the new alerts filter query input. I think the same search component is used in the both components. On Alerts page it's used as a search bar (as it is developed for) but on actions tab of a rule it's used as a query input box...

@ersin-erdal I didn't understand where you are referring to, where is actions tab of a rule ? Do you have a ticket or PR for the previous change that you mentioned here:

I added it there because if a user changes the query and clicks directly on the save button it doesn't save the new value.

benakansara · 2023-04-26T10:43:10Z

@ersin-erdal tbh, I couldn't see any difference in actions tab of a rule after removing onQueryChange. Maybe I am missing something. Should something happen when I type in actions tab query filter?
I have modified the code to address this differently. Wdyt about adding onQuerySubmit in AlertsSearchBarProps as optional and making onQueryChange also optional?

@maryam-saeidi I think actions tab of a rule refers to the Security rules -

ersin-erdal · 2023-04-26T10:56:41Z

@ersin-erdal tbh, I couldn't see any difference in actions tab of a rule after removing onQueryChange. Maybe I am missing something. Should something happen when I type in actions tab query filter?
I have modified the code to address this differently. Wdyt about adding onQuerySubmit in AlertsSearchBarProps as optional and making onQueryChange also optional?

let me quote my self :)

if a user changes the query and clicks directly on the save button it doesn't save the new value.

1- Create and save a rule with alerts filter query,
2- Edit rule by modifying the query and click on the save button directly, nowhere else before.

It doesn't save the value as we set the new value in the redux store onBlur. Kind of race condition, Save event happens before onBlur.

Please see the comment on this PR

I think we need a separate onChange function on action details to pass the value to redux store. It can be removed from the "Alerts" page.

benakansara · 2023-04-26T15:27:28Z

Thank you for the explanation @ersin-erdal.

I think we need a separate onChange function on action details to pass the value to redux store. It can be removed from the "Alerts" page.

I think we are talking about same thing (adding onQuerySubmit in AlertsSearchBarProps for Obs Alerts and making onQueryChange as optional so it can be omitted from Obs Alerts, Actions filter will have both onQuerySubmit and onQueryChange).

CoenWarmer

Tested in Observability app. Works as expected 🥳

maryam-saeidi

Nice job! 👍🏻

maryam-saeidi · 2023-05-02T14:33:34Z

@benakansara You don't need to use backport label for this PR (this label is automatically added to the related backport PRs). If you want to backport to the previous minor version (in this case v8.8) you can use backport:prev-minor label (and by default it will be merged to main which is v8.9)

Zacqary

Tested and works with Conditional Action

kibana-ci · 2023-05-02T18:31:54Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 8427979

Failed CI Steps

FTR Configs #1

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	1.4MB	1.4MB	+248.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`securitySolution`	398	401	+3
total			+5

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`securitySolution`	478	481	+3
total			+5

History

💚 Build #123799 succeeded 78d8a8f
💔 Build #123631 failed ad24c2a
💔 Build #123577 failed ca38385
💚 Build #123419 succeeded 6b705ae
💔 Build #123229 failed d7b17ad

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @benakansara

Fixes elastic#155655 Added `onQuerySubmit` ~as optional~ parameter to `AlertsSearchBar` and made `onQueryChange` as optional parameter as this is not needed for Observability Alerts. ### [Observability] Alerts page: https://user-images.githubusercontent.com/69037875/234622864-c18e338c-2ea3-4c79-9340-30c5e8fa470e.mov ### [Security] Alerts filter in action: https://user-images.githubusercontent.com/69037875/234623243-c882a866-83fa-4d09-a1fb-d36588922f30.mov (cherry picked from commit 44c40a3)

kibanamachine · 2023-05-02T18:40:33Z

💚 All backports created successfully

Status	Branch	Result
✅	8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

# Backport This will backport the following commits from `main` to `8.8`: - [Fix search issue with Alert search bar (#155796)](#155796)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Bena Kansara <69037875+benakansara@users.noreply.github.com>

fix search issue

d7b17ad

benakansara added backport Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0 labels Apr 25, 2023

benakansara requested a review from a team April 25, 2023 20:42

benakansara self-assigned this Apr 25, 2023

benakansara requested a review from a team as a code owner April 25, 2023 20:42

CoenWarmer mentioned this pull request Apr 25, 2023

[RAM] Add query conditional action filter to Security Solution UI #154680

Merged

4 tasks

benakansara marked this pull request as draft April 25, 2023 20:55

benakansara closed this Apr 25, 2023

benakansara reopened this Apr 25, 2023

add onQuerySubmit prop

6b705ae

benakansara marked this pull request as ready for review April 26, 2023 15:27

benakansara and others added 4 commits April 26, 2023 18:00

making onQuerySubmit not optional

c74119d

removing undefined check

ca38385

Merge branch 'main' into bugfix/alert-search-bar

ad24c2a

Merge branch 'main' into bugfix/alert-search-bar

78d8a8f

CoenWarmer approved these changes Apr 28, 2023

View reviewed changes

maryam-saeidi approved these changes May 2, 2023

View reviewed changes

XavierM added v8.9.0 bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels May 2, 2023

benakansara removed the backport label May 2, 2023

Zacqary approved these changes May 2, 2023

View reviewed changes

benakansara enabled auto-merge (squash) May 2, 2023 17:07

Merge branch 'main' into bugfix/alert-search-bar

8427979

benakansara added the release_note:skip Skip the PR/issue when compiling release notes label May 2, 2023

benakansara merged commit 44c40a3 into elastic:main May 2, 2023

kibanamachine mentioned this pull request May 2, 2023

[8.8] Fix search issue with Alert search bar (#155796) #156433

Merged

benakansara deleted the bugfix/alert-search-bar branch October 23, 2023 07:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix search issue with Alert search bar #155796

Fix search issue with Alert search bar #155796

benakansara commented Apr 25, 2023 •

edited by kibanamachine

Loading

elasticmachine commented Apr 25, 2023

apmmachine commented Apr 25, 2023

CoenWarmer commented Apr 25, 2023

benakansara commented Apr 25, 2023

benakansara commented Apr 25, 2023 •

edited

Loading

ersin-erdal commented Apr 25, 2023

benakansara commented Apr 26, 2023

ersin-erdal commented Apr 26, 2023

maryam-saeidi commented Apr 26, 2023 •

edited

Loading

maryam-saeidi commented Apr 26, 2023

benakansara commented Apr 26, 2023

ersin-erdal commented Apr 26, 2023 •

edited

Loading

benakansara commented Apr 26, 2023

CoenWarmer left a comment •

edited

Loading

maryam-saeidi left a comment

maryam-saeidi commented May 2, 2023 •

edited

Loading

Zacqary left a comment

kibana-ci commented May 2, 2023

ESLint disabled line counts

Total ESLint disabled count

kibanamachine commented May 2, 2023

Fix search issue with Alert search bar #155796

Fix search issue with Alert search bar #155796

Conversation

benakansara commented Apr 25, 2023 • edited by kibanamachine Loading

[Observability] Alerts page:

[Security] Alerts filter in action:

elasticmachine commented Apr 25, 2023

apmmachine commented Apr 25, 2023

🤖 GitHub comments

CoenWarmer commented Apr 25, 2023

benakansara commented Apr 25, 2023

benakansara commented Apr 25, 2023 • edited Loading

ersin-erdal commented Apr 25, 2023

benakansara commented Apr 26, 2023

ersin-erdal commented Apr 26, 2023

maryam-saeidi commented Apr 26, 2023 • edited Loading

maryam-saeidi commented Apr 26, 2023

benakansara commented Apr 26, 2023

ersin-erdal commented Apr 26, 2023 • edited Loading

benakansara commented Apr 26, 2023

CoenWarmer left a comment • edited Loading

Choose a reason for hiding this comment

maryam-saeidi left a comment

Choose a reason for hiding this comment

maryam-saeidi commented May 2, 2023 • edited Loading

Zacqary left a comment

Choose a reason for hiding this comment

kibana-ci commented May 2, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

kibanamachine commented May 2, 2023

💚 All backports created successfully

Questions ?

benakansara commented Apr 25, 2023 •

edited by kibanamachine

Loading

benakansara commented Apr 25, 2023 •

edited

Loading

maryam-saeidi commented Apr 26, 2023 •

edited

Loading

ersin-erdal commented Apr 26, 2023 •

edited

Loading

CoenWarmer left a comment •

edited

Loading

maryam-saeidi commented May 2, 2023 •

edited

Loading