Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnifiedFieldList] Use drag icon #168856

Closed
Tracked by #168084
jughosta opened this issue Oct 13, 2023 · 1 comment · Fixed by #173673
Closed
Tracked by #168084

[UnifiedFieldList] Use drag icon #168856

jughosta opened this issue Oct 13, 2023 · 1 comment · Fixed by #173673
Assignees
@jughosta
Labels
Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@jughosta
Copy link
Contributor

jughosta commented Oct 13, 2023 •
edited
Loading

Reintroduce a drag icon for field list items.

It was added earlier but removed again as Eui did not have the new icon 1d8ae3b

Now we can use the new grabOmnidirectional token from Eui.

Image
@jughosta jughosta self-assigned this Oct 13, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 13, 2023
@jughosta jughosta added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Oct 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 17, 2023
@kertal kertal mentioned this issue Oct 18, 2023
Closed
@jughosta jughosta mentioned this issue Nov 20, 2023
Closed
@jughosta jughosta mentioned this issue Dec 19, 2023
Merged
3 tasks
jughosta added a commit that referenced this issue Jan 3, 2024
@jughosta @kibanamachine
[UnifiedFieldList] Show drag handle on item hover (#173673)
76e8121 
- Resolves #168856

## Summary

As per comment in
#171572 (comment)

> As a simple way to mitigate this issue, what if we changed it so that
on hover/focus of a field list item we fade-out the token and fade-in
the drag handle to replace the token (in the same position)? In doing
so, we could also keep the old translate x-axis transition (where the
field list item slides a few pixels to the right) to emphasize that it's
draggable. That little bit of extra movement might be good, if the
appearance of the drag handle is no longer pushing the text (given the
above suggestion).

![Dec-19-2023
18-13-21](https://github.com/elastic/kibana/assets/1415710/e02cb7d6-ce1a-4507-a8a6-3004f89d7225)


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[UnifiedFieldList] Show drag handle on item hover jughosta/kibana
2 participants
@jughosta @elasticmachine