Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnifiedFieldList] Show drag handle on item hover #173673

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Dec 19, 2023

Summary

As per comment in #171572 (comment)

As a simple way to mitigate this issue, what if we changed it so that on hover/focus of a field list item we fade-out the token and fade-in the drag handle to replace the token (in the same position)? In doing so, we could also keep the old translate x-axis transition (where the field list item slides a few pixels to the right) to emphasize that it's draggable. That little bit of extra movement might be good, if the appearance of the drag handle is no longer pushing the text (given the above suggestion).

Dec-19-2023 18-13-21

Checklist

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:UnifiedFieldList The unified field list component used by Lens & Discover labels Dec 19, 2023
@jughosta jughosta self-assigned this Dec 19, 2023
@jughosta
Copy link
Contributor Author

/ci

@jughosta
Copy link
Contributor Author

/ci

@jughosta
Copy link
Contributor Author

@elasticmachine merge upstream

@jughosta
Copy link
Contributor Author

/ci

@jughosta jughosta marked this pull request as ready for review December 20, 2023 10:19
@jughosta jughosta requested review from a team as code owners December 20, 2023 10:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with Safari 👍

I see in the original issue the token icon to be shown next to the new omnidirectional drag icon: is that still planned after this?

@jughosta
Copy link
Contributor Author

@dej611

I see in the original issue the token icon to be shown next to the new omnidirectional drag icon: is that still planned after this?

No, we tried it in #171572 but it creates content shift so this PR uses a different approach (more in #171572 (comment) ).

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍 Tested locally with Safari, Firefox, Chrome, Edge. Works as expected. I like this subtile change!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 592.3KB 594.6KB +2.3KB
lens 1.4MB 1.4MB +2.3KB
total +4.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks, @jughosta!

@jughosta jughosta merged commit 76e8121 into elastic:main Jan 3, 2024
19 checks passed
@jughosta jughosta deleted the 168856-field-list-drag-handle-v2 branch January 3, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:UnifiedFieldList The unified field list component used by Lens & Discover release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UnifiedFieldList] Use drag icon
7 participants