-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UnifiedFieldList] Show drag handle on item hover #173673
[UnifiedFieldList] Show drag handle on item hover #173673
Conversation
/ci |
/ci |
@elasticmachine merge upstream |
/ci |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally with Safari 👍
I see in the original issue the token icon to be shown next to the new omnidirectional drag icon: is that still planned after this?
No, we tried it in #171572 but it creates content shift so this PR uses a different approach (more in #171572 (comment) ). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM 👍 Tested locally with Safari, Firefox, Chrome, Edge. Works as expected. I like this subtile change!
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @jughosta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks, @jughosta!
Summary
As per comment in #171572 (comment)
Checklist