Kibana reporting prints screenshot error message if links panel is present in the dashboard #169276
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
(Deprecated) Feature:Reporting
Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Comments
bhavyarm
added
bug
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nickpeihl
added a commit
that referenced
this issue
Oct 23, 2023
Fixes #167713 and #169276 ## Summary It appears the dashboard links were not ready (still loading) when the test was trying to click on them. When they finish loading the element was stale, triggering the StaleElement error. This PR calls the RenderCompleteDispatcher on the Links embeddable when all of the child components have finished loading. In a future PR, we should consider re-factoring such that the async dashboard fetching happens in the LinksComponent and the results are passed as props to the DashboardLinkComponents. This would be more React-like. I resisted making that change in this PR so that we can fix the reporting error for v8.11. ## Flaky test runner 🤞 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3636 --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 23, 2023
Fixes elastic#167713 and elastic#169276 ## Summary It appears the dashboard links were not ready (still loading) when the test was trying to click on them. When they finish loading the element was stale, triggering the StaleElement error. This PR calls the RenderCompleteDispatcher on the Links embeddable when all of the child components have finished loading. In a future PR, we should consider re-factoring such that the async dashboard fetching happens in the LinksComponent and the results are passed as props to the DashboardLinkComponents. This would be more React-like. I resisted making that change in this PR so that we can fix the reporting error for v8.11. ## Flaky test runner 🤞 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3636 --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 513a31f)
kibanamachine
added a commit
that referenced
this issue
Oct 23, 2023
# Backport This will backport the following commits from `main` to `8.11`: - [[Dashboard navigation] Fix flaky test (#167896)](#167896) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nick Peihl","email":"nick.peihl@elastic.co"},"sourceCommit":{"committedDate":"2023-10-23T19:28:04Z","message":"[Dashboard navigation] Fix flaky test (#167896)\n\nFixes #167713 and #169276\r\n\r\n## Summary\r\n\r\nIt appears the dashboard links were not ready (still loading) when the\r\ntest was trying to click on them. When they finish loading the element\r\nwas stale, triggering the StaleElement error. This PR calls the\r\nRenderCompleteDispatcher on the Links embeddable when all of the child\r\ncomponents have finished loading.\r\n\r\nIn a future PR, we should consider re-factoring such that the async\r\ndashboard fetching happens in the LinksComponent and the results are\r\npassed as props to the DashboardLinkComponents. This would be more\r\nReact-like. I resisted making that change in this PR so that we can fix\r\nthe reporting error for v8.11.\r\n\r\n## Flaky test runner 🤞 \r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3636\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"513a31f83f454fbc83dfe983877620147c982833","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v8.11.0","v8.12.0"],"number":167896,"url":"https://github.com/elastic/kibana/pull/167896","mergeCommit":{"message":"[Dashboard navigation] Fix flaky test (#167896)\n\nFixes #167713 and #169276\r\n\r\n## Summary\r\n\r\nIt appears the dashboard links were not ready (still loading) when the\r\ntest was trying to click on them. When they finish loading the element\r\nwas stale, triggering the StaleElement error. This PR calls the\r\nRenderCompleteDispatcher on the Links embeddable when all of the child\r\ncomponents have finished loading.\r\n\r\nIn a future PR, we should consider re-factoring such that the async\r\ndashboard fetching happens in the LinksComponent and the results are\r\npassed as props to the DashboardLinkComponents. This would be more\r\nReact-like. I resisted making that change in this PR so that we can fix\r\nthe reporting error for v8.11.\r\n\r\n## Flaky test runner 🤞 \r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3636\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"513a31f83f454fbc83dfe983877620147c982833"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167896","number":167896,"mergeCommit":{"message":"[Dashboard navigation] Fix flaky test (#167896)\n\nFixes #167713 and #169276\r\n\r\n## Summary\r\n\r\nIt appears the dashboard links were not ready (still loading) when the\r\ntest was trying to click on them. When they finish loading the element\r\nwas stale, triggering the StaleElement error. This PR calls the\r\nRenderCompleteDispatcher on the Links embeddable when all of the child\r\ncomponents have finished loading.\r\n\r\nIn a future PR, we should consider re-factoring such that the async\r\ndashboard fetching happens in the LinksComponent and the results are\r\npassed as props to the DashboardLinkComponents. This would be more\r\nReact-like. I resisted making that change in this PR so that we can fix\r\nthe reporting error for v8.11.\r\n\r\n## Flaky test runner 🤞 \r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3636\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"513a31f83f454fbc83dfe983877620147c982833"}}]}] BACKPORT--> Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
|
Fixed by #167896 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version: 8.11.0 BC3
Elasticsearch version: 8.11.0 BC3
Browser version: chrome latest
Browser OS version: OS X
Original install method (e.g. download page, yum, from source, etc.): from staging
Describe the bug: If user adds a links panel in a dashboard and clicks share - reporting - Kibana prints screenshotting error in the report.
The text was updated successfully, but these errors were encountered: