Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLO panel in dashboard breaks Kibana reporting with screenshotting encountering a timeout error #169716

Closed
bhavyarm opened this issue Oct 24, 2023 · 4 comments · Fixed by #169929
Closed

SLO panel in dashboard breaks Kibana reporting with screenshotting encountering a timeout error #169716

bhavyarm opened this issue Oct 24, 2023 · 4 comments · Fixed by #169929
Assignees
@mgiota
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:SLO Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:obs-ux-management Observability Management User Experience Team

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Oct 24, 2023 •
edited
Loading

Kibana version: 8.11.0 BC3

Elasticsearch version: 8.11.0 BC3

Server OS version: darwin_aarch

Browser version: chrome latest

Browser OS version: os x

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: Added a SLO panel to dashboard and that breaks reporting. You see screenshotting encountering a timeout error on reports.

To reproduce:

  1. Add an slo panel to dashboard
  2. click on share ->reporting
Screenshot 2023-10-24 at 4 07 40 PM
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Project: Actionable Observability - DEPRECATED Deprecated - Do not use labels Oct 24, 2023
@kibanamachine kibanamachine added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Oct 24, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 24, 2023
@bhavyarm bhavyarm removed the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Oct 24, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 24, 2023
@bhavyarm bhavyarm added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" and removed needs-team Issues missing a team label labels Oct 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@mgiota mgiota self-assigned this Oct 24, 2023
@mgiota
Copy link
Contributor

mgiota commented Oct 25, 2023

Related to #169276

@mgiota mgiota removed loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Oct 26, 2023
@mgiota mgiota mentioned this issue Oct 26, 2023
Merged
mgiota added a commit that referenced this issue Nov 1, 2023
@mgiota @kibanamachine
[SLO][Embeddable] Fix Kibana reporting screenshot issue (#169929)
18dc8fe 
Resolves #169716

## 🍒 Summary
The reporting plugin waits for a renderComplete signal when the
embeddable has finished loading any data and is correctly rendered so
the headless Chromium can take a screenshot. This PR calls the
RenderCompleteDispatcher on the SLO Overview embeddable when all the
child components have finished loading.

https://elastic.slack.com/archives/CFFQ7RP9B/p1614267987040400

## How to test

- Add an SLO panel to the dashboard
- click on share -> PDF reports > Generate PDF on the top right
navigation bar
- No Timeout error should appear on the generated PDF

<img width="1407" alt="Screenshot 2023-10-26 at 15 05 05"
src="https://github.com/elastic/kibana/assets/2852703/45c2c868-edbe-426e-bc05-5794c2bfa91e">

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
delanni pushed a commit to delanni/kibana that referenced this issue Nov 6, 2023
@mgiota @kibanamachine @delanni
[SLO][Embeddable] Fix Kibana reporting screenshot issue (elastic#169929)
588c5f5 
Resolves elastic#169716

## 🍒 Summary
The reporting plugin waits for a renderComplete signal when the
embeddable has finished loading any data and is correctly rendered so
the headless Chromium can take a screenshot. This PR calls the
RenderCompleteDispatcher on the SLO Overview embeddable when all the
child components have finished loading.

https://elastic.slack.com/archives/CFFQ7RP9B/p1614267987040400

## How to test

- Add an SLO panel to the dashboard
- click on share -> PDF reports > Generate PDF on the top right
navigation bar
- No Timeout error should appear on the generated PDF

<img width="1407" alt="Screenshot 2023-10-26 at 15 05 05"
src="https://github.com/elastic/kibana/assets/2852703/45c2c868-edbe-426e-bc05-5794c2bfa91e">

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@mgiota mgiota added the Team:obs-ux-management Observability Management User Experience Team label Nov 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgiota mgiota

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:SLO Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SLO][Embeddable] Fix Kibana reporting screenshot issue mgiota/kibana
4 participants
@mgiota @bhavyarm @elasticmachine @kibanamachine