[SLO][Embeddable] Fix Kibana reporting screenshot issue #169929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
mgiota
added
release_note:fix
release_note:skip
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
mgiota
force-pushed
the
fix_slo_reporting_issue
branch
from
bad3931 to
44ff9aa
Compare
mgiota
commented
Oct 26, 2023
| this.node = node; | ||
| // required for the export feature to work | ||
| this.node.setAttribute('data-shared-item', ''); |
There was a problem hiding this comment.
This is needed according to this. Otherwise reporting wouldn't work
kdelemme
reviewed
Oct 26, 2023
Comment on lines
106
to
108
| if (!isLoading) { | ||
| onRenderComplete(); | ||
| } |
There was a problem hiding this comment.
🤔 I wonder if this is not triggered at every rerender? One way to check would be to console log something here.
mgiota
force-pushed
the
fix_slo_reporting_issue
branch
from
95fd0ca to
460f050
Compare
mgiota
force-pushed
the
fix_slo_reporting_issue
branch
from
460f050 to
01dcbcc
Compare
kdelemme
approved these changes
Oct 31, 2023
|
@elasticmachine merge upstream |
mgiota
force-pushed
the
fix_slo_reporting_issue
branch
from
c9c9fd8 to
e2ba41e
Compare
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @mgiota |
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Nov 6, 2023
Resolves elastic#169716 ## 🍒 Summary The reporting plugin waits for a renderComplete signal when the embeddable has finished loading any data and is correctly rendered so the headless Chromium can take a screenshot. This PR calls the RenderCompleteDispatcher on the SLO Overview embeddable when all the child components have finished loading. https://elastic.slack.com/archives/CFFQ7RP9B/p1614267987040400 ## How to test - Add an SLO panel to the dashboard - click on share -> PDF reports > Generate PDF on the top right navigation bar - No Timeout error should appear on the generated PDF <img width="1407" alt="Screenshot 2023-10-26 at 15 05 05" src="https://github.com/elastic/kibana/assets/2852703/45c2c868-edbe-426e-bc05-5794c2bfa91e"> --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
mgiota
added
the
Team:obs-ux-management
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #169716
🍒 Summary
The reporting plugin waits for a renderComplete signal when the embeddable has finished loading any data and is correctly rendered so the headless Chromium can take a screenshot. This PR calls the RenderCompleteDispatcher on the SLO Overview embeddable when all the child components have finished loading.
https://elastic.slack.com/archives/CFFQ7RP9B/p1614267987040400
How to test