Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing ES Promotion: FTR Configs #79 / discover/group3 discover default columns "before all" hook for "should render default columns" #176100

Closed
mistic opened this issue Feb 1, 2024 · 2 comments · Fixed by #176120
Assignees
Labels
failed-es-promotion impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@mistic
Copy link
Member

mistic commented Feb 1, 2024

Chrome UI Functional Tests
test/functional/apps/discover/group3/_default_columns.ts

discover/group3 discover default columns "before all" hook for "should render default columns"

This failure is preventing the promotion of the current Elasticsearch snapshot.

For more information on the Elasticsearch snapshot process including how to reproduce using the unverified ES build please read the failed promotion annotation. Other important information can be found at:

AggregateError: 
    Error: Bulk doc failure [operation=index]:
      doc: {"@timestamp":"2023-06-15T14:36:26.463Z","agent":"Mozilla/5.0 (X11; Linux i686) AppleWebKit/534.24 (KHTML, like Gecko) Chrome/11.0.696.50 Safari/534.24","bytes":206,"bytes_counter":78427335,"bytes_gauge":206,"clientip":"24.98.25.38","event":{"dataset":"sample_web_logs"},"extension":"","geo":{"coordinates":{"lat":41.992934150621295,"lon":-86.12801251932979},"dest":"TD","src":"US","srcdest":"US:TD"},"host":"www.elastic.co","index":"kibana_sample_data_logs","ip":"24.98.25.38","machine":{"os":"win 7","ram":15032385536},"message":"24.98.25.38 - - [2018-09-20T14:36:26.463Z] /"GET / HTTP/1.1/" 200 206 /"-/" /"Mozilla/5.0 (X11; Linux i686) AppleWebKit/534.24 (KHTML, like Gecko) Chrome/11.0.696.50 Safari/534.24/"","referer":"http://nytimes.com/success/valery-bykovsky","request":"/","response":"200","tags":["info","success"],"url":"https://www.elastic.co/products","utc_time":"2023-06-15T14:36:26.463Z"}
      error: {"type":"document_parsing_exception","reason":"[1:905] failed to parse: _id must be unset or set to [PPl4MT9wr3nRjFh0AAABiL98e98] but was [PPl4MYGl8aNGtSVXAAABiL98e98] because [kibana_sample_data_logstsdb] is in time_series mode","caused_by":{"type":"illegal_argument_exception","reason":"_id must be unset or set to [PPl4MT9wr3nRjFh0AAABiL98e98] but was [PPl4MYGl8aNGtSVXAAABiL98e98] because [kibana_sample_data_logstsdb] is in time_series mode"}}
        at Array.map (<anonymous>)
        at indexDocs (index_doc_records_stream.ts:64:13)
        at processTicksAndRejections (node:internal/process/task_queues:95:5)
        at Writable.write [as _write] (index_doc_records_stream.ts:78:9)
    at indexDocs (index_doc_records_stream.ts:64:13)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Writable.write [as _write] (index_doc_records_stream.ts:78:9)
@mistic mistic added failed-es-promotion Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Feb 1, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@mistic
Copy link
Member Author

mistic commented Feb 1, 2024

Skipped.

main: a8566d2

@davismcphee davismcphee added loe:small Small Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. labels Feb 1, 2024
@davismcphee davismcphee self-assigned this Feb 2, 2024
fkanout pushed a commit to fkanout/kibana that referenced this issue Feb 7, 2024
fkanout pushed a commit to fkanout/kibana that referenced this issue Feb 7, 2024
## Summary

This RP updates two `data.json.gz` files to remove all doc IDs (which is
unsupported according to
elastic#176109 (comment)),
which started causing failings after tsid hashing was implemented by ES
in elastic/elasticsearch#98023.

Resolves elastic#176103.
Resolves elastic#176102.
Resolves elastic#176100.
Resolves elastic#176107.
Resolves elastic#176108.
Resolves elastic#176109.

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
## Summary

This RP updates two `data.json.gz` files to remove all doc IDs (which is
unsupported according to
elastic#176109 (comment)),
which started causing failings after tsid hashing was implemented by ES
in elastic/elasticsearch#98023.

Resolves elastic#176103.
Resolves elastic#176102.
Resolves elastic#176100.
Resolves elastic#176107.
Resolves elastic#176108.
Resolves elastic#176109.

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
## Summary

This RP updates two `data.json.gz` files to remove all doc IDs (which is
unsupported according to
elastic#176109 (comment)),
which started causing failings after tsid hashing was implemented by ES
in elastic/elasticsearch#98023.

Resolves elastic#176103.
Resolves elastic#176102.
Resolves elastic#176100.
Resolves elastic#176107.
Resolves elastic#176108.
Resolves elastic#176109.

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-es-promotion impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants