Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing ES Promotion: FTR Configs #25 / visualize app visual builder tsdb check "before all" hook for "should render from a tsdb dataView regular fields with no issues" #176109

Closed
mistic opened this issue Feb 1, 2024 · 5 comments · Fixed by #176120
Assignees
Labels
failed-es-promotion Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mistic
Copy link
Member

mistic commented Feb 1, 2024

Chrome UI Functional Tests
test/functional/apps/visualize/group6/_tsvb_tsdb_basic.ts

visualize app visual builder tsdb check "before all" hook for "should render from a tsdb dataView regular fields with no issues"

This failure is preventing the promotion of the current Elasticsearch snapshot.

For more information on the Elasticsearch snapshot process including how to reproduce using the unverified ES build please read the failed promotion annotation. Other important information can be found at:

AggregateError: 
    Error: Bulk doc failure [operation=index]:
      doc: {"@timestamp":"2023-06-15T14:36:26.463Z","agent":"Mozilla/5.0 (X11; Linux i686) AppleWebKit/534.24 (KHTML, like Gecko) Chrome/11.0.696.50 Safari/534.24","bytes":206,"bytes_counter":78427335,"bytes_gauge":206,"clientip":"24.98.25.38","event":{"dataset":"sample_web_logs"},"extension":"","geo":{"coordinates":{"lat":41.992934150621295,"lon":-86.12801251932979},"dest":"TD","src":"US","srcdest":"US:TD"},"host":"www.elastic.co","index":"kibana_sample_data_logs","ip":"24.98.25.38","machine":{"os":"win 7","ram":15032385536},"message":"24.98.25.38 - - [2018-09-20T14:36:26.463Z] /"GET / HTTP/1.1/" 200 206 /"-/" /"Mozilla/5.0 (X11; Linux i686) AppleWebKit/534.24 (KHTML, like Gecko) Chrome/11.0.696.50 Safari/534.24/"","referer":"http://nytimes.com/success/valery-bykovsky","request":"/","response":"200","tags":["info","success"],"url":"https://www.elastic.co/products","utc_time":"2023-06-15T14:36:26.463Z"}
      error: {"type":"document_parsing_exception","reason":"[1:905] failed to parse: _id must be unset or set to [PPl4MT9wr3nRjFh0AAABiL98e98] but was [PPl4MYGl8aNGtSVXAAABiL98e98] because [kibana_sample_data_logstsdb] is in time_series mode","caused_by":{"type":"illegal_argument_exception","reason":"_id must be unset or set to [PPl4MT9wr3nRjFh0AAABiL98e98] but was [PPl4MYGl8aNGtSVXAAABiL98e98] because [kibana_sample_data_logstsdb] is in time_series mode"}}
        at Array.map (<anonymous>)
        at indexDocs (index_doc_records_stream.ts:64:13)
        at processTicksAndRejections (node:internal/process/task_queues:95:5)
        at Writable.write [as _write] (index_doc_records_stream.ts:78:9)
    at indexDocs (index_doc_records_stream.ts:64:13)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Writable.write [as _write] (index_doc_records_stream.ts:78:9)

@mistic mistic added blocker Team:Visualizations Visualization editors, elastic-charts and infrastructure skipped-test failed-es-promotion v8.13.0 labels Feb 1, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mistic
Copy link
Member Author

mistic commented Feb 1, 2024

Skipped.

main: 7c45bfd

@stratoula
Copy link
Contributor

@dej611 can you check this as it is tsdb related? 🙏

@salvatore-campagna
Copy link

salvatore-campagna commented Feb 2, 2024

Trying to guess here what is happening.

You have a dataset saved in some storage that includes documents with an _id filed and a specific value.
You load the dataset and index it (probably a sample dataset).
Note that setting the _id field in time_series mode is not allowed because of routing reasons and constraints about where the document is indexed.
When you load the dataset and index it you probably index the whole document including the _id.
You should index the document without specifying the _id.

If you ask "why is this happening now but not before?" I guess the answer is "because before it was matching the expected value". Now ids are different because we changed the way the _tsid is generated and the _tsid is used as input to calculate the document _id.

@salvatore-campagna
Copy link

salvatore-campagna commented Feb 2, 2024

See a similar issue elastic/elasticsearch#101212

@davismcphee davismcphee self-assigned this Feb 2, 2024
fkanout pushed a commit to fkanout/kibana that referenced this issue Feb 7, 2024
fkanout pushed a commit to fkanout/kibana that referenced this issue Feb 7, 2024
## Summary

This RP updates two `data.json.gz` files to remove all doc IDs (which is
unsupported according to
elastic#176109 (comment)),
which started causing failings after tsid hashing was implemented by ES
in elastic/elasticsearch#98023.

Resolves elastic#176103.
Resolves elastic#176102.
Resolves elastic#176100.
Resolves elastic#176107.
Resolves elastic#176108.
Resolves elastic#176109.

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
## Summary

This RP updates two `data.json.gz` files to remove all doc IDs (which is
unsupported according to
elastic#176109 (comment)),
which started causing failings after tsid hashing was implemented by ES
in elastic/elasticsearch#98023.

Resolves elastic#176103.
Resolves elastic#176102.
Resolves elastic#176100.
Resolves elastic#176107.
Resolves elastic#176108.
Resolves elastic#176109.

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
## Summary

This RP updates two `data.json.gz` files to remove all doc IDs (which is
unsupported according to
elastic#176109 (comment)),
which started causing failings after tsid hashing was implemented by ES
in elastic/elasticsearch#98023.

Resolves elastic#176103.
Resolves elastic#176102.
Resolves elastic#176100.
Resolves elastic#176107.
Resolves elastic#176108.
Resolves elastic#176109.

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-es-promotion Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants