Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security][Bug][Benchmark Rules] Elements of the Benchmark Rules page are not responsive similar to other Kibana products #181641

Closed
seanrathier opened this issue Apr 24, 2024 · 1 comment · Fixed by #191080
Closed

[Cloud Security][Bug][Benchmark Rules] Elements of the Benchmark Rules page are not responsive similar to other Kibana products #181641

seanrathier opened this issue Apr 24, 2024 · 1 comment · Fixed by #191080
Assignees
@maxcold
Labels
bug Fixes for quality problems that affect the customer experience csp: quick win cloud-security label: tagging issues which are relatively small in effort and lowered in priority good first issue low hanging fruit Team:Cloud Security Cloud Security team related

Comments

@seanrathier
Copy link
Contributor

seanrathier commented Apr 24, 2024 •
edited
Loading

Resizing the Security Rules Benchmarks table shows buttons and metrics hanging over the page.

Preconditions
Cloud security benchmark rules are populated (for example, has CIS AWS rules)

To Reproduce
Steps to reproduce the behaviour:

  1. Resize the browser with browser developer tools open
  2. Resize to 825 x 881

Expected Behavior
The background should fill the empty space
The UI elements should not overflow the content background

Screenshots

Screen.Recording.2024-04-24.at.4.28.51.PM.mov

Screenshot 2024-04-24 at 4 25 27 PM

Should look like this without the browser background showing.
Screenshot 2024-04-24 at 4 45 26 PM

Desktop (please complete the following information):

  • OS: MacOs
  • Browser: Chrome
  • Kibana Version: 8.14.0
@seanrathier seanrathier added the Team:Cloud Security Cloud Security team related label Apr 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@seanrathier seanrathier added bug Fixes for quality problems that affect the customer experience triage_needed and removed bug Fixes for quality problems that affect the customer experience labels Apr 25, 2024
@seanrathier seanrathier mentioned this issue Apr 25, 2024
Closed
@kfirpeled kfirpeled added good first issue low hanging fruit csp: quick win cloud-security label: tagging issues which are relatively small in effort and lowered in priority bug Fixes for quality problems that affect the customer experience and removed triage_needed labels May 6, 2024
@maxcold maxcold mentioned this issue Aug 22, 2024
Merged
@maxcold maxcold self-assigned this Aug 22, 2024
maxcold added a commit that referenced this issue Aug 22, 2024
@maxcold
[Cloud Security] fix responsiveness on the Benchmark Rules page (#191080
801c17f 
)

## Summary

It ain't much but it's honest work

- fixes #181641
- part pf elastic/security-team#10316

## Screencast
tbh before is not as bad as in the linked ticket, so we can also leave
it as it is until we do responsiveness on this page properly.

before


[screencast-localhost_5601-2024.08.22-15_14_34.webm](https://github.com/user-attachments/assets/4f119203-6a91-4a52-9514-3489789649ce)

after


[screencast-localhost_5601-2024.08.22-15_05_32.webm](https://github.com/user-attachments/assets/36276e71-8d2d-4095-b2b6-e5524f6d0692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxcold maxcold

Labels
bug Fixes for quality problems that affect the customer experience csp: quick win cloud-security label: tagging issues which are relatively small in effort and lowered in priority good first issue low hanging fruit Team:Cloud Security Cloud Security team related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cloud Security] fix responsiveness on the Benchmark Rules page elastic/kibana
4 participants
@maxcold @seanrathier @elasticmachine @kfirpeled