Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] fix responsiveness on the Benchmark Rules page #191080

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

maxcold
Copy link
Contributor

@maxcold maxcold commented Aug 22, 2024

Summary

It ain't much but it's honest work

Screencast

tbh before is not as bad as in the linked ticket, so we can also leave it as it is until we do responsiveness on this page properly.

before

screencast-localhost_5601-2024.08.22-15_14_34.webm

after

screencast-localhost_5601-2024.08.22-15_05_32.webm

@maxcold maxcold added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting 8.16 candidate labels Aug 22, 2024
@maxcold maxcold requested a review from a team as a code owner August 22, 2024 13:16
@maxcold
Copy link
Contributor Author

maxcold commented Aug 22, 2024

Actually I stand corrected, I could reproduce the video from the attached issue with the device toolbar opened. But allowing elements of the flexbox to wrap fixes it

screencast-localhost_5601-2024.08.22-15_23_36.webm

Copy link
Contributor

@JordanSh JordanSh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #83 / Cloud Security Posture Test adding Cloud Security Posture Integrations CSPM GCP CIS_GCP Single Post Installation Google Cloud Shell modal pops up after user clicks on Save button when adding integration, when there are no Project ID, it should use default value

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 480.2KB 480.2KB +10.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@maxcold maxcold merged commit 801c17f into main Aug 22, 2024
21 checks passed
@maxcold maxcold deleted the csp-fix-responsiveness-rules-page branch August 22, 2024 15:38
@bhavyarm bhavyarm added the Team:Cloud Security Cloud Security team related label Oct 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.16 candidate backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.16.0
Projects
None yet
6 participants