[new-platform] migrate ui/chrome APIs to new platform #20696
Assignees
Labels
Feature:New Platform
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Comments
spalger
added
Team:Core
spalger
changed the title
Closed
spalger
pushed a commit
that referenced
this issue
Jul 18, 2018
Fixes #20694 Implements super basic new platform `core` system, which includes two services: `core.injectedMetadata` and `core.legacyPlatform`. The `core` currently has two responsibilities: 1. read the metadata from the DOM and initialize the `ui/metadata` module with legacy metadata, proving out how we plan to expose data from the new platform through the existing APIs/modules to the legacy platform. 2. bootstrap the legacy platform by loading either `ui/chrome` or `ui/test_harness` Because `core` mutates the `ui/metadata` module before bootstrapping the legacy platform all existing consumers of `ui/metadata` won't be impacted by the fact that metadata loading was moved into the new platform. We plan to do this for many other services that will need to exist in both the legacy and new platforms, like `ui/chrome` (see #20696).
spalger
pushed a commit
to spalger/kibana
that referenced
this issue
Jul 18, 2018
…tic#20699) Fixes elastic#20694 Implements super basic new platform `core` system, which includes two services: `core.injectedMetadata` and `core.legacyPlatform`. The `core` currently has two responsibilities: 1. read the metadata from the DOM and initialize the `ui/metadata` module with legacy metadata, proving out how we plan to expose data from the new platform through the existing APIs/modules to the legacy platform. 2. bootstrap the legacy platform by loading either `ui/chrome` or `ui/test_harness` Because `core` mutates the `ui/metadata` module before bootstrapping the legacy platform all existing consumers of `ui/metadata` won't be impacted by the fact that metadata loading was moved into the new platform. We plan to do this for many other services that will need to exist in both the legacy and new platforms, like `ui/chrome` (see elastic#20696).
spalger
pushed a commit
that referenced
this issue
Jul 18, 2018
…) (#20913) Fixes #20694 Implements super basic new platform `core` system, which includes two services: `core.injectedMetadata` and `core.legacyPlatform`. The `core` currently has two responsibilities: 1. read the metadata from the DOM and initialize the `ui/metadata` module with legacy metadata, proving out how we plan to expose data from the new platform through the existing APIs/modules to the legacy platform. 2. bootstrap the legacy platform by loading either `ui/chrome` or `ui/test_harness` Because `core` mutates the `ui/metadata` module before bootstrapping the legacy platform all existing consumers of `ui/metadata` won't be impacted by the fact that metadata loading was moved into the new platform. We plan to do this for many other services that will need to exist in both the legacy and new platforms, like `ui/chrome` (see #20696).
spalger
pushed a commit
that referenced
this issue
Aug 17, 2018
…21967) Part of #20696, required for #20697 This migrates the `chrome.loadingCount` API to the new platform, which was not planned to happen before #20697 but is required as the UiSettingsClient uses the loading count to activate the global loading indicator in Kibana. This service is pretty simple, it allows adding an observable with `core.loadingCount.add(observable)` that will be subscribed to in order to contribute to the current "loading count", which can be retrieved with `core.loadingCount.get$()`. The `ui/chrome/api/loading_count` module is taking the start contract from the service and re-exposing it via the existing `chrome.loadingCount` api that we have today, including `increment()`, `decrement()`, `subscribe()`, and the automatic watching of the loading count exposed by the angular `$http` service.
spalger
pushed a commit
to spalger/kibana
that referenced
this issue
Aug 17, 2018
…lastic#21967) Part of elastic#20696, required for elastic#20697 This migrates the `chrome.loadingCount` API to the new platform, which was not planned to happen before elastic#20697 but is required as the UiSettingsClient uses the loading count to activate the global loading indicator in Kibana. This service is pretty simple, it allows adding an observable with `core.loadingCount.add(observable)` that will be subscribed to in order to contribute to the current "loading count", which can be retrieved with `core.loadingCount.get$()`. The `ui/chrome/api/loading_count` module is taking the start contract from the service and re-exposing it via the existing `chrome.loadingCount` api that we have today, including `increment()`, `decrement()`, `subscribe()`, and the automatic watching of the loading count exposed by the angular `$http` service.
This was referenced Sep 10, 2018
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dependencies:
Once the
UiSettingsClientis migrated we can bring over theui/chromeAPIs. The plan is to split up the APIs and logic withinui/chromeinto a small collection of services within the new platform core that will be re-exposed viaui/chromeusing the same APIs available today. Because of this apps that useui/chromewon't need to be updated, but apps that are built on the new platform in the future will be able to access the same functionality without depending on the legacy platform.After moving the APIs to the new platform we will be able to move the UI to the new platform and EUI in #19992
leave in ui/chrome:
setRootController()setupAngular()dangerouslyGetActiveInjector()getSavedObjectsClient()(for now, we need to figure out how to handle theAutoCreateIndexErrorPagefirst)The following sections represent the APIs that will be moved over to the new platform core, but will still be re-exposed via
ui/chromeusing the current APIs. For methods that are based on observables, but historically exposed information synchronously, a subscription will be held withinui/chromeso that cached values can still be exposed synchronously.corechrome.getInjected(name)core.injectedVars.get(name)chrome.getKibanaVersion()core.injectedMetadata.getKibanaVersion()chrome.getXsrfToken()core.injectedMetadata.getXsrfToken()chrome.getAppId()core.injectedMetadata.getAppId()chrome.getBasePath()core.basePath.get(path)chrome.addBasePath(path)core.basePath.addToPath(path)chrome.removeBasePath(path)core.basePath.removeFromPath(path)chrome.setVisible()core.chrome.setVisible()chrome.getVisible()core.chrome.getIsVisible$()chrome.addApplicationClass()core.chrome.addApplicationClass()chrome.removeApplicationClass()core.chrome.removeApplicationClass()chrome.getApplicationClasses()core.chrome.getApplicationClasses$()chrome.trackSubUrlForApp(id, lastUrl)core.navLinks.setLastUrl(id, lastUrl)chrome.showOnlyById(id)core.navLinks.showOnly(id)chrome.navLinkExists(id)core.navLinks.exists(id)chrome.getNavLinkById(id).hide = truecore.navLinks.hide(navLinkId)chrome.getNavLinkById(id).urlcore.navLinks.getUrl(id)chrome.getNavLinkById(id).hidecore.navLinks.getHiddenIds$().toPromise().includes(id)chrome.getNavLinkById(id).lastSubUrlcore.navLinks.getSubUrlsById$().toPromise()[id]chrome.loadingCount.increment()core.loadingCount.increment()chrome.loadingCount.decrement()core.loadingCount.decrement()core.loadingCount.add(observable)chrome.loadingCount.subscribe(handler)core.loadingCount.get$()chrome.getUiSettingsClient()core.uiSettingsAll APIs that are not listed here will be removed from
ui/chromeThe text was updated successfully, but these errors were encountered: