Migrate chrome injected vars API to new platform #22911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
spalger
force-pushed
the
migrate-new-platform/injected-vars
branch
from
c508e54
to
ce20392
Compare
|
ack: I can review this PR on Monday only (I'm off for this week) unless Court will review it earlier. |
This comment has been minimized.
This comment has been minimized.
added 2 commits
September 11, 2018 10:28
This comment has been minimized.
This comment has been minimized.
epixa
reviewed
Sep 11, 2018
spalger
commented
Sep 11, 2018
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Sep 14, 2018
* [core/public/injectedMetadat] migrate injected metadata APIs * [ui/replaceInjectedVars] fix test * [tests/browser] move injectedVars out of legacyMetadata * [core/public/injectedMetadata] add types for legacyMetadata * [tests/browser] move uiSettings back into legacyMetadata * [tests/browser] fix old references to legacyMetadata * [tests/browser] remove old tests * [core/public/deepFreeze] fix snapshot for removal of ReadonlyArray * [chrome/apis] use slightly less permissive types for `chrome` argument
spalger
pushed a commit
that referenced
this pull request
Sep 14, 2018
* [core/public/injectedMetadat] migrate injected metadata APIs * [ui/replaceInjectedVars] fix test * [tests/browser] move injectedVars out of legacyMetadata * [core/public/injectedMetadata] add types for legacyMetadata * [tests/browser] move uiSettings back into legacyMetadata * [tests/browser] fix old references to legacyMetadata * [tests/browser] remove old tests * [core/public/deepFreeze] fix snapshot for removal of ReadonlyArray * [chrome/apis] use slightly less permissive types for `chrome` argument
|
6.5/6.x: 816cd17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the last parts of #20696, adds methods to the
InjectedMetadataservice for reading one or all of the injected vars and updatesui/chrometo consume them. No changes were made to the public API so everything should behave just as it always has.