Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fatal error adding sample data to dashboard #20807

Closed
liza-mae opened this issue Jul 14, 2018 · 6 comments · Fixed by #20897
Closed

Fatal error adding sample data to dashboard #20807

liza-mae opened this issue Jul 14, 2018 · 6 comments · Fixed by #20897
Assignees
@nreese
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Add Data Add Data and sample data feature on Home Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.4.0

Comments

@liza-mae
Copy link
Contributor

liza-mae commented Jul 14, 2018 •
edited
Loading

Kibana version: master
Elasticsearch version: master
Server OS version: Linux
Browser version: Chrome
Browser OS version: Latest
Original install method (e.g. download page, yum, from source, etc.): Snapshots

Describe the bug:
Uncaught TypeError: Can not read property 'toFixed' of undefined, launching sample data functional test

Steps to reproduce:

Run functional test 'should launch sample data set dashboard'
@liza-mae liza-mae added the bug Fixes for quality problems that affect the customer experience label Jul 14, 2018
@liza-mae
Copy link
Contributor Author

https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-selenium/6766/consoleFull

@liza-mae
Copy link
Contributor Author

Fatal Error
Uncaught TypeError: Cannot read property 'toFixed' of undefined (http://localhost:5620/bundles/kibana.bundle.js:102965)
Version: 7.0.0-alpha1
Build: 9007199254740991
Error: Uncaught TypeError: Cannot read property 'toFixed' of undefined (http://localhost:5620/bundles/kibana.bundle.js:102965)
at window.onerror (http://localhost:5620/bundles/commons.bundle.js:69137:32)
at Object.invokeGuardedCallbackDev (http://localhost:5620/bundles/vendors.bundle.js:157501:16)
at invokeGuardedCallback (http://localhost:5620/bundles/vendors.bundle.js:157550:29)
at replayUnitOfWork (http://localhost:5620/bundles/vendors.bundle.js:168661:7)
at renderRoot (http://localhost:5620/bundles/vendors.bundle.js:169228:11)
at performWorkOnRoot (http://localhost:5620/bundles/vendors.bundle.js:169781:24)
at performWork (http://localhost:5620/bundles/vendors.bundle.js:169702:9)
at performSyncWork (http://localhost:5620/bundles/vendors.bundle.js:169679:5)
at requestWork (http://localhost:5620/bundles/vendors.bundle.js:169579:7)
at scheduleWorkImpl (http://localhost:5620/bundles/vendors.bundle.js:169454:13)
Fatal Error
Uncaught TypeError: Cannot read property 'toFixed' of undefined (http://localhost:5620/bundles/kibana.bundle.js:102965)
Version: 7.0.0-alpha1
Build: 9007199254740991
Error: Uncaught TypeError: Cannot read property 'toFixed' of undefined (http://localhost:5620/bundles/kibana.bundle.js:102965)
at window.onerror (http://localhost:5620/bundles/commons.bundle.js:69137:32)
at Object.invokeGuardedCallbackDev (http://localhost:5620/bundles/vendors.bundle.js:157501:16)
at invokeGuardedCallback (http://localhost:5620/bundles/vendors.bundle.js:157550:29)
at replayUnitOfWork (http://localhost:5620/bundles/vendors.bundle.js:168661:7)
at renderRoot (http://localhost:5620/bundles/vendors.bundle.js:169228:11)
at performWorkOnRoot (http://localhost:5620/bundles/vendors.bundle.js:169781:24)
at performWork (http://localhost:5620/bundles/vendors.bundle.js:169702:9)
at performSyncWork (http://localhost:5620/bundles/vendors.bundle.js:169679:5)
at requestWork (http://localhost:5620/bundles/vendors.bundle.js:169579:7)
at scheduleWorkImpl (http://localhost:5620/bundles/vendors.bundle.js:169454:13)

@liza-mae
Copy link
Contributor Author

homepage app sample data dashboard should launch sample data set dashboard

@liza-mae liza-mae added Feature:Add Data Add Data and sample data feature on Home :Sharing Feature:Home Kibana home application triage_needed labels Jul 14, 2018
liza-mae pushed a commit to liza-mae/kibana that referenced this issue Jul 14, 2018
Skipping sample data test due to bug elastic#20807, let's see if rest…
b910deb 
… of the tests pass
@liza-mae liza-mae changed the title Fatal error sample data launch Fatal error adding sample data to dashboard Jul 14, 2018
@liza-mae liza-mae added Feature:Dashboard Dashboard related features v7.0.0 blocker v6.4.0 and removed Feature:Home Kibana home application v7.0.0 labels Jul 14, 2018
liza-mae pushed a commit to liza-mae/kibana that referenced this issue Jul 14, 2018
Skipping test due to bug elastic#20807
96a2e45
@liza-mae liza-mae mentioned this issue Jul 14, 2018
Merged
@nreese nreese self-assigned this Jul 14, 2018
@nreese nreese mentioned this issue Jul 14, 2018
Merged
@nreese
Copy link
Contributor

nreese commented Jul 14, 2018 •
edited
Loading

There are 2 factors highlighted by this failure

  1. the loaded sample data had a large hole so there where no documents for the last 24 hours, the time window of the dashboard
  2. the range control destroys kibana when no data is covered by the time range.

I have opened #20811 to address 2. 1 will need further investigation.

liza-mae added a commit that referenced this issue Jul 15, 2018
@liza-mae
Skipping test due to bug #20807 (#20809)
e8af080
@liza-mae liza-mae mentioned this issue Jul 15, 2018
Merged
liza-mae added a commit to liza-mae/kibana that referenced this issue Jul 15, 2018
@liza-mae
Skipping test due to bug elastic#20807 (elastic#20809)
7f4af48
liza-mae added a commit that referenced this issue Jul 15, 2018
@liza-mae
Skipping test due to bug #20807 (#20809) (#20812)
ecafae1
@stacey-gammon
Copy link
Contributor

@nreese - do you know how to repro the range control issue? I added one to a dashboard with no data and set the time range very old, but no crash

screen shot 2018-07-16 at 8 34 56 am

@nreese
Copy link
Contributor

nreese commented Jul 16, 2018

Looks like the range control has a range set in that screen shot. Try opening the dashboard in a fresh browser tab with the global state pointing to the time period with no data. It works if the range control is first loaded with data but then moves to a period with no data. #20002 re-introduced this issue.

yankouskia pushed a commit to yankouskia/kibana that referenced this issue Jul 16, 2018
@liza-mae
Skipping test due to bug elastic#20807 (elastic#20809)
0f75cb7
@LeeDr LeeDr mentioned this issue Jul 17, 2018
Open
@nreese nreese mentioned this issue Jul 17, 2018
Merged
liza-mae added a commit that referenced this issue Jul 18, 2018
@liza-mae
Improve visualization tests (#20782)
4551dfc 
* Improve tests for histogram, tag cloud, input controls and enable lab mode.

* enable skipped tests

* Update shakespeare test navigation to visualize

* Add sleep to shakespeare test

* Skip shakespeare test for now, it is not clear why it is failing and does not fail locally, need the other tests to run in CI

* Revert selector for selectAggregation, re-enable shakespeare test

* skip vega spec text test, was not fixed with changes

* Enable only visualize tests to run, need to see results and it's being blocked by other test failures

* Enable all tests again, visualization tests all passed

* Skipping sample data test due to bug #20807, let's see if rest of the tests pass
liza-mae added a commit to liza-mae/kibana that referenced this issue Jul 18, 2018
@liza-mae
Improve visualization tests (elastic#20782)
6865ec2 
* Improve tests for histogram, tag cloud, input controls and enable lab mode.

* enable skipped tests

* Update shakespeare test navigation to visualize

* Add sleep to shakespeare test

* Skip shakespeare test for now, it is not clear why it is failing and does not fail locally, need the other tests to run in CI

* Revert selector for selectAggregation, re-enable shakespeare test

* skip vega spec text test, was not fixed with changes

* Enable only visualize tests to run, need to see results and it's being blocked by other test failures

* Enable all tests again, visualization tests all passed

* Skipping sample data test due to bug elastic#20807, let's see if rest of the tests pass
liza-mae added a commit that referenced this issue Jul 18, 2018
@liza-mae
Improve visualization tests (#20782) (#20932)
0b39582 
* Improve tests for histogram, tag cloud, input controls and enable lab mode.

* enable skipped tests

* Update shakespeare test navigation to visualize

* Add sleep to shakespeare test

* Skip shakespeare test for now, it is not clear why it is failing and does not fail locally, need the other tests to run in CI

* Revert selector for selectAggregation, re-enable shakespeare test

* skip vega spec text test, was not fixed with changes

* Enable only visualize tests to run, need to see results and it's being blocked by other test failures

* Enable all tests again, visualization tests all passed

* Skipping sample data test due to bug #20807, let's see if rest of the tests pass
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed :Sharing labels Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Add Data Add Data and sample data feature on Home Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

avoid day long gaps in sample data nreese/kibana
4 participants
@nreese @timroes @stacey-gammon @liza-mae