Improve visualization tests #20782
Merged
Improve visualization tests #20782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liza-mae
added
test
Feature:Visualizations
💔 Build Failed |
|
jenkins test this |
added 3 commits
July 13, 2018 13:13
…does not fail locally, need the other tests to run in CI
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
jenkins test this |
💔 Build Failed |
…g blocked by other test failures
💚 Build Succeeded |
💔 Build Failed |
… of the tests pass
💚 Build Succeeded |
|
Jenkins, test this |
💚 Build Succeeded |
💚 Build Succeeded |
|
jenkins test this |
💚 Build Succeeded |
|
jenkins test this |
💚 Build Succeeded |
|
jenkins test this |
💚 Build Succeeded |
💚 Build Succeeded |
|
Jenkins, test this |
timroes
approved these changes
Jul 18, 2018
💚 Build Succeeded |
liza-mae
added a commit
to liza-mae/kibana
that referenced
this pull request
Jul 18, 2018
* Improve tests for histogram, tag cloud, input controls and enable lab mode. * enable skipped tests * Update shakespeare test navigation to visualize * Add sleep to shakespeare test * Skip shakespeare test for now, it is not clear why it is failing and does not fail locally, need the other tests to run in CI * Revert selector for selectAggregation, re-enable shakespeare test * skip vega spec text test, was not fixed with changes * Enable only visualize tests to run, need to see results and it's being blocked by other test failures * Enable all tests again, visualization tests all passed * Skipping sample data test due to bug elastic#20807, let's see if rest of the tests pass
liza-mae
added a commit
that referenced
this pull request
Jul 18, 2018
* Improve tests for histogram, tag cloud, input controls and enable lab mode. * enable skipped tests * Update shakespeare test navigation to visualize * Add sleep to shakespeare test * Skip shakespeare test for now, it is not clear why it is failing and does not fail locally, need the other tests to run in CI * Revert selector for selectAggregation, re-enable shakespeare test * skip vega spec text test, was not fixed with changes * Enable only visualize tests to run, need to see results and it's being blocked by other test failures * Enable all tests again, visualization tests all passed * Skipping sample data test due to bug #20807, let's see if rest of the tests pass
This was referenced Jul 19, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to improve the visualization tests. This PR should cover issues:
#20388 flaky histogram tests
#20387 flaky tag cloud tests
#20325 enable lab mode tests
It may improve issues with input control.
Also re-enabling remaining skipped tests in input control, tsvb, vega chart and linked saved searches.