-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Exception item comments with new lines do not display the new lines in UI #208956
Labels
bug
Fixes for quality problems that affect the customer experience
Team:Detection Engine
Security Solution Detection Engine Area
Comments
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
marshallmain
added a commit
that referenced
this issue
Feb 10, 2025
…208959) ## Summary Fixes #208956 ## Before ![image](https://github.com/user-attachments/assets/aa9b00e9-da70-4ff2-be18-4073235e8a85) ## After ![image](https://github.com/user-attachments/assets/0fa2a69c-836d-4e98-8ecb-be88d1170519)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Feb 10, 2025
…lastic#208959) ## Summary Fixes elastic#208956 ## Before ![image](https://github.com/user-attachments/assets/aa9b00e9-da70-4ff2-be18-4073235e8a85) ## After ![image](https://github.com/user-attachments/assets/0fa2a69c-836d-4e98-8ecb-be88d1170519) (cherry picked from commit 1b8bdcf)
This was referenced Feb 11, 2025
marshallmain
added a commit
to marshallmain/kibana
that referenced
this issue
Feb 11, 2025
…lastic#208959) ## Summary Fixes elastic#208956 ## Before ![image](https://github.com/user-attachments/assets/aa9b00e9-da70-4ff2-be18-4073235e8a85) ## After ![image](https://github.com/user-attachments/assets/0fa2a69c-836d-4e98-8ecb-be88d1170519) (cherry picked from commit 1b8bdcf)
marshallmain
added a commit
to marshallmain/kibana
that referenced
this issue
Feb 11, 2025
…lastic#208959) ## Summary Fixes elastic#208956 ## Before ![image](https://github.com/user-attachments/assets/aa9b00e9-da70-4ff2-be18-4073235e8a85) ## After ![image](https://github.com/user-attachments/assets/0fa2a69c-836d-4e98-8ecb-be88d1170519) (cherry picked from commit 1b8bdcf)
marshallmain
added a commit
that referenced
this issue
Feb 11, 2025
…nts (#208959) (#210568) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Fix whitespace/newlines for exception comments (#208959)](#208959) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marshall Main","email":"55718608+marshallmain@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-10T23:17:49Z","message":"[Security Solution] Fix whitespace/newlines for exception comments (#208959)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208956\r\n\r\n## Before\r\n\r\n![image](https://github.com/user-attachments/assets/aa9b00e9-da70-4ff2-be18-4073235e8a85)\r\n\r\n## After\r\n\r\n![image](https://github.com/user-attachments/assets/0fa2a69c-836d-4e98-8ecb-be88d1170519)","sha":"1b8bdcff677773afa1ac42a1410ca58e0db49964","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:Detection Engine","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Fix whitespace/newlines for exception comments","number":208959,"url":"https://github.com/elastic/kibana/pull/208959","mergeCommit":{"message":"[Security Solution] Fix whitespace/newlines for exception comments (#208959)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208956\r\n\r\n## Before\r\n\r\n![image](https://github.com/user-attachments/assets/aa9b00e9-da70-4ff2-be18-4073235e8a85)\r\n\r\n## After\r\n\r\n![image](https://github.com/user-attachments/assets/0fa2a69c-836d-4e98-8ecb-be88d1170519)","sha":"1b8bdcff677773afa1ac42a1410ca58e0db49964"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/210480","number":210480,"state":"MERGED","mergeCommit":{"sha":"b3c129502eff48d1b8292962391afe57c09626a5","message":"[9.0] [Security Solution] Fix whitespace/newlines for exception comments (#208959) (#210480)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Security Solution] Fix whitespace/newlines for exception comments\n(#208959)](https://github.com/elastic/kibana/pull/208959)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Marshall\nMain\",\"email\":\"55718608+marshallmain@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2025-02-10T23:17:49Z\",\"message\":\"[Security\nSolution] Fix whitespace/newlines for exception comments (#208959)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/208956\\r\\n\\r\\n##\nBefore\\r\\n\\r\\n![image](https://github.com/user-attachments/assets/aa9b00e9-da70-4ff2-be18-4073235e8a85)\\r\\n\\r\\n##\nAfter\\r\\n\\r\\n![image](https://github.com/user-attachments/assets/0fa2a69c-836d-4e98-8ecb-be88d1170519)\",\"sha\":\"1b8bdcff677773afa1ac42a1410ca58e0db49964\",\"branchLabelMapping\":{\"^v9.1.0$\":\"main\",\"^v8.19.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"backport:prev-minor\",\"Team:Detection\nEngine\",\"v9.1.0\"],\"title\":\"[Security Solution] Fix whitespace/newlines\nfor exception\ncomments\",\"number\":208959,\"url\":\"https://github.com/elastic/kibana/pull/208959\",\"mergeCommit\":{\"message\":\"[Security\nSolution] Fix whitespace/newlines for exception comments (#208959)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/208956\\r\\n\\r\\n##\nBefore\\r\\n\\r\\n![image](https://github.com/user-attachments/assets/aa9b00e9-da70-4ff2-be18-4073235e8a85)\\r\\n\\r\\n##\nAfter\\r\\n\\r\\n![image](https://github.com/user-attachments/assets/0fa2a69c-836d-4e98-8ecb-be88d1170519)\",\"sha\":\"1b8bdcff677773afa1ac42a1410ca58e0db49964\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.1.0\",\"branchLabelMappingKey\":\"^v9.1.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/208959\",\"number\":208959,\"mergeCommit\":{\"message\":\"[Security\nSolution] Fix whitespace/newlines for exception comments (#208959)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/208956\\r\\n\\r\\n##\nBefore\\r\\n\\r\\n![image](https://github.com/user-attachments/assets/aa9b00e9-da70-4ff2-be18-4073235e8a85)\\r\\n\\r\\n##\nAfter\\r\\n\\r\\n![image](https://github.com/user-attachments/assets/0fa2a69c-836d-4e98-8ecb-be88d1170519)\",\"sha\":\"1b8bdcff677773afa1ac42a1410ca58e0db49964\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/210567","number":210567,"state":"OPEN"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208959","number":208959,"mergeCommit":{"message":"[Security Solution] Fix whitespace/newlines for exception comments (#208959)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208956\r\n\r\n## Before\r\n\r\n![image](https://github.com/user-attachments/assets/aa9b00e9-da70-4ff2-be18-4073235e8a85)\r\n\r\n## After\r\n\r\n![image](https://github.com/user-attachments/assets/0fa2a69c-836d-4e98-8ecb-be88d1170519)","sha":"1b8bdcff677773afa1ac42a1410ca58e0db49964"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
marshallmain
added a commit
that referenced
this issue
Feb 11, 2025
…ents (#208959) (#210567) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Fix whitespace/newlines for exception comments (#208959)](#208959) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marshall Main","email":"55718608+marshallmain@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-10T23:17:49Z","message":"[Security Solution] Fix whitespace/newlines for exception comments (#208959)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208956\r\n\r\n## Before\r\n\r\n![image](https://github.com/user-attachments/assets/aa9b00e9-da70-4ff2-be18-4073235e8a85)\r\n\r\n## After\r\n\r\n![image](https://github.com/user-attachments/assets/0fa2a69c-836d-4e98-8ecb-be88d1170519)","sha":"1b8bdcff677773afa1ac42a1410ca58e0db49964","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:Detection Engine","v8.18.0","v9.1.0"],"title":"[Security Solution] Fix whitespace/newlines for exception comments","number":208959,"url":"https://github.com/elastic/kibana/pull/208959","mergeCommit":{"message":"[Security Solution] Fix whitespace/newlines for exception comments (#208959)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208956\r\n\r\n## Before\r\n\r\n![image](https://github.com/user-attachments/assets/aa9b00e9-da70-4ff2-be18-4073235e8a85)\r\n\r\n## After\r\n\r\n![image](https://github.com/user-attachments/assets/0fa2a69c-836d-4e98-8ecb-be88d1170519)","sha":"1b8bdcff677773afa1ac42a1410ca58e0db49964"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/210480","number":210480,"state":"MERGED","mergeCommit":{"sha":"b3c129502eff48d1b8292962391afe57c09626a5","message":"[9.0] [Security Solution] Fix whitespace/newlines for exception comments (#208959) (#210480)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Security Solution] Fix whitespace/newlines for exception comments\n(#208959)](https://github.com/elastic/kibana/pull/208959)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Marshall\nMain\",\"email\":\"55718608+marshallmain@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2025-02-10T23:17:49Z\",\"message\":\"[Security\nSolution] Fix whitespace/newlines for exception comments (#208959)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/208956\\r\\n\\r\\n##\nBefore\\r\\n\\r\\n![image](https://github.com/user-attachments/assets/aa9b00e9-da70-4ff2-be18-4073235e8a85)\\r\\n\\r\\n##\nAfter\\r\\n\\r\\n![image](https://github.com/user-attachments/assets/0fa2a69c-836d-4e98-8ecb-be88d1170519)\",\"sha\":\"1b8bdcff677773afa1ac42a1410ca58e0db49964\",\"branchLabelMapping\":{\"^v9.1.0$\":\"main\",\"^v8.19.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"backport:prev-minor\",\"Team:Detection\nEngine\",\"v9.1.0\"],\"title\":\"[Security Solution] Fix whitespace/newlines\nfor exception\ncomments\",\"number\":208959,\"url\":\"https://github.com/elastic/kibana/pull/208959\",\"mergeCommit\":{\"message\":\"[Security\nSolution] Fix whitespace/newlines for exception comments (#208959)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/208956\\r\\n\\r\\n##\nBefore\\r\\n\\r\\n![image](https://github.com/user-attachments/assets/aa9b00e9-da70-4ff2-be18-4073235e8a85)\\r\\n\\r\\n##\nAfter\\r\\n\\r\\n![image](https://github.com/user-attachments/assets/0fa2a69c-836d-4e98-8ecb-be88d1170519)\",\"sha\":\"1b8bdcff677773afa1ac42a1410ca58e0db49964\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.1.0\",\"branchLabelMappingKey\":\"^v9.1.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/208959\",\"number\":208959,\"mergeCommit\":{\"message\":\"[Security\nSolution] Fix whitespace/newlines for exception comments (#208959)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/208956\\r\\n\\r\\n##\nBefore\\r\\n\\r\\n![image](https://github.com/user-attachments/assets/aa9b00e9-da70-4ff2-be18-4073235e8a85)\\r\\n\\r\\n##\nAfter\\r\\n\\r\\n![image](https://github.com/user-attachments/assets/0fa2a69c-836d-4e98-8ecb-be88d1170519)\",\"sha\":\"1b8bdcff677773afa1ac42a1410ca58e0db49964\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208959","number":208959,"mergeCommit":{"message":"[Security Solution] Fix whitespace/newlines for exception comments (#208959)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208956\r\n\r\n## Before\r\n\r\n![image](https://github.com/user-attachments/assets/aa9b00e9-da70-4ff2-be18-4073235e8a85)\r\n\r\n## After\r\n\r\n![image](https://github.com/user-attachments/assets/0fa2a69c-836d-4e98-8ecb-be88d1170519)","sha":"1b8bdcff677773afa1ac42a1410ca58e0db49964"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Team:Detection Engine
Security Solution Detection Engine Area
Kibana version: 8.17+
Elasticsearch version: n/a
Describe the bug:
Exception item comments with new lines do not display the new lines in UI
Steps to reproduce:
Expected behavior:
The new line should display
Screenshots (if relevant):
Errors in browser console (if relevant):
Provide logs and/or server output (if relevant):
Any additional context:
The text was updated successfully, but these errors were encountered: