[Security Solution] Fix whitespace/newlines for exception comments #208959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshallmain
added
backport:prev-minor
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 9.0 https://github.com/elastic/kibana/actions/runs/13252385483 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 10, 2025
…lastic#208959) ## Summary Fixes elastic#208956 ## Before  ## After  (cherry picked from commit 1b8bdcf)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2025
…nts (#208959) (#210480) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Fix whitespace/newlines for exception comments (#208959)](#208959) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marshall Main","email":"55718608+marshallmain@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-10T23:17:49Z","message":"[Security Solution] Fix whitespace/newlines for exception comments (#208959)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208956\r\n\r\n## Before\r\n\r\n\r\n\r\n## After\r\n\r\n","sha":"1b8bdcff677773afa1ac42a1410ca58e0db49964","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","Team:Detection Engine","v9.1.0"],"title":"[Security Solution] Fix whitespace/newlines for exception comments","number":208959,"url":"https://github.com/elastic/kibana/pull/208959","mergeCommit":{"message":"[Security Solution] Fix whitespace/newlines for exception comments (#208959)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208956\r\n\r\n## Before\r\n\r\n\r\n\r\n## After\r\n\r\n","sha":"1b8bdcff677773afa1ac42a1410ca58e0db49964"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208959","number":208959,"mergeCommit":{"message":"[Security Solution] Fix whitespace/newlines for exception comments (#208959)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208956\r\n\r\n## Before\r\n\r\n\r\n\r\n## After\r\n\r\n","sha":"1b8bdcff677773afa1ac42a1410ca58e0db49964"}}]}] BACKPORT--> Co-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
marshallmain
added a commit
to marshallmain/kibana
that referenced
this pull request
Feb 11, 2025
…lastic#208959) ## Summary Fixes elastic#208956 ## Before  ## After  (cherry picked from commit 1b8bdcf)
marshallmain
added a commit
to marshallmain/kibana
that referenced
this pull request
Feb 11, 2025
…lastic#208959) ## Summary Fixes elastic#208956 ## Before  ## After  (cherry picked from commit 1b8bdcf)
marshallmain
added a commit
that referenced
this pull request
Feb 11, 2025
…nts (#208959) (#210568) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Fix whitespace/newlines for exception comments (#208959)](#208959) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marshall Main","email":"55718608+marshallmain@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-10T23:17:49Z","message":"[Security Solution] Fix whitespace/newlines for exception comments (#208959)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208956\r\n\r\n## Before\r\n\r\n\r\n\r\n## After\r\n\r\n","sha":"1b8bdcff677773afa1ac42a1410ca58e0db49964","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:Detection Engine","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Fix whitespace/newlines for exception comments","number":208959,"url":"https://github.com/elastic/kibana/pull/208959","mergeCommit":{"message":"[Security Solution] Fix whitespace/newlines for exception comments (#208959)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208956\r\n\r\n## Before\r\n\r\n\r\n\r\n## After\r\n\r\n","sha":"1b8bdcff677773afa1ac42a1410ca58e0db49964"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/210480","number":210480,"state":"MERGED","mergeCommit":{"sha":"b3c129502eff48d1b8292962391afe57c09626a5","message":"[9.0] [Security Solution] Fix whitespace/newlines for exception comments (#208959) (#210480)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Security Solution] Fix whitespace/newlines for exception comments\n(#208959)](https://github.com/elastic/kibana/pull/208959)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Marshall\nMain\",\"email\":\"55718608+marshallmain@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2025-02-10T23:17:49Z\",\"message\":\"[Security\nSolution] Fix whitespace/newlines for exception comments (#208959)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/208956\\r\\n\\r\\n##\nBefore\\r\\n\\r\\n\\r\\n\\r\\n##\nAfter\\r\\n\\r\\n\",\"sha\":\"1b8bdcff677773afa1ac42a1410ca58e0db49964\",\"branchLabelMapping\":{\"^v9.1.0$\":\"main\",\"^v8.19.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"backport:prev-minor\",\"Team:Detection\nEngine\",\"v9.1.0\"],\"title\":\"[Security Solution] Fix whitespace/newlines\nfor exception\ncomments\",\"number\":208959,\"url\":\"https://github.com/elastic/kibana/pull/208959\",\"mergeCommit\":{\"message\":\"[Security\nSolution] Fix whitespace/newlines for exception comments (#208959)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/208956\\r\\n\\r\\n##\nBefore\\r\\n\\r\\n\\r\\n\\r\\n##\nAfter\\r\\n\\r\\n\",\"sha\":\"1b8bdcff677773afa1ac42a1410ca58e0db49964\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.1.0\",\"branchLabelMappingKey\":\"^v9.1.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/208959\",\"number\":208959,\"mergeCommit\":{\"message\":\"[Security\nSolution] Fix whitespace/newlines for exception comments (#208959)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/208956\\r\\n\\r\\n##\nBefore\\r\\n\\r\\n\\r\\n\\r\\n##\nAfter\\r\\n\\r\\n\",\"sha\":\"1b8bdcff677773afa1ac42a1410ca58e0db49964\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/210567","number":210567,"state":"OPEN"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208959","number":208959,"mergeCommit":{"message":"[Security Solution] Fix whitespace/newlines for exception comments (#208959)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208956\r\n\r\n## Before\r\n\r\n\r\n\r\n## After\r\n\r\n","sha":"1b8bdcff677773afa1ac42a1410ca58e0db49964"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
marshallmain
added a commit
that referenced
this pull request
Feb 11, 2025
…ents (#208959) (#210567) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Fix whitespace/newlines for exception comments (#208959)](#208959) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Marshall Main","email":"55718608+marshallmain@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-10T23:17:49Z","message":"[Security Solution] Fix whitespace/newlines for exception comments (#208959)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208956\r\n\r\n## Before\r\n\r\n\r\n\r\n## After\r\n\r\n","sha":"1b8bdcff677773afa1ac42a1410ca58e0db49964","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:Detection Engine","v8.18.0","v9.1.0"],"title":"[Security Solution] Fix whitespace/newlines for exception comments","number":208959,"url":"https://github.com/elastic/kibana/pull/208959","mergeCommit":{"message":"[Security Solution] Fix whitespace/newlines for exception comments (#208959)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208956\r\n\r\n## Before\r\n\r\n\r\n\r\n## After\r\n\r\n","sha":"1b8bdcff677773afa1ac42a1410ca58e0db49964"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/210480","number":210480,"state":"MERGED","mergeCommit":{"sha":"b3c129502eff48d1b8292962391afe57c09626a5","message":"[9.0] [Security Solution] Fix whitespace/newlines for exception comments (#208959) (#210480)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.0`:\n- [[Security Solution] Fix whitespace/newlines for exception comments\n(#208959)](https://github.com/elastic/kibana/pull/208959)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Marshall\nMain\",\"email\":\"55718608+marshallmain@users.noreply.github.com\"},\"sourceCommit\":{\"committedDate\":\"2025-02-10T23:17:49Z\",\"message\":\"[Security\nSolution] Fix whitespace/newlines for exception comments (#208959)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/208956\\r\\n\\r\\n##\nBefore\\r\\n\\r\\n\\r\\n\\r\\n##\nAfter\\r\\n\\r\\n\",\"sha\":\"1b8bdcff677773afa1ac42a1410ca58e0db49964\",\"branchLabelMapping\":{\"^v9.1.0$\":\"main\",\"^v8.19.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"backport:prev-minor\",\"Team:Detection\nEngine\",\"v9.1.0\"],\"title\":\"[Security Solution] Fix whitespace/newlines\nfor exception\ncomments\",\"number\":208959,\"url\":\"https://github.com/elastic/kibana/pull/208959\",\"mergeCommit\":{\"message\":\"[Security\nSolution] Fix whitespace/newlines for exception comments (#208959)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/208956\\r\\n\\r\\n##\nBefore\\r\\n\\r\\n\\r\\n\\r\\n##\nAfter\\r\\n\\r\\n\",\"sha\":\"1b8bdcff677773afa1ac42a1410ca58e0db49964\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.1.0\",\"branchLabelMappingKey\":\"^v9.1.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/208959\",\"number\":208959,\"mergeCommit\":{\"message\":\"[Security\nSolution] Fix whitespace/newlines for exception comments (#208959)\\n\\n##\nSummary\\r\\n\\r\\nFixes\nhttps://github.com//issues/208956\\r\\n\\r\\n##\nBefore\\r\\n\\r\\n\\r\\n\\r\\n##\nAfter\\r\\n\\r\\n\",\"sha\":\"1b8bdcff677773afa1ac42a1410ca58e0db49964\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Marshall Main <55718608+marshallmain@users.noreply.github.com>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208959","number":208959,"mergeCommit":{"message":"[Security Solution] Fix whitespace/newlines for exception comments (#208959)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/208956\r\n\r\n## Before\r\n\r\n\r\n\r\n## After\r\n\r\n","sha":"1b8bdcff677773afa1ac42a1410ca58e0db49964"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #208956
Before
After