Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Migrate Anomaly Explorer Charts to React #22626

Closed
10 tasks done
walterra opened this issue Sep 3, 2018 · 1 comment
Closed
10 tasks done

[ML] Migrate Anomaly Explorer Charts to React #22626

walterra opened this issue Sep 3, 2018 · 1 comment
Assignees
@walterra
Labels
Feature:Anomaly Detection ML anomaly detection Meta :ml refactoring v6.7.0

Comments

@walterra
Copy link
Contributor

walterra commented Sep 3, 2018 •
edited
Loading

Initial Migration

Further cleanup, refactoring of legacy code

Add more tests

  • explore_series
  • explorer_chart_config_builder
  • explorer_chart_tooltip
  • explorer_charts_container_services
  • explorer_charts_container

Bugs

Part of #18374.
@walterra walterra self-assigned this Sep 3, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@walterra walterra mentioned this issue Sep 3, 2018
Merged
@walterra walterra added the Meta label Sep 4, 2018
@walterra walterra mentioned this issue Sep 6, 2018
Merged
walterra added a commit that referenced this issue Sep 7, 2018
@walterra
[ML] Anomaly Explorer Charts jest tests. (#22759)
76408be 
After the migration to React in #22622, this PR adds more test coverage based on jest to the Anomaly Explorer charts. This is done as preparation for some further refactoring (#22626) and the integration of the support for charts for the rare detector (#21163). The tests use mock data based on a standard multi-metric job using the farequote dataset.
Besided the tests this PR includes the following changes:
- In explore_series.js the path is no longer a concatenanted string but now using a template literal
- The exploreSeries() function is no longer calling window.open by itself, it just returns the link
because of the above, renamed exploreSeries() to getExploreSeriesLink() and moved it to chart_utils.js
- explorer_charts_container_service.js is no longer requiring jQuery itself, it now receiving the required element as a factory argument. Further work on this is planned to get rid of jQuery.
walterra added a commit to walterra/kibana that referenced this issue Sep 7, 2018
@walterra
[ML] Anomaly Explorer Charts jest tests. (elastic#22759)
929e0d9 
After the migration to React in elastic#22622, this PR adds more test coverage based on jest to the Anomaly Explorer charts. This is done as preparation for some further refactoring (elastic#22626) and the integration of the support for charts for the rare detector (elastic#21163). The tests use mock data based on a standard multi-metric job using the farequote dataset.
Besided the tests this PR includes the following changes:
- In explore_series.js the path is no longer a concatenanted string but now using a template literal
- The exploreSeries() function is no longer calling window.open by itself, it just returns the link
because of the above, renamed exploreSeries() to getExploreSeriesLink() and moved it to chart_utils.js
- explorer_charts_container_service.js is no longer requiring jQuery itself, it now receiving the required element as a factory argument. Further work on this is planned to get rid of jQuery.
walterra added a commit that referenced this issue Sep 7, 2018
@walterra
[ML] Anomaly Explorer Charts jest tests. (#22759) (#22796)
e571490 
After the migration to React in #22622, this PR adds more test coverage based on jest to the Anomaly Explorer charts. This is done as preparation for some further refactoring (#22626) and the integration of the support for charts for the rare detector (#21163). The tests use mock data based on a standard multi-metric job using the farequote dataset.
Besided the tests this PR includes the following changes:
- In explore_series.js the path is no longer a concatenanted string but now using a template literal
- The exploreSeries() function is no longer calling window.open by itself, it just returns the link
because of the above, renamed exploreSeries() to getExploreSeriesLink() and moved it to chart_utils.js
- explorer_charts_container_service.js is no longer requiring jQuery itself, it now receiving the required element as a factory argument. Further work on this is planned to get rid of jQuery.
This was referenced Sep 24, 2018
Merged
Merged
Merged
@walterra walterra mentioned this issue Jan 24, 2019
Open
42 tasks
@sophiec20 sophiec20 added Feature:Anomaly Detection ML anomaly detection and removed Feature:ml-results legacy - do not use labels Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@walterra walterra

Labels
Feature:Anomaly Detection ML anomaly detection Meta :ml refactoring v6.7.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@walterra @sophiec20 @peteharverson @elasticmachine