Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Migrate Angular-based components to React #18374

Closed
88 tasks done
elasticmachine opened this issue Mar 29, 2018 · 0 comments
Closed
88 tasks done

[ML] Migrate Angular-based components to React #18374

elasticmachine opened this issue Mar 29, 2018 · 0 comments

Comments

@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 29, 2018

Original comment by @peteharverson:

Meta issue itemizing the list of components in the ML UI which need to be migrated from Angular directives and templates to React.

Components

Controls

Tooltips

Angular filters

Replace with regular JavaScript functions

Jobs List

  • Main table

Jobs List Components

  • Custom URL Editor
  • Create Watch modal
  • Delete Job modal
  • Edit Job modal
  • Job Time Picker modal
  • Expanded row
  • Expanded row - General tab
  • Expanded row - Config tab
  • Expanded row - Counts tab
  • Expanded row - Datafeed tab

Create Job

Wizard

  • Select index or search
  • Select job type

Simple job components

Single Metric

  • Main create job page
  • Anomaly chart

Multi Metric

  • Main create job page
  • Anomaly chart

Population

  • Main create job page
  • Anomaly chart

Recognizer

  • Main create job page

Advanced

  • Main job page
  • Add detector modal
  • Detector filter modal
  • Save status modal

Data Visualizer

  • Main page
  • Side bar

Anomaly Explorer

Single Metric Viewer

Chart Tooltips

  • mlChartTooltipService no longer depends on angularjs and jQuery
  • mlChartTooltip angularjs directive was replaced by a ChartTooltip react component based on the styling and API of EUI Charts tooltips.

Settings

Scheduled Events #26741

  • Events list
  • Import events modal
  • New event modal
  • Calendars list
  • Create calendar page

No need to migrate

The following list of components should not need migrating as components with this functionality already exist in EUI:

  • Confirm modal - use EuiConfirmModal
  • Item select - use EuiComboBox
  • Loading indicator - use EuiLoadingSpinner or EuiProgress
  • Paginated Table - use EuiBasicTable or EuiInMemoryTable
@sophiec20 sophiec20 removed Feature:ml-results legacy - do not use labels Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants