[ML] Migrate bucket span estimator button to EUI/React. #19045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
review
v7.0.0
v6.4.0
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
peteharverson
approved these changes
May 15, 2018
| return ( | ||
| <div className="bucket-span-estimator"> | ||
| <EuiToolTip | ||
| content="Experimental feature for estimating bucket span." |
There was a problem hiding this comment.
I wonder if this warning about it being an experimental feature is still needed?
There was a problem hiding this comment.
We are adding in k-api tests shortly. I'm not sure how far we'll get in terms of depth of coverage in this release, so let's keep as experimental till we have a stronger set of data scenario tests.
walterra
force-pushed
the
ml-eui-tooltips-2
branch
from
fd3762a to
ea5e2c5
Compare
💚 Build Succeeded |
| // watch for these changes | ||
| $scope.$watch('formConfig.agg.type', updateButton, true); | ||
| $scope.$watch('jobStateWrapper.jobState', updateButton, true); | ||
| $scope.$watch('JOB_STATE', updateButton, true); |
There was a problem hiding this comment.
JOB_STATE is a constant and so doesn't need to be watched.
💔 Build Failed |
|
jenkins test this |
💔 Build Failed |
|
jenkins test this |
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
May 17, 2018
This migrates the bucket span estimator button to use React/EUI. The existing mlBucketSpanEstimator is refactored to use React without ngReact to have more detailed control in regards to the $scope being transformed to a trimmed down props object with only the information necessary for the React component. This also allows more control in regards to the $scope attributes being watched. Instead of custom styles and classes this now uses the options available for EuiButton. However, there were some minimal overrides necessary to the EUI styles to replicate the narrower height and padding to fit within the input element.
88 tasks
walterra
added a commit
that referenced
this pull request
May 17, 2018
) This migrates the bucket span estimator button to use React/EUI. The existing mlBucketSpanEstimator is refactored to use React without ngReact to have more detailed control in regards to the $scope being transformed to a trimmed down props object with only the information necessary for the React component. This also allows more control in regards to the $scope attributes being watched. Instead of custom styles and classes this now uses the options available for EuiButton. However, there were some minimal overrides necessary to the EUI styles to replicate the narrower height and padding to fit within the input element.
walterra
changed the title
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the bucket span estimator button to use React/EUI.
The existing
mlBucketSpanEstimatoris refactored to use React withoutngReactto have more detailed control in regards to the$scopebeing transformed to a trimmed downpropsobject with only the information necessary for the React component. This also allows more control in regards to the$scopeattributes being watched. Instead of custom styles and classes this now uses the options available forEuiButton. However, there were some minimal overrides necessary to the EUI styles to replicate the narrower height and padding to fit within the input element.Part of #18374.