Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Migrate mlDocumentationHelpLink to EUI/React. #19124

Merged
merged 1 commit into from
May 16, 2018

Conversation

walterra
Copy link
Contributor

@walterra walterra commented May 16, 2018

Migrates the mlDocumentationHelpLink directive to use EUI/React.

  • Removes the tooltip
  • Replaces the fa-external-link icon with EUI's popout

Previous version

Updated version

Part of #18374.

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@walterra walterra merged commit b620978 into elastic:master May 16, 2018
@walterra walterra deleted the ml-eui-documentation-links branch May 16, 2018 15:55
walterra added a commit to walterra/kibana that referenced this pull request May 16, 2018
@walterra walterra changed the title [ML] Migrate mlDocumentationHelpLink to React. [ML] Migrate mlDocumentationHelpLink to EUI/React. May 17, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants