[ML] Converts full time range selector control to EUI / React #35074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
release_note:enhancement
review
:ml
Feature:Anomaly Detection
peteharverson
requested review from
walterra,
alvarezmelissa87 and
jgowdyelastic
|
Pinging @elastic/ml-ui |
88 tasks
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
peteharverson
force-pushed
the
ml-full-time-range-selector-eui
branch
from
573d2a3
to
1178f2f
Compare
walterra
approved these changes
Apr 16, 2019
| import { ml } from '../../services/ml_api_service'; | ||
|
|
||
| export function setFullTimeRange(indexPattern: IndexPattern, query: Query) { | ||
| return ml |
There was a problem hiding this comment.
Do we need the return here?
There was a problem hiding this comment.
No the return isn't needed. I'll remove it.
There was a problem hiding this comment.
The return was added in the original version so the promise chain could be used to trigger an update after the time range had been loaded.
I think this is a useful feature and is being currently being used by the new job wizards.
There was a problem hiding this comment.
Well spotted @jgowdyelastic . The return is needed when prepopulating the job wizard settings when cloning a job that was created in the wizards. I have added it back in.
💚 Build Succeeded |
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Apr 16, 2019
…c#35074) * [ML] Converts full time range selector control to EUI / React * [ML] Remove console log from time range selector service * [ML] Fix linting errors in full time range selector ts files * [ML] Switch to using I18nContext in wrapping directive * [ML] Remove unnecessary return from setFullTimeRange * [ML] Add setFullTimeRange return back in for clone job settings
peteharverson
added a commit
that referenced
this pull request
Apr 16, 2019
#35147) * [ML] Converts full time range selector control to EUI / React * [ML] Remove console log from time range selector service * [ML] Fix linting errors in full time range selector ts files * [ML] Switch to using I18nContext in wrapping directive * [ML] Remove unnecessary return from setFullTimeRange * [ML] Add setFullTimeRange return back in for clone job settings
walterra
pushed a commit
to walterra/kibana
that referenced
this pull request
Apr 23, 2019
…c#35074) * [ML] Converts full time range selector control to EUI / React * [ML] Remove console log from time range selector service * [ML] Fix linting errors in full time range selector ts files * [ML] Switch to using I18nContext in wrapping directive * [ML] Remove unnecessary return from setFullTimeRange * [ML] Add setFullTimeRange return back in for clone job settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts the control for automatically setting the time filter to the full time range of the job to EUI / React.
Checklist
For maintainers