-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Support EUI darkmode #29725
Comments
Pinging @elastic/apm-ui |
I like how infra has done this using React context (#29133). If we want to imitate, we need to:
@sqren @ogupte @formgeist if you all are ok with this strategy, I'll update the ticket. Once this is done, fixing the remaining dark mode issues should become much easier. |
@jasonrhodes Sounds good to me 👍 |
I also like how Infra solved it. @jasonrhodes did you think of a way to access theme variables outside
|
Succeeded by #30048 |
Switch between lightmode and darkmode depending on
chrome.getUiSettingsClient().get('k7design')
To import dark mode:
Infra solution:
kibana/x-pack/legacy/plugins/infra/public/apps/start_app.tsx
Lines 53 to 57 in d8a5765
Notes:
The text was updated successfully, but these errors were encountered: