Adding support for Dark Mode #29133
Merged
Adding support for Dark Mode #29133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
review
v7.0.0
[zube]: In Review
Feature:Metrics UI
|
Pinging @elastic/infrastructure-ui |
simianhacker
commented
Jan 22, 2019
| this.darkMode = config.get('theme:darkMode'); | ||
| } catch (e) { | ||
| this.darkMode = false; | ||
| } |
There was a problem hiding this comment.
This can be removed once the global dark theme PR is merged. For now, it's necessary to work with master.
There was a problem hiding this comment.
FYI, you can always specify a default as the second argument
There was a problem hiding this comment.
Oh... nice! I didn't know that would suppress the exception when the key doesn't exist.
💔 Build Failed |
|
retest |
💚 Build Succeeded |
💚 Build Succeeded |
alvarolobato
added
the
Team:Infra Monitoring UI - DEPRECATED
|
I took the liberty of pushing a small change to the autocomplete suggestion icon background color, hope you don't mind:
|
|
@weltenwort Not at all... anything to move the product forward. |
💚 Build Succeeded |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Jan 29, 2019
* Adding support for Dark Mode * Use transparentize for suggestion icon bg color
simianhacker
added a commit
that referenced
this pull request
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the required changes to support the Global Dark Mode theme that will be introduced via #28445. For the logging UI I had to use the
props.theme.darkModeswitch to pick an appropriate color for both the log line hover along with the visible colors for the minimap. The previous colors changed correctly but were not visible.Reviewers: As far as testing goes you will need to wait till #28445 is merged before you can successfully test the different themes.