[APM] One-line trace summary #44842

smith · 2019-09-05T01:53:25Z

Summary

Replace the StickyTransactionProperties with a trace summary that puts everything on one line.

Fixes #43247.

Some example screenshots

An HTTP request with an error:

An HTTP request with no errors:

A non-HTTP request with no result:

A non-HTTP request with an error an a result:

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-09-05T03:25:39Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

dgieselaar · 2019-09-05T08:03:05Z

Really like how this looks in general 👍

Some things that caught my eye (will review code later):

The timestamp and duration labels are relatively long, and because they're the same size/color it makes it a bit hard to scan for me. Maybe we can do something here with shorter labels or displaying some of the text in a slightly lighter shade.

The summary relatively quickly starts wrapping. Maybe another reason to make the labels a little more compact, either by truncating, styling, or simply displaying less (detailed) information.

sorenlouv · 2019-09-05T08:31:23Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+            <ErrorCountBadge
+              errorCount={errorCount}
+              includeText={true}
+              title={undefined}


Why title={undefined}? Can't that be dropped?

(Same with other occurrences of title={undefined})

An EuiBadge by default apparently sets the title attribute of the element to the contents of the element, so if you hover over "1 Error" you get a title tooltip that says "1 Error". This also occurs when an EuiToolTip is present, so you get a weird double-tooltip.

sorenlouv · 2019-09-05T08:46:55Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+// TODO: Light/Dark theme (@see https://github.com/elastic/kibana/issues/44840)
+const theme = euiLightVars;
+
+const Heading: React.FunctionComponent = () => (


I've never understood the appeal of these annotations (but I'm definitely in the minority here :D). If we are going to use them what do you think about the shorthand:

const Heading: React.FC = () => (

or perhaps even:

import React, { FC } from 'react'; // ... const Heading: FC = () => (

?

I'm fine with using FC. The annotations are helpful because a function component is not just a regular function. If you use these annotations you get autocomplete for react-specific properties:

I like it because it's more explicit and gives the user and the type checker more context.

Yeah, I can see that. However, I barely think you can find any usages of those props anywhere. I recall displayName was needed for HOC (replaced by hooks),defaultProps is replaced with es6 default parameters and propTypes is replaced with Typescript.
I can't remember how contextTypes - we don't use it even though we use context a lot.

So to me it is a solution to a problem I don't have :)

For me it's less about the autocomplete and more about explicitly stating, "this is what this thing is."

Makes sense. I find great value in Typescript's explicitness . It's like code comments that are guaranteed to be up to date.

FWIW, @sqren previously argued that FC implicitly types children which I think is a good reason to avoid it.

sorenlouv · 2019-09-05T09:01:45Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+import { ErrorCountBadge } from './ErrorCountBadge';
+import { truncate } from '../../../../style/variables';
+
+// TODO: Light/Dark theme (@see https://github.com/elastic/kibana/issues/44840)


As mentioned in the issue we also have this one #29725

sorenlouv · 2019-09-05T09:02:08Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+import { NOT_AVAILABLE_LABEL } from '../../../../../common/i18n';
+import { isRumAgentName } from '../../../../../common/agent_name';
+import { ErrorCountBadge } from './ErrorCountBadge';
+import { truncate } from '../../../../style/variables';


sorenlouv · 2019-09-05T09:04:26Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+const Separator: React.FunctionComponent = () => (
+  <>
+    {' '}
+    <SeparatorText aria-hidden={true}>|</SeparatorText>{' '}


Instead of using whitespace {' '} for styling, you should add padding to the styled component.

You could perhaps also opt for border-right: 1px solid ${euiColorMediumShade}, and have a TraceSummaryBlock component or something like that. Not sure if that would be better though.

sorenlouv · 2019-09-05T09:05:38Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+            }
+          )}
+        >
+          <>({percentOfTraceText})</>


Is the fragment needed?

Suggested change

<>({percentOfTraceText})</>

({percentOfTraceText})

Oh - is it because it's required by EuiToolTip? Then it makes sense (although EuiToolTip should just accept strings in the first place)

Opened elastic/eui#2292 to track this.

sorenlouv · 2019-09-05T09:15:34Z

This is how it looks for me:

A couple of adjustments:

URL shouldn't be truncated so aggressively
The http containers should be vertically aligned with the text (duration and timestamp)
In addition to status code we should also show status text, eg "200 Success"

sorenlouv · 2019-09-05T09:43:53Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+    color = theme.euiColorVis7;
+  } else if (status >= 500) {
+    color = theme.euiColorVis2;
+  }


Perhaps extract this to a separate method const color = getStatusCodeColor(status)

sorenlouv · 2019-09-05T09:44:53Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+    return null;
+  } else if (status < 300) {
+    color = theme.euiColorVis0;
+  } else if (status >= 300 || status < 400) {


Shouldn't this be && instead of ||? afaict anything above 300 will always return euiColorVis5

sorenlouv · 2019-09-05T11:05:53Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+            }
+          )}
+        >
+          <MethodText>{method}</MethodText>


Perhaps simply use <strong>{method}</strong> ?

Or maybe that's abuse to use semantic tags for styling. I'm okay with either

Using an explicit styled component is probably safer and more "semantic", but I'll just use strong because it's less code.

sorenlouv · 2019-09-05T11:13:07Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+  const isRumAgent = isRumAgentName(transaction.agent.name);
+  const url = isRumAgent
+    ? idx(transaction, _ => _.transaction.page.url) || NOT_AVAILABLE_LABEL
+    : idx(transaction, _ => _.url.full) || NOT_AVAILABLE_LABEL;


I'm not 100% but I don't think a RUM transaction will ever have http. We have to double check with @vigneshshanmugam or @jahtalab .

If that's the case we should remove the transaction.page.url from HttpInfo (since it will never be rendered) and instead render the RUM url as a separate use case aka:

if (isHttp) ( <HttpInfo /> } else if (result) { <TransactionResult /> } else if (isRumAgent()) { <RumAgentUrl /> }

As @sqren mentioned, We don't have transaction.http field at the moment for RUM agent.

Thank @vigneshshanmugam. Do you plan to add it in the near-ish future?

I changed this to remove the check for http which really wasn't necessary in the first place.

Atleast for spans, we have the http info, But cant for transaction everything is grouped under page, request and response so wont be added in the nearish future.

smith · 2019-09-05T19:37:21Z

This is how it looks for me:

@sqren do you have an example of a trace where it looked like that for you or was it all of them? Does not look like that for me.

dgieselaar

Great work Nathan!

dgieselaar · 2019-09-05T19:34:14Z

...ugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/ErrorCountBadge.tsx

-export const ErrorCountBadge = ({ errorCount = 0, ...rest }: Props) => (
+export const ErrorCountBadge = ({
+  errorCount = 0,
+  includeText = false,


instead of includeText, maybe this component should just support children? Also this label is pretty similar to xpack.apm.transactionDetails.errorsOverviewLink, which we use in StickyTransactionProperties.

dgieselaar · 2019-09-05T19:34:31Z

...ins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.test.tsx

+            transaction={transaction}
+          />
+        )
+      ).not.toThrowError();


how useful is this test?

It asserts that the thing actually can render given those props. I usually use a test like this as a starting point and then use Jest coverage mapping or just TDD to fill in all the use cases.

So, it's not that useful but more useful than having nothing.

dgieselaar · 2019-09-05T19:36:12Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+// TODO: Light/Dark theme (@see https://github.com/elastic/kibana/issues/44840)
+const theme = euiLightVars;
+
+const Heading: React.FunctionComponent = () => (


FWIW, @sqren previously argued that FC implicitly types children which I think is a good reason to avoid it.

dgieselaar · 2019-09-05T19:40:35Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+  );
+
+  return (
+    <Item>


EUIToolTip supports the className prop, so you might be able to use that with styled-components:

const ToolTipWithoutWhitespace = styled(EUIToolTip)` white-space: nowrap; `;

(iirc)

dgieselaar · 2019-09-05T19:43:54Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+const Separator: React.FunctionComponent = () => (
+  <>
+    {' '}
+    <SeparatorText aria-hidden={true}>|</SeparatorText>{' '}


You could perhaps also opt for border-right: 1px solid ${euiColorMediumShade}, and have a TraceSummaryBlock component or something like that. Not sure if that would be better though.

dgieselaar · 2019-09-05T19:46:18Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

@@ -0,0 +1,255 @@
+/*


Might be useful to split this file up? e.g. TraceSummary/{index,Duration,HttpStatusBadge}.tsx

dgieselaar · 2019-09-05T19:49:48Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+}) => {
+  let color = 'default';
+
+  if (!status) {


maybe this looks better as:

const colors = { 2: theme.euiColorVis0, 3: theme.euiColorVis5, 4: theme.euiColorVis7, 5: theme.euiColorVis2 }; const resultGroup = status ? status.substr(0) : null; const color = colors[resultGroup] || null;

dgieselaar · 2019-09-05T19:50:33Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+};
+
+const HttpInfoBadge = styled(EuiBadge)`
+  max-width: 250px;


I think we should use units here to make elements align better. Those units are located in x-pack/legacy/plugins/apm/public/style/variables.ts.

dgieselaar · 2019-09-05T19:54:18Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+          )}
+        >
+          <MethodText>{method}</MethodText>
+        </EuiToolTip>{' '}


it might make sense to use EUIFlexGrid and EUIFlexItem here, instead of using spaces (or even padding. There's some additional benefits we get, responsiveness for instance (well, sort of).

dgieselaar · 2019-09-05T20:09:45Z

.../plugins/apm/public/components/app/TransactionDetails/WaterfallWithSummmary/TraceSummary.tsx

+          duration={transaction.transaction.duration.us}
+          totalDuration={totalDuration}
+        />
+        {(isHttp || result) && <Separator />}


I think this can be improved a little. The conditions and different branches make it a little hard to follow for me. What do you think of:

const items = [ <Timestamp transactionTimestamp={transaction['@timestamp']} />, <Duration duration={transaction.transaction.duration.us} totalDuration={totalDuration} /> ]; if (isHttp) { items.push(<HttpInfo transaction={transaction} />); } else if (result) { items.push(<Result result={result} />); } if (errorCount > 0) { items.push( <ErrorCountBadge errorCount={errorCount} includeText={true} title={undefined} /> ); }

and then:

{items.reduce( (acc, item, index) => { const next = acc.concat(item); if (index !== items.length - 1) { next.push(<Separator />); } return next; }, [] as React.ReactElement[] )}

I think this would improve further if you use a EUIFlexItem with padding/border-right too.

I find that much harder to follow, but I'll try to make what I have there easier to follow.

smith · 2019-09-05T21:13:22Z

@dgieselaar @sqren these things seem to be in conflict:

The timestamp and duration labels are relatively long...

The summary relatively quickly starts wrapping...

and

URL shouldn't be truncated so aggressively

In addition to status code we should also show status text, eg "200 Success"

@katrin-freihofner would you mind taking a look to see if there's changes we can make to present more information and prevent it from wrapping so much?

sorenlouv · 2019-09-05T21:22:28Z

@dgieselaar @sqren these things seem to be in conflict:

hehe, true :) I think there is a bit of truth to both though. We talked about using the short month format. That'll help a bit.
And then I suggest we move the line down below the "Action" and "View full trace" buttons, so it can take the full width if needed (relevant on my 13").

If we do that I think it'll be possible to show both more of the url and have the status text without it wrapping.

sorenlouv · 2019-09-05T21:31:27Z

Regarding the status code colors: I don't think we should stick to the EUI colors. Normally I'm totally for following a color scheme but in this case it just looks really off (imo). I previously mentioned the colors Google Chrome (and many others) use:

Green for 2xx

Yellow for 3xx

Red for 4xx and 5xx

I thought we agreed on them but maybe not. @katrin-freihofner ?

EDIT: Okay, maybe we should stick to the EUI color palette but at least still use green-ish for 2xx, yellow-ish for 3xx and red for 4xx and 5xx.

katrin-freihofner · 2019-09-06T09:10:08Z

Eui provides nice colors for indicating status: https://elastic.github.io/eui/#/utilities/color-palettes
I would stick to these: euiPaletteForStatus ...there is a red, green and yellow.

sorenlouv · 2019-09-06T09:36:40Z

Eui provides nice colors for indicating status

Yay! Those colors are much better! Thanks for pointing that out.

katrin-freihofner · 2019-09-06T09:39:32Z

@smith good work! I have two questions:

Should the errors be clickable? They are in the current version, linking to the errors page.
Can we add aria attributes to state the labels? Currently, the screen reader reads the values but without the labels (as they are only available in the tooltips.)

sorenlouv · 2019-09-06T11:44:21Z

@katrin-freihofner

Should the errors be clickable? They are in the current version, linking to the errors page.

Since #42357 the errors badge in the header is no longer clickable. So I think it is fine as-is.
The reason is there can be more than one error. In that case we don't have a single page to link to. The user will still be able to click the error in the waterfall

smith · 2019-09-06T15:53:55Z

@dgieselaar

FWIW, @sqren previously argued that FC implicitly types children which I think is a good reason to avoid it.

I'm ok with that. Do we have any kind of team-specific style guide or do we suggest changes to the kibana JS style guide for decisions like this?

smith · 2019-09-06T19:42:07Z

In addition to status code we should also show status text, eg "200 Success"

@sqren not sure if we have this in the transaction data. http.response has status_code but not status_text. Should I be looking somewhere else?

sorenlouv · 2019-09-06T20:12:49Z

@sqren not sure if we have this in the transaction data. http.response has status_code but not status_text. Should I be looking somewhere else?

No, we only have the status code. There are probably lots of libraries that can do this but keeping out own list is probably simpler. Porting it from this php gists should do the trick: https://gist.github.com/henriquemoody/6580488

smith · 2019-09-06T20:48:22Z

No, we only have the status code. There are probably lots of libraries that can do this but keeping out own list is probably simpler. Porting it from this php gists should do the trick: gist.github.com/henriquemoody/6580488

https://github.com/prettymuchbryce/http-status-codes seems to be exactly what we want and it has no other dependencies. It's MIT licensed. Would it be better just to copy the code in or add as a dependency in x-pack?

Replace the `StickyTransactionProperties` with a trace summary that puts everything on one line. Fixes elastic#43247.

Replace the `StickyTransactionProperties` with a trace summary that puts everything on one line. Fixes #43247.

sorenlouv · 2019-09-10T09:15:00Z

This looks great. Good job @smith !

I'm surprised why the status code/text is black on red (whereas the error is white on red):

I think the contrast would be better with white:

I think EUI does some contrast calculation and determines the color, so not something we should have to override. Just wondering why it decided for black instead of white.

Any idea about this, @cchaos ? (we use EUIBadge btw)

cchaos · 2019-09-10T13:46:06Z

Technically the calculations are correct. Black text on that color has better contrast and passes WCAG levels.

Where white does not

If you're concerned by those colors, consider just sticking to our danger color instead of a custom value.

…-to-np-ready * 'master' of github.com:elastic/kibana: (138 commits) [Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript (elastic#44943) update close/delete system index modals (elastic#45037) TS return type of createIndexPatternSelect (elastic#45107) [ML] Fix focus chart updating. (elastic#45146) [ML] Data frame transform: Fix progress in wizard create step. (elastic#45116) [Graph] Re-enable functional test (elastic#44683) [SIEM] unique table id for each top talkers table (elastic#45014) [SIEM] ip details heading draggable (elastic#45179) [Maps][File upload] Set complete on index pattern creation (elastic#44423) [Maps] unmount map embeddable component on destroy (elastic#45183) [SIEM] Adds error toasts to MapEmbeddable component (elastic#45088) fix redirect to maintain search query string (elastic#45184) [APM] One-line trace summary (elastic#44842) [Infra UI] Display non-metric details on Node Detail page (elastic#43551) [Maps][File upload] Removing bbox from parsed file pending upstream lib fix (elastic#45194) [Logs UI] Improve live streaming behavior when scrolling (elastic#44923) [APM] Fix indefinite loading state in agent settings for unauthorized user roles (elastic#44970) [Reporting] Rewrite addForceNowQuerystring to getFullUrls (elastic#44851) [Reporting/ESQueue] Improve logging of doc-update events (elastic#45077) [Reporting] Make screenshot capture less noisy by default (elastic#45185) ...

smith · 2019-09-10T15:08:54Z

@cchaos we're using the euiPaletteForStatus from https://elastic.github.io/eui/#/utilities/color-palettes. Do you think these are the correct colors to use for HTTP status codes?

cchaos · 2019-09-10T15:19:38Z

That status palette is more for creating a larger spectrum between green and red. Though they can be used for badges as well, we haven't tested them in that capacity as they were originally created for charts (no text).

smith · 2019-09-10T16:26:30Z

That status palette is more for creating a larger spectrum between green and red. Though they can be used for badges as well, we haven't tested them in that capacity as they were originally created for charts (no text).

@katrin-freihofner should we replace these with Secondary/Warning/Danger? I can make a ticket.

katrin-freihofner · 2019-09-11T07:30:56Z

@smith I guess this would work better. 👍

sorenlouv · 2019-09-11T07:49:32Z

@katrin-freihofner Maybe it's just me, but I find the green in the status palette (#58BA6D) much more indicative of success than the primary badge color (#76a29e) which is closer to a off blue than green.

I've tried to find a bunch of examples of http status code colors, and even though they don't have exactly the same shades they all have green, yellow and red that closer corresponds to success, warning and error imo.

https://www.steveschoger.com/status-code-poster/img/status-code.png

https://i0.wp.com/csharpcorner.mindcrackerinc.netdna-cdn.com/article/create-api-with-asp-net-core-day-three-working-with-http-status-codes-in-asp/Images/image002.jpg?zoom=2

https://i.ytimg.com/vi/LtNSd_4txVc/maxresdefault.jpg

http://1.bp.blogspot.com/-d36gBYfZutc/UIlqyr9JEfI/AAAAAAAAA0g/Gbx_73pNrXg/s1600/HTTP+status+code+defenitions.gif

katrin-freihofner · 2019-09-11T09:12:16Z

@sqren we can use the Eui badge's color prop to set a custom color. I suggest euiColorSecondary #017D73. This color is used to indicate success all over the UI. If we use this, the text should be white.

sorenlouv · 2019-09-11T09:49:48Z

Oh yes, sorry if that's what you meant in the first place. That's much better.

What do you think about:
2xx: #017D73
3xx: #017D73
4xx: #F5A700
5xx: #BD271E

sorenlouv · 2019-09-11T09:54:58Z

2xx is definitely success and 5xx is definitely error.
3xx and 4xx are a little harder to categorize, since they could be both.
I'd say that 3xx should still be considered successful since the redirect happens correctly.
4xx could both be caused by the end user and the web application so warning is more applicable than error.

katrin-freihofner · 2019-09-11T10:16:17Z

In my opinion, a warning is fine for 4xx. What if we use a more neutral color like euiColorDarkShade #69707D for 3xx?

sorenlouv · 2019-09-11T11:16:13Z

What if we use a more neutral color like euiColorDarkShade #69707D for 3xx?

Works for me 👍 We could use the same for 1xx

smith · 2019-09-11T16:46:06Z

@katrin-freihofner @sqren opened #45406 for color updates.

sorenlouv · 2019-10-21T12:32:32Z

Tested in Chrome and Firefox. This should also be cross-browser tested in IE.

smith requested a review from a team as a code owner September 5, 2019 01:53

sorenlouv reviewed Sep 5, 2019

View reviewed changes

dgieselaar reviewed Sep 5, 2019

View reviewed changes

smith added release_note:enhancement v7.5.0 labels Sep 5, 2019

smith force-pushed the nls/43247/trace-summary branch from ccfb859 to 99099ea Compare September 6, 2019 22:01

smith merged commit fda600c into elastic:master Sep 9, 2019

smith deleted the nls/43247/trace-summary branch September 9, 2019 22:37

smith added a commit to smith/kibana that referenced this pull request Sep 9, 2019

[APM] One-line trace summary (elastic#44842)

18c894e

Replace the `StickyTransactionProperties` with a trace summary that puts everything on one line. Fixes elastic#43247.

smith mentioned this pull request Sep 9, 2019

[7.x] [APM] One-line trace summary (#44842) #45215

Merged

smith added a commit that referenced this pull request Sep 10, 2019

[7.x] [APM] One-line trace summary (#44842) (#45215)

5bd8f03

Replace the `StickyTransactionProperties` with a trace summary that puts everything on one line. Fixes #43247.

sorenlouv mentioned this pull request Sep 10, 2019

[APM] Fix missing RUM url #42940

Merged

smith mentioned this pull request Sep 11, 2019

Change status code colors on trace summary #45406

Closed

This was referenced Sep 18, 2019

[APM] Enhance status code presentation in the Transaction sample header #29928

Closed

[APM] Consistent flyout headers #46078

Closed

formgeist mentioned this pull request Sep 19, 2019

[APM] Add user.agent.name and user.agent.version to the trace header summary #46137

Closed

sorenlouv added the apm-test-plan-7.5.0 label Oct 10, 2019

sorenlouv added the apm:test-plan-done Pull request that was successfully tested during the test plan label Oct 21, 2019

sorenlouv removed the apm:test-plan-done Pull request that was successfully tested during the test plan label Oct 21, 2019

ogupte self-assigned this Oct 22, 2019

ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label Oct 22, 2019

[APM] One-line trace summary #44842

[APM] One-line trace summary #44842

Conversation

smith commented Sep 5, 2019 • edited Loading

Summary

Some example screenshots

Checklist

For maintainers

elasticmachine commented Sep 5, 2019

💔 Build Failed

dgieselaar commented Sep 5, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sorenlouv Sep 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sorenlouv Sep 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sorenlouv Sep 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sorenlouv Sep 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sorenlouv Sep 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sorenlouv commented Sep 5, 2019 • edited Loading

sorenlouv Sep 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smith Sep 5, 2019 • edited Loading

Choose a reason for hiding this comment

sorenlouv Sep 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smith commented Sep 5, 2019

dgieselaar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dgieselaar Sep 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smith commented Sep 5, 2019

sorenlouv commented Sep 5, 2019 • edited Loading

sorenlouv commented Sep 5, 2019 • edited Loading

katrin-freihofner commented Sep 6, 2019

sorenlouv commented Sep 6, 2019

katrin-freihofner commented Sep 6, 2019

sorenlouv commented Sep 6, 2019 • edited Loading

smith commented Sep 6, 2019

smith commented Sep 6, 2019

sorenlouv commented Sep 6, 2019 • edited Loading

smith commented Sep 6, 2019

sorenlouv commented Sep 10, 2019 • edited Loading

cchaos commented Sep 10, 2019

smith commented Sep 10, 2019

cchaos commented Sep 10, 2019

smith commented Sep 10, 2019

katrin-freihofner commented Sep 11, 2019

sorenlouv commented Sep 11, 2019 • edited Loading

smith commented Sep 5, 2019 •

edited

Loading

sorenlouv Sep 5, 2019 •

edited

Loading

sorenlouv Sep 5, 2019 •

edited

Loading

sorenlouv Sep 5, 2019 •

edited

Loading

sorenlouv Sep 5, 2019 •

edited

Loading

sorenlouv Sep 5, 2019 •

edited

Loading

sorenlouv commented Sep 5, 2019 •

edited

Loading

sorenlouv Sep 5, 2019 •

edited

Loading

smith Sep 5, 2019 •

edited

Loading

sorenlouv Sep 5, 2019 •

edited

Loading

dgieselaar Sep 5, 2019 •

edited

Loading

sorenlouv commented Sep 5, 2019 •

edited

Loading

sorenlouv commented Sep 5, 2019 •

edited

Loading

sorenlouv commented Sep 6, 2019 •

edited

Loading

sorenlouv commented Sep 6, 2019 •

edited

Loading

sorenlouv commented Sep 10, 2019 •

edited

Loading

sorenlouv commented Sep 11, 2019 •

edited

Loading

sorenlouv commented Sep 11, 2019 •

edited

Loading