-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Consistent flyout headers #46078
Comments
Pinging @elastic/apm-ui |
Should also include the Span detail flyout |
@formgeist I initially added Span detail flyout to the issue but removed it again because it's too different from the others. I think it will require additional design work/thinking and should probably be a separate issue. I haven't created the issue yet because I'm not sure what we want instead of the current grid. If you have any ideas feel free to open an issue (or if you think it's very similar to the single line design in the trace sample header I'll add it here) |
#31895 was created to align the two flyouts, but I'll create a new one that displays in the new format for both and thereby we should achieve consistency for all 🎉 |
On the other hand, we should just use this for the design and then I'll create implementation issues when it's done. |
@formgeist Afaict this is pretty much ready for implementation. What do you think is missing? |
Yes, I closed #31895. Was that premature? I didn't see any reason to keep it around since we are going away from the grid layout. |
@sqren Perhaps because I wasn't around for the decision to remove the information we have in those headers, but I have some concerns around removing the transaction sample ID link in the Error occurrence header. And we're missing an example and description of the Span details flyout in the above summary. Just thought it might be helpful to have proper visual examples of all of the headers and their contents? |
Good point. I agree that should be part of the 1-line design for the error details page. I'll update the description.
Maybe I was not clear above. I think this is very different from the others cases (transaction flyout and error details page) and will require more work (both design-wise and implementation-wise). So it feels like it should be a separate issue. I'm also fine with leaving it as-is.
True, that would be nice 👍 |
I'm not sure I follow how it's different from the other flyout (or cases), can you elaborate? I've created the following mocks of the two flyouts and the error occurrence header. Flyout - Transaction details
Flyout - Span details
Error occurrence header
Thoughts? |
@formgeist I think that looks great! |
I think that's an excellent idea. This came up yesterday #46074 where we're not displaying the absolute timestamps in the user preferred timezone, but we do for all the charts. I'm wondering if there's a downside to displaying relative time, absolute time in a tooltip, but both shifted to the timezone the user is in and not ever displaying the real timestamp recorded? These are the updates mocks for all the headers; Flyout - Transaction detailsFlyout - Span detailsError occurrence header |
@formgeist Really nice touch also showing the timezone 👍 |
@dgieselaar Also added an example of the updated Trace sample header, as we're changing the time to relative and adding the timestamp in a tooltip. |
@dgieselaar Didn't include this task in here because it's not critical to it's implementation, but perhaps worth looking at after? #46074 |
Are we sure we want to drop all the labels even in the details (flyouts)? I think it totally makes sense to have the new/small version on the overview but I would keep the labels in the details to make sure this information is 100% understandable. |
@katrin-freihofner personally I think the grid ended up way too cluttered. Random bits of information scattered around. It seems much better to me to have the absolute minimum of must-have info. |
@sqren thanks for pointing that out - I forgot that we have this information available in the meta tab. I'm also fine with tidying up and redesigning it - I just want to make sure we have the labels available somewhere. |
Yeah, that's a good point. And I'm actually not 100% sure we currently have all the info in the metadata which is why I added this paragraph to the bottom of the description:
|
I think we have the data as the |
The colors for the badges look slightly different in its current state than in the design. The design seems to have lighter shades. Which ones should I stick to? |
I think #45406 is already going to update the status colours, so ignore the colours in my designs for now. |
* [APM] Consistent flyout headers Closes elastic#46078 and elastic#46074. * Tooltips for span flyout badges * Review feedback
In #44842 the trace sample header was redesigned and simplified:
For consistency this design should be applied to the following components:
Flyout - Transaction details
Flyout - Span details
span.timestamp.us
)Trace sample header
Error occurrence header
Additional tasks (polish)
euiColorLightShade
For both components, it is important that all the information that is removed is still available in the "Metadata" tab.
The text was updated successfully, but these errors were encountered: