Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Consistent flyout headers #46078

Closed
sorenlouv opened this issue Sep 18, 2019 · 23 comments · Fixed by #46312
Closed

[APM] Consistent flyout headers #46078

sorenlouv opened this issue Sep 18, 2019 · 23 comments · Fixed by #46312
Assignees
Labels
enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v7.5.0

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Sep 18, 2019

In #44842 the trace sample header was redesigned and simplified:
Screen Shot 2019-09-18 at 22.01.08.png

For consistency this design should be applied to the following components:

Flyout - Transaction details

01 Flyout - Transaction details

  • Service name (link)
  • Transaction name (link)
  • Timestamp (relative, absolute)
  • Duration (% of trace)
  • HTTP info
  • Related errors

Flyout - Span details

02 Flyout - Span details

  • Span name
  • Service (link)
  • Transaction (link)
  • Timestamp (relative, absolute span.timestamp.us)
  • Duration (% of trace)
  • Span type, subtype and action

Trace sample header

01 Transaction sample header

  • Timestamp (relative, absolute)

Error occurrence header

02 Error occurrence header

  • Timestamp (relative, absolute)
  • HTTP info
  • Transaction name (link)

Additional tasks (polish)

  • We will show relative time and put absolute timestamp a tooltip on hover
    Kapture 2019-09-19 at 12 53 56
  • Update the colour of the separating "pipe" between each section in the summary to euiColorLightShade
  • Unbold the request method in the HTTP info badge;
    • Current: Screenshot 2019-09-19 at 13.52.26.png
    • New: http-info-badge.png

For both components, it is important that all the information that is removed is still available in the "Metadata" tab.

@sorenlouv sorenlouv added [zube]: (7.5) Planned for release enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support labels Sep 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@formgeist
Copy link
Contributor

Should also include the Span detail flyout

@sorenlouv
Copy link
Member Author

sorenlouv commented Sep 18, 2019

@formgeist I initially added Span detail flyout to the issue but removed it again because it's too different from the others. I think it will require additional design work/thinking and should probably be a separate issue. I haven't created the issue yet because I'm not sure what we want instead of the current grid. If you have any ideas feel free to open an issue (or if you think it's very similar to the single line design in the trace sample header I'll add it here)

Screen Shot 2019-09-18 at 22 01 57

@formgeist
Copy link
Contributor

#31895 was created to align the two flyouts, but I'll create a new one that displays in the new format for both and thereby we should achieve consistency for all 🎉

@formgeist
Copy link
Contributor

On the other hand, we should just use this for the design and then I'll create implementation issues when it's done.

@formgeist formgeist self-assigned this Sep 19, 2019
@sorenlouv
Copy link
Member Author

@formgeist Afaict this is pretty much ready for implementation. What do you think is missing?

@sorenlouv
Copy link
Member Author

Yes, I closed #31895. Was that premature? I didn't see any reason to keep it around since we are going away from the grid layout.

@formgeist
Copy link
Contributor

@sqren Perhaps because I wasn't around for the decision to remove the information we have in those headers, but I have some concerns around removing the transaction sample ID link in the Error occurrence header. And we're missing an example and description of the Span details flyout in the above summary. Just thought it might be helpful to have proper visual examples of all of the headers and their contents?

@sorenlouv
Copy link
Member Author

sorenlouv commented Sep 19, 2019

I have some concerns around removing the transaction sample ID link in the Error occurrence header

Good point. I agree that should be part of the 1-line design for the error details page. I'll update the description.

we're missing an example and description of the Span details flyout in the above summary

Maybe I was not clear above. I think this is very different from the others cases (transaction flyout and error details page) and will require more work (both design-wise and implementation-wise). So it feels like it should be a separate issue. I'm also fine with leaving it as-is.

Just thought it might be helpful to have proper visual examples of all of the headers and their contents?

True, that would be nice 👍

@sorenlouv
Copy link
Member Author

sorenlouv commented Sep 19, 2019

I'm thinking the design for the error details page could either have the transaction name:

Screen Shot 2019-09-19 at 10 05 54

Or the transaction id like today:

Screen Shot 2019-09-19 at 10 06 24

@formgeist
Copy link
Contributor

formgeist commented Sep 19, 2019

Maybe I was not clear above. I think this is very different from the others cases (transaction flyout and error details page) and will require more work (both design-wise and implementation-wise). So it feels like it should be a separate issue. I'm also fine with leaving it as-is.

I'm not sure I follow how it's different from the other flyout (or cases), can you elaborate?

I've created the following mocks of the two flyouts and the error occurrence header.

Flyout - Transaction details

01 Flyout - Transaction details

  • Service name (link)
  • Transaction name (link)
  • Timestamp
  • Duration (% of trace)
  • HTTP info
  • Related errors

Flyout - Span details

02 Flyout - Span details

  • Span name
  • Service (link)
  • Transaction (link)
  • Timestamp (span.timestamp.us)
  • Duration (% of trace)
  • Span type, subtype and action

Error occurrence header

02 Error occurrence header

  • Timestamp (relative and absolute)
  • HTTP info
  • Transaction name (link)

Thoughts?

@sorenlouv
Copy link
Member Author

sorenlouv commented Sep 19, 2019

@formgeist I think that looks great!
For the error occurrence header you added both the relative and the absolute timestamp. Is that something we should have on all of them for consistency? We are pretty short on horizontal space, so might make sense to show the absolute timestamp as a tooltip? (We should probably do this everywhere we show relative timestamps)

@formgeist
Copy link
Contributor

For the error occurrence header you added both the relative and the absolute timestamp. Is that something we should have on all of them for consistency? We are pretty short on horizontal space, so might make sense to show the absolute timestamp as a tooltip? (We should probably do this everywhere we show relative timestamps)

I think that's an excellent idea. This came up yesterday #46074 where we're not displaying the absolute timestamps in the user preferred timezone, but we do for all the charts. I'm wondering if there's a downside to displaying relative time, absolute time in a tooltip, but both shifted to the timezone the user is in and not ever displaying the real timestamp recorded?

Kapture 2019-09-19 at 12 53 56

These are the updates mocks for all the headers;

Flyout - Transaction details

01 Flyout - Transaction details

Flyout - Span details

02 Flyout - Span details

Error occurrence header

02 Error occurrence header

@sorenlouv
Copy link
Member Author

@formgeist Really nice touch also showing the timezone 👍

@formgeist formgeist removed the design label Sep 19, 2019
@formgeist formgeist removed their assignment Sep 19, 2019
@formgeist
Copy link
Contributor

@dgieselaar Also added an example of the updated Trace sample header, as we're changing the time to relative and adding the timestamp in a tooltip.

@formgeist
Copy link
Contributor

@dgieselaar Didn't include this task in here because it's not critical to it's implementation, but perhaps worth looking at after? #46074

@katrin-freihofner
Copy link
Contributor

Are we sure we want to drop all the labels even in the details (flyouts)? I think it totally makes sense to have the new/small version on the overview but I would keep the labels in the details to make sure this information is 100% understandable.

@sorenlouv
Copy link
Member Author

sorenlouv commented Sep 20, 2019

@katrin-freihofner personally I think the grid ended up way too cluttered. Random bits of information scattered around. It seems much better to me to have the absolute minimum of must-have info.
In the metatab the user will still have access to all the information.

@katrin-freihofner
Copy link
Contributor

@sqren thanks for pointing that out - I forgot that we have this information available in the meta tab. I'm also fine with tidying up and redesigning it - I just want to make sure we have the labels available somewhere.

@sorenlouv
Copy link
Member Author

Yeah, that's a good point. And I'm actually not 100% sure we currently have all the info in the metadata which is why I added this paragraph to the bottom of the description:

For both components, it is important that all the information that is removed is still available in the "Metadata" tab.

@formgeist
Copy link
Contributor

I think we have the data as the user.agent information has been added to the Metadata tab as part of #44842. Although the tab hasn't been re-organized, so finding some specific value might require the user to in-browser search for it.

@dgieselaar
Copy link
Member

The colors for the badges look slightly different in its current state than in the design. The design seems to have lighter shades. Which ones should I stick to?

@formgeist
Copy link
Contributor

I think #45406 is already going to update the status colours, so ignore the colours in my designs for now.

dgieselaar added a commit to dgieselaar/kibana that referenced this issue Sep 25, 2019
dgieselaar added a commit that referenced this issue Sep 25, 2019
* [APM] Consistent flyout headers

Closes #46078 and #46074.

* Tooltips for span flyout badges

* Review feedback
dgieselaar added a commit to dgieselaar/kibana that referenced this issue Sep 25, 2019
* [APM] Consistent flyout headers

Closes elastic#46078 and elastic#46074.

* Tooltips for span flyout badges

* Review feedback
dgieselaar added a commit that referenced this issue Sep 26, 2019
* [APM] Consistent flyout headers (#46312)

* [APM] Consistent flyout headers

Closes #46078 and #46074.

* Tooltips for span flyout badges

* Review feedback

* Fix import for SERVICE_NAME in StickySpanProperties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v7.5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants