Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed Snapshot with Short URL, ?embed=true not working to remove header and nav drawer #50107

Closed
Tracked by #168126
MarnieGordon opened this issue Nov 8, 2019 · 8 comments · Fixed by #58846
Closed
Tracked by #168126
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@MarnieGordon
Copy link

Kibana version:7.4.0

Elasticsearch version: 7.4.0

Server OS version: Windows

Browser version: all current (IE/Chrome/Firefox)

Browser OS version: all current

Original install method (e.g. download page, yum, from source, etc.):download page

Describe the bug:Embed Snapshot with Short URL, ?embed=true not working to remove header and nav drawer

Steps to reproduce:

  1. Create dashboard
  2. Share => Embed Code => Snapshot => Short URL
  3. Embed iframe in .net application or navigate to referenced URL in a different browser
  4. Kibana displays dashboard with full header and nav drawer, not removed

Expected behavior:
In previous version (recent upgrade from 5.5.2 and 6.3.2), the embed=true removes header and nav drawer, as it still does when using the Embed Code => Saved object method.

Screenshots (if relevant):

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

@wylieconlon wylieconlon added Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure triage_needed labels Nov 8, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@tylersmalley
Copy link
Contributor

@majagrubic
Copy link
Contributor

Looks like when transforming the short URL to a regular URL the embed=true is lost and that's why the config is not preserved.

@flash1293
Copy link
Contributor

I just tested this with an upgrade from 6.8 to 7.12 and it didn't work for me (at least for custom spaces)

The url looks like this:
http://localhost:5605/s/asd/goto/36d6831001a74d5db7f830d0cdfe3fc3?embed=true

And it seems like somehow in the URL migration process the embed flag gets lost and the URL renders with chrome

@kmartastic kmartastic added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated labels Mar 1, 2021
@kmartastic
Copy link
Contributor

@clintandrewhall perhaps a quick win for @ThomThomson? LOE:needs research.

@stratoula stratoula added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Hrithik-Manchanda
Copy link

Same issue faced after upgrade from 7.17 version to 8.5 version

@ThomThomson
Copy link
Contributor

Closing this for the time being. It will be tracked in our Icebox for Iframe / Embedding issues and will be re-opened if our priorities change.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.