Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook breaks when importing from kibana-react #60356

Closed
Dosant opened this issue Mar 17, 2020 · 2 comments · Fixed by #60601
Closed

Storybook breaks when importing from kibana-react #60356

Dosant opened this issue Mar 17, 2020 · 2 comments · Fixed by #60601
Labels
bug Fixes for quality problems that affect the customer experience triage_needed

Comments

@Dosant
Copy link
Contributor

Dosant commented Mar 17, 2020

yarn storybook drilldowns

Errors during build:

ERROR in /Users/antondosov/Dev/kibana/src/plugins/kibana_react/public/validated_range/validated_dual_range.tsx
Module build failed (from /Users/antondosov/Dev/kibana/node_modules/react-docgen-typescript-loader/dist/index.js):
TypeError: Cannot read property 'properties' of undefined
    at Parser.extractDefaultPropsFromComponent (/Users/antondosov/Dev/kibana/node_modules/react-docgen-typescript/src/parser.ts:588:68)
    at Parser.getComponentInfo (/Users/antondosov/Dev/kibana/node_modules/react-docgen-typescript/src/parser.ts:245:33)
    at /Users/antondosov/Dev/kibana/node_modules/react-docgen-typescript/src/parser.ts:940:20
    at Array.map (<anonymous>)
    at /Users/antondosov/Dev/kibana/node_modules/react-docgen-typescript/src/parser.ts:939:12
    at Array.reduce (<anonymous>)
    at parseWithProgramProvider (/Users/antondosov/Dev/kibana/node_modules/react-docgen-typescript/src/parser.ts:928:6)
    at Object.parseWithProgramProvider (/Users/antondosov/Dev/kibana/node_modules/react-docgen-typescript/src/parser.ts:161:14)
    at processResource (/Users/antondosov/Dev/kibana/node_modules/react-docgen-typescript-loader/src/loader.ts:113:32)
    at Object.loader (/Users/antondosov/Dev/kibana/node_modules/react-docgen-typescript-loader/src/loader.ts:39:23)
 @ /Users/antondosov/Dev/kibana/src/plugins/kibana_react/public/validated_range/index.ts 13:28-61
 @ /Users/antondosov/Dev/kibana/src/plugins/kibana_react/public/index.ts
 @ ../advanced_ui_actions/public/components/action_wizard/test_data.tsx
 @ ./public/components/connected_flyout_manage_drilldowns/connected_flyout_manage_drilldowns.story.tsx

Issue caused by kibana_react/public/validated_range and looks like introduced in #59689

For now I temporarily disabled that component from config, but it has to be fixed in component. Could be caused by @ts-ignores usage fro Props/State in that component.

#54707

@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Team:AppArch labels Mar 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich
Copy link
Contributor

Also it shows this error in console:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience triage_needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants