Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate dual validated range #59689

Merged
merged 29 commits into from
Mar 16, 2020
Merged

Migrate dual validated range #59689

merged 29 commits into from
Mar 16, 2020

Conversation

kindsun
Copy link
Contributor

@kindsun kindsun commented Mar 9, 2020 •
edited
Loading

Summary

Migrates dual validated range to NP and updates to TypeScript. Blocker for #59585

image

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kindsun
Copy link
Contributor Author

kindsun commented Mar 9, 2020

@elasticmachine merge upstream

@kindsun kindsun marked this pull request as ready for review March 11, 2020 15:29
@kindsun kindsun requested review from a team as code owners March 11, 2020 15:29
@kindsun kindsun requested a review from nreese March 11, 2020 15:29
@kindsun kindsun added the release_note:skip Skip the PR/issue when compiling release notes label Mar 11, 2020
@kindsun
Copy link
Contributor Author

kindsun commented Mar 11, 2020

@elasticmachine merge upstream

@kindsun kindsun mentioned this pull request Mar 11, 2020
Closed
11 tasks
@kindsun kindsun requested a review from nreese March 12, 2020 19:53
@flash1293 flash1293 mentioned this pull request Mar 13, 2020
Closed
69 tasks
@kindsun kindsun requested a review from nreese March 13, 2020 14:31
nreese
nreese approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving and migrating this component to TS.

lgtm with green CI
code review

streamich
streamich approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppArch changes LGTM, except the @ts-ignores.

src/plugins/kibana_react/public/validated_range/validated_dual_range.tsx Show resolved Hide resolved
src/plugins/kibana_react/public/validated_range/validated_dual_range.tsx Show resolved Hide resolved
src/plugins/kibana_react/public/validated_range/validated_dual_range.tsx Show resolved Hide resolved
src/plugins/kibana_react/public/validated_range/validated_dual_range.tsx Show resolved Hide resolved
Aaron Caldwell added 2 commits March 13, 2020 15:11
Merge remote-tracking branch 'upstream/master' into np-migrate-dual-v…
c5acf30 
…alidated-range
Add back in last 2 ts-ignores. Build fails without focusable attribut…
dabe3b9 
…e on EuiDualRange & No good alternatives for spread syntax in TS components
@kindsun
Copy link
Contributor Author

kindsun commented Mar 13, 2020

retest

@kindsun
Copy link
Contributor Author

kindsun commented Mar 16, 2020

@elasticmachine merge upstream

elasticmachine and others added 2 commits March 16, 2020 09:11
@elasticmachine
Merge branch 'master' into np-migrate-dual-validated-range
85b1887
Rollback change to state init. Initializing state to null actually tr…
2e92b23 
…iggers a react browser warning and complicates using 'prevState' in getDerivedStateFromProps
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kindsun kindsun merged commit c898e79 into elastic:master Mar 16, 2020
@kindsun kindsun mentioned this pull request Mar 16, 2020
Merged
kindsun pushed a commit to kindsun/kibana that referenced this pull request Mar 16, 2020
@elasticmachine
Migrate dual validated range (elastic#59689)
0f3dce9 
* Move validated range files to new NP location

* Update refs in code

* Clean up old validated range files

* Change relative paths to 'kibana-react'. Some clean up

* Change to relative paths

* Fix i18n errors

* i18n clean up. Export module explicitly

* Change files over to TS to prevent build issue where validated range was missing

* Clean up TS conversion

* More clean up. Extend EuiRangeProps

* Remove unneeded ts-ignore

* Review feedback and test fixes

* Change double to single quotes

* min and max aren't always passed, make optional

* Type updates

* Review feedback. Set state to empty on init and add ignore comment

* Review feedback

* Add back in last 2 ts-ignores. Build fails without focusable attribute on EuiDualRange & No good alternatives for spread syntax in TS components

* Rollback change to state init. Initializing state to null actually triggers a react browser warning and complicates using 'prevState' in getDerivedStateFromProps

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kindsun pushed a commit that referenced this pull request Mar 16, 2020
@elasticmachine
Migrate dual validated range (#59689) (#60312)
a3a2acb 
* Move validated range files to new NP location

* Update refs in code

* Clean up old validated range files

* Change relative paths to 'kibana-react'. Some clean up

* Change to relative paths

* Fix i18n errors

* i18n clean up. Export module explicitly

* Change files over to TS to prevent build issue where validated range was missing

* Clean up TS conversion

* More clean up. Extend EuiRangeProps

* Remove unneeded ts-ignore

* Review feedback and test fixes

* Change double to single quotes

* min and max aren't always passed, make optional

* Type updates

* Review feedback. Set state to empty on init and add ignore comment

* Review feedback

* Add back in last 2 ts-ignores. Build fails without focusable attribute on EuiDualRange & No good alternatives for spread syntax in TS components

* Rollback change to state init. Initializing state to null actually triggers a react browser warning and complicates using 'prevState' in getDerivedStateFromProps

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@Dosant Dosant mentioned this pull request Mar 17, 2020
Closed
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 17, 2020
@gmmorris
Merge branch 'master' into alerting/tls-warning
ff11eb0 
* master: (30 commits)
  [TSVB] fix text color when using custom background color (elastic#60261)
  Fix import to timefilter from in TSVB (elastic#60296)
  [NP] Get rid of usage redirectWhenMissing service (elastic#59777)
  [SIEM] Fix Timeline footer styling (elastic#59587)
  [ML] Fixes to error handling for analytics jobs and file data viz (elastic#60249)
  Give better stack traces for Unhandled Promise Rejection warnings (elastic#60235)
  resolves elastic#58905 (elastic#60120)
  Added variables button for text fields in Pagerduty component. (elastic#60189)
  adds test that action vars are rendered for alert action parms (elastic#60310)
  Closes 59786 by removing the update toast (elastic#60172)
  [EPM] Packages list tabs (elastic#60167)
  Added message variables button for Webhook body form field (elastic#60174)
  Revert "adds new test (elastic#60064)"
  [Maps] move MapSavedObject type out of telemetry (elastic#60127)
  [Reporting] Fix error handling for job handler in route (elastic#60161)
  [Endpoint] TEST: verify alerts page header says 'Alerts' (elastic#60206)
  EMT-248: implement ack resource to accept event payload to acknowledge agent actions (elastic#60218)
  Migrate dual validated range (elastic#59689)
  Embeddable triggers (elastic#58440)
  [Endpoint] Sample data generator CLI script (elastic#59952)
  ...
@thomasneirynck thomasneirynck mentioned this pull request May 29, 2020
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majagrubic majagrubic majagrubic left review comments

@nreese nreese nreese approved these changes

@streamich streamich streamich approved these changes

Assignees
No one assigned
Labels
blocker [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kindsun @elasticmachine @kibanamachine @nreese @majagrubic @streamich