Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.src/plugins/vis_type_vega/public - VegaVisualizations VegaVisualization - basics should add a small subpixel value to the height of the canvas to avoid getting it set to 0 #71713

Closed
kibanamachine opened this issue Jul 14, 2020 · 5 comments · Fixed by #71834
Closed

Failing test: Jest Tests.src/plugins/vis_type_vega/public - VegaVisualizations VegaVisualization - basics should add a small subpixel value to the height of the canvas to avoid getting it set to 0 #71713

kibanamachine opened this issue Jul 14, 2020 · 5 comments · Fixed by #71834
Assignees
@alexwizp
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Vega Vega visualizations skipped-test Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 14, 2020 •
edited
Loading

A test failed on a tracked branch

TypeError: Cannot read property 'height' of null
    at Object.test (/dev/shm/workspace/kibana/src/plugins/vis_type_vega/public/vega_visualization.test.js:226:25)
    at process._tickCallback (internal/process/next_tick.js:68:7)

First failure: Jenkins Build
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jul 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

spalger added a commit that referenced this issue Jul 14, 2020
@spalger
skip flaky suite (#71713)
513d0e0
spalger added a commit that referenced this issue Jul 14, 2020
@spalger
skip flaky suite (#71713)
576cd99 
(cherry picked from commit 513d0e0)
@spalger
Copy link
Contributor

spalger commented Jul 14, 2020

This has failed 14 times recently, several times in PRs before merge and like 12 times in recent PRs plus once on master.

image

Skipped

master: 513d0e0
7.x/7.9: 576cd99

@spalger spalger added blocker Feature:Vega Vega visualizations skipped-test v7.9.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@flash1293
Copy link
Contributor

@dziyanadzeraviankina Could you check this one out? Seems like converting the tests to jest made this particular failure a lot more likely

@alexwizp alexwizp mentioned this issue Jul 15, 2020
Merged
7 tasks
@alexwizp alexwizp mentioned this issue Sep 24, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Vega Vega visualizations skipped-test Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Failing test: Jest Tests.src/plugins/vis_type_vega/public alexwizp/kibana
6 participants
@timroes @spalger @flash1293 @elasticmachine @alexwizp @kibanamachine