Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.src/plugins/vis_type_vega/public #71834

Merged
merged 12 commits into from
Jul 23, 2020
Merged

Failing test: Jest Tests.src/plugins/vis_type_vega/public #71834

merged 12 commits into from
Jul 23, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jul 15, 2020 •
edited
Loading

Closes: #71713

Summary

A test failed on a tracked branch

TypeError: Cannot read property 'height' of null
    at Object.test (/dev/shm/workspace/kibana/src/plugins/vis_type_vega/public/vega_visualization.test.js:226:25)
    at process._tickCallback (internal/process/next_tick.js:68:7)

First failure: Jenkins Build

Checklist

Delete any items that are not applicable to this PR.

For maintainers

alexwizp
alexwizp commented Jul 15, 2020
View reviewed changes
src/plugins/vis_type_vega/public/vega_visualization.test.js

await vegaVis.render(vegaParser);
const vegaView = vegaVis._vegaView._view;
expect(vegaView.height()).toBe(250.00000001);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think problem was in that line. I decide to remove that test cause we already have have some snapshots with that adjusted height
image

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp alexwizp requested a review from flash1293 July 17, 2020 09:57
@alexwizp alexwizp self-assigned this Jul 17, 2020
@alexwizp alexwizp marked this pull request as ready for review July 17, 2020 09:57
@alexwizp alexwizp requested a review from a team July 17, 2020 09:57
flash1293
flash1293 reviewed Jul 17, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think problem was in that line.

Quite possible. Actually, while we are at it - I introduced this weird hack a while back because the height signal would not work right when the height of the canvas is an even number.
https://github.com/flash1293/kibana/blob/97d81288bd1d3e19e8dece12c08d1cb9dbe1203a/src/plugins/vis_type_vega/public/vega_view/vega_base_view.js#L200

As we updated to vega 5 lately it's very possible this bug got fixed. If this is. the case, let's not just remove the test but the workaround itself as well. Could you test whether that's the case?

The test spec deleted in this PR is a good way to validate:
https://github.com/elastic/kibana/pull/71834/files#diff-ac66b0b6d3fe13ce5d2bc22b202f7450L194-L213

This should display a centered "Test" text. When slowly changing the height of the browser window, the text should stay centered - if the bug is still present in vega, it will jump to the top and back to the center.

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@alexwizp
Copy link
Contributor Author

#31461 fix was removed. All works fine with new version of Vega

@alexwizp alexwizp added Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes failed-test A test failure on a tracked branch, potentially flaky-test labels Jul 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
visTypeVega 1.4MB -47.0B 1.4MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293
flash1293 approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen it works, code LGTM

@alexwizp alexwizp merged commit b2a473d into elastic:master Jul 23, 2020
@alexwizp alexwizp mentioned this pull request Jul 23, 2020
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jul 23, 2020
@alexwizp @elasticmachine
Failing test: Jest Tests.src/plugins/vis_type_vega/public (elastic#71834
fbb408e 
)

* Failing test: Jest Tests.src/plugins/vis_type_vega/public

* remove workaround for vega height bug

Related to elastic#31461

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 23, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-timers
b4e78e7 
* master: (35 commits)
  Migrated karma tests to jest (elastic#72649)
  Migrate status page app to core (elastic#72017)
  Failing test: Jest Tests.src/plugins/vis_type_vega/public (elastic#71834)
  Fix Firefox TSVB flaky test with switch index patterns (elastic#72882)
  [ML] Fixing link to index management from file data visualizer (elastic#72863)
  test: 💍 add test for sub-expression variables (elastic#71644)
  fix bug (elastic#72809)
  [keystore] use get_keystore in server cli (elastic#72954)
  Show step number instead of incomplete step. (elastic#72866)
  Fix bug where user can't add an exception when "close alert" is checked (elastic#72919)
  [Monitoring] Fix issues displaying alerts (elastic#72891)
  [Ingest Manager] Add more Fleet concurrency tests elastic#71744 (elastic#72338)
  [Security Solution][Exceptions] - Update UI exceptions builder nested logic (elastic#72490)
  disable renovate masterIssue
  [ML] API integration tests for UPDATE data frame analytics endpoint (elastic#72710)
  [Uptime] Fix accessibility issue in Uptime app nav links (elastic#72926)
  [Maps] fix removing global filter from layer can cause app to start thrashing (elastic#72763)
  [Maps] fix blended layer aggregation error when using composite aggregation (elastic#72759)
  fix unexpected arguments to unload command
  Limits the upload size of lists to 9 meg size (elastic#72898)
  ...
alexwizp added a commit that referenced this pull request Jul 23, 2020
@alexwizp @elasticmachine
Failing test: Jest Tests.src/plugins/vis_type_vega/public (#71834) (#…
65c97e4 
…73015)

* Failing test: Jest Tests.src/plugins/vis_type_vega/public

* remove workaround for vega height bug

Related to #31461

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DianaDerevyankina DianaDerevyankina DianaDerevyankina approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees

@alexwizp alexwizp

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@alexwizp @elasticmachine @kibanamachine @flash1293 @DianaDerevyankina