[keystore] use get_keystore in server cli #72954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
added
review
v7.10.0
v7.9.0
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
LeeDr
reviewed
Jul 22, 2020
| @@ -34,7 +34,7 @@ node scripts/functional_tests --assert-none-excluded \ | |||
| if [[ -z "$CODE_COVERAGE" ]] ; then | |||
| echo " -> building and extracting default Kibana distributable for use in functional tests" | |||
| cd "$KIBANA_DIR" | |||
| node scripts/build --debug --no-oss | |||
| node scripts/build --debug --no-oss --all-platforms | |||
There was a problem hiding this comment.
I'm not clear what this change does. What platform(s) were we not building that we are now? And are we testing those other platforms somehow?
There was a problem hiding this comment.
it's a convenience asking ci to do a build for docker that will be reverted before merging - you'll see it on the upload report in jenkins. i'm planning on doing one more pass with that in your exact setup once the uploads are up
LeeDr
approved these changes
Jul 22, 2020
tylersmalley
approved these changes
Jul 23, 2020
|
Looks good to me after |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
jbudz
added a commit
that referenced
this pull request
Jul 23, 2020
* [keystore] use get_keystore in server cli * temporily add docker build so this can be retested in original env * Revert "temporily add docker build so this can be retested in original env" This reverts commit 25f401a.
jbudz
added a commit
that referenced
this pull request
Jul 23, 2020
* [keystore] use get_keystore in server cli * temporily add docker build so this can be retested in original env * Revert "temporily add docker build so this can be retested in original env" This reverts commit 25f401a.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 23, 2020
* master: (35 commits) Migrated karma tests to jest (elastic#72649) Migrate status page app to core (elastic#72017) Failing test: Jest Tests.src/plugins/vis_type_vega/public (elastic#71834) Fix Firefox TSVB flaky test with switch index patterns (elastic#72882) [ML] Fixing link to index management from file data visualizer (elastic#72863) test: 💍 add test for sub-expression variables (elastic#71644) fix bug (elastic#72809) [keystore] use get_keystore in server cli (elastic#72954) Show step number instead of incomplete step. (elastic#72866) Fix bug where user can't add an exception when "close alert" is checked (elastic#72919) [Monitoring] Fix issues displaying alerts (elastic#72891) [Ingest Manager] Add more Fleet concurrency tests elastic#71744 (elastic#72338) [Security Solution][Exceptions] - Update UI exceptions builder nested logic (elastic#72490) disable renovate masterIssue [ML] API integration tests for UPDATE data frame analytics endpoint (elastic#72710) [Uptime] Fix accessibility issue in Uptime app nav links (elastic#72926) [Maps] fix removing global filter from layer can cause app to start thrashing (elastic#72763) [Maps] fix blended layer aggregation error when using composite aggregation (elastic#72759) fix unexpected arguments to unload command Limits the upload size of lists to 9 meg size (elastic#72898) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new helper util to get the correct keystore path was introduced during the deprecation of data/kibana.keystore. This was not used the the sibling cli read_keystore and was causing scenarios with writes to the config folder and reads from the data folder.
This was initially found in docker images but is not docker specific
Closes #72323
manual testing
rm -f {data,config}/kibana.keystorebefore fix
the server inconrrectly reads from the data directory and starts when it should not
after fix
examples uses an invalid config value with an expected exit error on start
data path
config path