Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Exceptions] Fix bug where user can't add an exception when "close alert" is checked #72919

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

peluja1012
Copy link
Contributor

@peluja1012 peluja1012 commented Jul 22, 2020

Summary

Fix PR fixes a bug where the user can't add an exception when "close alert" checkbox is checked. Before this fix, the submit button in the Add Modal spins forever and no exception is added.

Before

add_exception_hook_bug_1 mov

After

add_exception_hook_bug_2 mov

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@peluja1012 peluja1012 requested review from a team as code owners July 22, 2020 17:14
@peluja1012 peluja1012 added release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.10.0 v7.9.0 v8.0.0 labels Jul 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks small and concise enough, what else is there to say.

Forwards and onwards

@peluja1012
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +664.0B 7.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@peluja1012 peluja1012 merged commit ac8cdf3 into elastic:master Jul 23, 2020
peluja1012 added a commit to peluja1012/kibana that referenced this pull request Jul 23, 2020
…ed (elastic#72919)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
peluja1012 added a commit to peluja1012/kibana that referenced this pull request Jul 23, 2020
…ed (elastic#72919)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
peluja1012 added a commit that referenced this pull request Jul 23, 2020
…ed (#72919) (#72991)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
peluja1012 added a commit that referenced this pull request Jul 23, 2020
…ed (#72919) (#72992)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 23, 2020
* master: (35 commits)
  Migrated karma tests to jest (elastic#72649)
  Migrate status page app to core (elastic#72017)
  Failing test: Jest Tests.src/plugins/vis_type_vega/public (elastic#71834)
  Fix Firefox TSVB flaky test with switch index patterns (elastic#72882)
  [ML] Fixing link to index management from file data visualizer (elastic#72863)
  test: 💍 add test for sub-expression variables (elastic#71644)
  fix bug (elastic#72809)
  [keystore] use get_keystore in server cli (elastic#72954)
  Show step number instead of incomplete step. (elastic#72866)
  Fix bug where user can't add an exception when "close alert" is checked (elastic#72919)
  [Monitoring] Fix issues displaying alerts (elastic#72891)
  [Ingest Manager] Add more Fleet concurrency tests elastic#71744 (elastic#72338)
  [Security Solution][Exceptions] - Update UI exceptions builder nested logic (elastic#72490)
  disable renovate masterIssue
  [ML] API integration tests for UPDATE data frame analytics endpoint (elastic#72710)
  [Uptime] Fix accessibility issue in Uptime app nav links (elastic#72926)
  [Maps] fix removing global filter from layer can cause app to start thrashing (elastic#72763)
  [Maps] fix blended layer aggregation error when using composite aggregation (elastic#72759)
  fix unexpected arguments to unload command
  Limits the upload size of lists to 9 meg size (elastic#72898)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants