-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test: Jest Tests.src/plugins/vis_type_vega/public #71834
Merged
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9d8bf8c
Failing test: Jest Tests.src/plugins/vis_type_vega/public
alexwizp c7097ab
Merge branch 'master' into vega_test
elasticmachine ab4e24b
Merge branch 'master' into vega_test
elasticmachine b69f296
Merge branch 'master' into vega_test
elasticmachine 931bb7e
Merge branch 'master' into vega_test
elasticmachine c2b15b2
Merge branch 'master' into vega_test
elasticmachine 8af777e
Merge branch 'master' into vega_test
elasticmachine b9d0533
Merge branch 'master' into vega_test
elasticmachine fbb20da
Merge branch 'master' into vega_test
elasticmachine 426a6ba
Merge branch 'master' into vega_test
elasticmachine d56a0fa
Merge branch 'master' into vega_test
elasticmachine bd26897
remove workaround for vega height bug
alexwizp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think problem was in that line. I decide to remove that test cause we already have have some snapshots with that adjusted height