Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving visualizations with percent in name causes error #7332

Closed
w33ble opened this issue May 31, 2016 · 1 comment
Closed

Saving visualizations with percent in name causes error #7332

w33ble opened this issue May 31, 2016 · 1 comment
Assignees
@ppisljar
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit

Comments

@w33ble
Copy link
Contributor

w33ble commented May 31, 2016

As seen here, using a percent, %, in the name of a visualization will cause an error:

may-31-2016 14-45-49

Visualization Editor: Request to Elasticsearch failed: "Bad Request"

Stack trace:

Error: Request to Elasticsearch failed: "Bad Request"
    at https://localhost:5601/wiz/bundles/kibana.bundle.js?v=8467:73859:14
    at processQueue (https://localhost:5601/wiz/bundles/commons.bundle.js?v=8467:37070:29)
    at https://localhost:5601/wiz/bundles/commons.bundle.js?v=8467:37086:28
    at Scope.$eval (https://localhost:5601/wiz/bundles/commons.bundle.js?v=8467:38314:29)
    at Scope.$digest (https://localhost:5601/wiz/bundles/commons.bundle.js?v=8467:38125:32)
    at Scope.$apply (https://localhost:5601/wiz/bundles/commons.bundle.js?v=8467:38422:25)
    at done (https://localhost:5601/wiz/bundles/commons.bundle.js?v=8467:32871:48)
    at completeRequest (https://localhost:5601/wiz/bundles/commons.bundle.js?v=8467:33069:8)
    at XMLHttpRequest.requestLoaded (https://localhost:5601/wiz/bundles/commons.bundle.js?v=8467:33010:10)

Resulting request is https://localhost:5601/wiz/elasticsearch/.kibana/visualization/UA-%25-HERE?op_type=create
@w33ble w33ble added bug Fixes for quality problems that affect the customer experience P1 labels May 31, 2016
@Bargs Bargs added the good first issue low hanging fruit label Jul 8, 2016
@ppisljar
Copy link
Member

ppisljar commented Jul 10, 2016 •
edited
Loading

What would be preffered way to solve this ?

  • dont allow % in visualization name or
  • make it work with % in visualization name ?

@ppisljar ppisljar reopened this Jul 10, 2016
ppisljar added a commit to ppisljar/kibana that referenced this issue Jul 10, 2016
@ppisljar
fix elastic#7332 - saving vis with % in name causes error
db32541
@ppisljar ppisljar mentioned this issue Jul 10, 2016
Merged
@ppisljar ppisljar self-assigned this Jul 11, 2016
@ppisljar ppisljar added WIP Work in progress and removed WIP Work in progress labels Jul 17, 2016
LeeDr pushed a commit that referenced this issue Aug 3, 2016
Merge pull request #7701 from ppisljar/fix/7332
4469e88 
fix #7332 - saving vis with % in name causes error
airow pushed a commit to airow/kibana that referenced this issue Feb 16, 2017
@ppisljar
fix elastic#7332 - saving vis with % in name causes error
52e4536 
Former-commit-id: db32541
airow pushed a commit to airow/kibana that referenced this issue Feb 16, 2017
Merge pull request elastic#7701 from ppisljar/fix/7332
0602235 
fix elastic#7332 - saving vis with % in name causes error

Former-commit-id: 4469e88
jbudz pushed a commit that referenced this issue Dec 18, 2023
@tkajtoch @cee-chen
@kibanamachine @stratoula
Upgrade EUI to v91.0.0 (with backports) (#170716)
b043545 
`v90.0.0`⏩`v91.0.0-backport.0`

⚠️ While this upgrade pings many teams and has a large code diff, **the
majority of the changes are snapshots or tests-related** and do not
touch source code, so should theoretically only need a code review and
not dedicated QA.

The changes in EUI that required a large swathe of these updates are:

- **EuiPopover** removed an extra unnecessary `<div>` wrapper on its
anchors, which affected many snapshots and a few CSS overrides, which
should have been updated
- **EuiButtonGroup** now renders `<button>` elements instead of `<input
type="radio">` elements for single selection, which affected both
snapshots and E2E tests
- **EuiSuperDatePicker**'s absolute date input now requires an `Enter`
keypress when parsing dates (affected E2E tests)
- **EuiComboBox**, when rendered with `singleSelection={{ plainText:
'true' }}`, no longer renders a pill (i.e. text). This combobox type now
behaves more like an `EuiFieldText`, where the selection is rendered via
input `value` instead. This affected a high amount of E2E tests (both
FTR and Cypress), both in terms of updating assertions and changing
selections, but should **not** significantly affect user experience -
see elastic/eui#7332 for more.

---

##
[`v91.0.0-backport.0`](https://github.com/elastic/eui/tree/v91.0.0-backport.0)

**This is a backport release only intended for use by Kibana.**

- Added `esqlVis`, `pipeBreaks`, and `pipeNoBreaks` icon glyphs.
- `EuiSelectable` now allows configurable text truncation via
`listProps.truncationProps`
([#7388](elastic/eui#7388))
- `EuiTextTruncate` now supports a new `calculationDelayMs` prop for
working around font loading or layout shifting scenarios
([#7388](elastic/eui#7388))

**Bug fixes**

- Fixed a bug with `EuiSelectable`s with custom `truncationProps`, where
scrollbar widths were not being accounted for
([#7392](elastic/eui#7392))

## [`91.0.0`](https://github.com/elastic/eui/tree/v91.0.0)

- Updated the background color of `EuiPopover`s in dark mode to increase
visibility & contrast against other page/panel backgrounds
([#7310](elastic/eui#7310))
- Memoized `EuiDataGrid` to prevent unneeded re-renders
([#7324](elastic/eui#7324))
- Added a configurable `role` prop to `EuiAccordion`
([#7326](elastic/eui#7326))
- Added a configurable `role` prop to `EuiGlobalToastList`
([#7328](elastic/eui#7328))
- For greater flexibility, `EuiSuperDatePicker` now allows users to
paste ISO 8601, RFC 2822, and Unix timestamps in the `Absolute` tab
input, in addition to timestamps in the `dateFormat` prop
([#7331](elastic/eui#7331))
- Plain text `EuiComboBox`es now behave more like a normal text
field/input. Backspacing will no longer delete the entire value, and
selected values can now be double clicked and copied.
([#7332](elastic/eui#7332))
- `EuiDataGrid`'s display settings popover now allows users to clear the
"Lines per row" input before typing in a new number
([#7338](elastic/eui#7338))
- Improved the UX of `EuiSuperDatePicker`'s Absolute tab for users
manually typing in timestamps
([#7341](elastic/eui#7341))
- Updated `EuiI18n`s with multiple `tokens` to accept dynamic `values`
([#7341](elastic/eui#7341))

**Bug fixes**

- Fixed `EuiComboBox`'s `onSearchChange` callback to pass the correct
`hasMatchingOptions` value
([#7334](elastic/eui#7334))
- Fixed an `EuiSelectableTemplateSitewide` bug where the `popoverButton`
behavior would break if passed a non-DOM React wrapper
([#7339](elastic/eui#7339))

**Deprecations**

- `EuiPopover`: deprecated `anchorClassName`. Use `className` instead
([#7311](elastic/eui#7311))
- `EuiPopover`: deprecated `buttonRef`. Use `popoverRef` instead
([#7311](elastic/eui#7311))
- `EuiPopover`: removed extra `.euiPopover__anchor` div wrapper. Target
`.euiPopover` instead if necessary
([#7311](elastic/eui#7311))
- Deprecated `EuiButtonGroup`'s `name` prop. This can safely be removed.
([#7325](elastic/eui#7325))

**Breaking changes**

- Removed deprecated `euiPaletteComplimentary` - use
`euiPaletteComplementary` Instead
([#7333](elastic/eui#7333))

**Accessibility**

- Updated `type="single"` `EuiButtonGroup`s to render standard buttons
instead of radio buttons under the hood, per recent a11y recommendations
([#7325](elastic/eui#7325))
- `EuiAccordion` now defaults to a less screenreader-noisy `group` role
instead of `region`. If your accordion contains significant enough
content to be a document landmark role, you may re-configure it back to
`region`. ([#7326](elastic/eui#7326))
- Reduced screen reader noisiness when sorting `EuiDataGrid` columns via
toolbar ([#7327](elastic/eui#7327))
- `EuiGlobalToastList` now defaults to a `log` role. If your toasts will
always require immediate user action, consider (with caution) using the
`alert` role instead.
([#7328](elastic/eui#7328))

**CSS-in-JS conversions**

- Updated `$euiFontFamily` and `$euiCodeFontFamily` to match Emotion
fonts ([#7332](elastic/eui#7332))

---------

Co-authored-by: Cee Chen <constance.chen@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppisljar ppisljar

Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@w33ble @Bargs @ppisljar