Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome UI Functional Tests.test/functional/apps/home/_sample_data·ts - homepage app sample data dashboard should render visualizations #89379

Closed
kibanamachine opened this issue Jan 26, 2021 · 17 comments · Fixed by #89460
Closed

Failing test: Chrome UI Functional Tests.test/functional/apps/home/_sample_data·ts - homepage app sample data dashboard should render visualizations #89379

kibanamachine opened this issue Jan 26, 2021 · 17 comments · Fixed by #89460
Assignees
@TinaHeiligers
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test skipped-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.12.0 v8.0.0

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 26, 2021 •
edited
Loading

A test failed on a tracked branch

Error: retry.try timeout: Error: expected 25 to equal 50
    at Assertion.assert (packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (packages/kbn-expect/expect.js:227:8)
    at Assertion.be (packages/kbn-expect/expect.js:69:22)
    at /dev/shm/workspace/parallel/20/kibana/test/functional/services/dashboard/expectations.ts:218:43
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at runAttempt (test/common/services/retry/retry_for_success.ts:27:15)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:66:21)
    at Retry.try (test/common/services/retry/retry.ts:32:14)
    at DashboardExpect.savedSearchRowCount (test/functional/services/dashboard/expectations.ts:213:7)
    at Context.<anonymous> (test/functional/apps/home/_sample_data.ts:104:9)
    at Object.apply (packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
    at onFailure (test/common/services/retry/retry_for_success.ts:17:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:57:13)
    at Retry.try (test/common/services/retry/retry.ts:32:14)
    at DashboardExpect.savedSearchRowCount (test/functional/services/dashboard/expectations.ts:213:7)
    at Context.<anonymous> (test/functional/apps/home/_sample_data.ts:104:9)
    at Object.apply (packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)

First failure: Jenkins Build
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jan 26, 2021
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

1 similar comment
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

tylersmalley added a commit that referenced this issue Jan 27, 2021
@tylersmalley
skip flaky suite (#89379)
2c648ac
tylersmalley added a commit that referenced this issue Jan 27, 2021
@tylersmalley
skip flaky suite (#89379)
b8a60b0
@tylersmalley
Copy link
Contributor

Skipped

master: 2c648ac
7.x: b8a60b0

@tylersmalley tylersmalley added the REASSIGN from Team:Core UI Deprecated label for old Core UI team label Jan 27, 2021
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

1 similar comment
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@tylersmalley tylersmalley added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. and removed REASSIGN from Team:Core UI Deprecated label for old Core UI team Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jan 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Kibana-Design)

@tylersmalley
Copy link
Contributor

@elastic/kibana-design do you own Home?

@elastic elastic deleted a comment from elasticmachine Jan 27, 2021
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

1 similar comment
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@ryankeairns ryankeairns added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. labels Jan 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

jloleysens added a commit to jloleysens/kibana that referenced this issue Jan 27, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/basic-a11…
9ab82eb 
…y-tests

* 'master' of github.com:elastic/kibana: (276 commits)
  [Telemetry] Settings Collector: redact sensitive reported values (elastic#88675)
  [CI] Combines Jest test jobs (elastic#85850)
  [Upgrade Assistant] Migrate server to new es-js client (elastic#89207)
  Migrate maps_legacy, maps_oss, region_map, and tile_map plugions to TS projects (elastic#89351)
  [Vega Docs] Add experimental flag on the vega maps title (elastic#89402)
  Increase the time needed to locate the save viz toast (elastic#89301)
  [Enterprise Search] Add links to doc links service (elastic#89260)
  Fixed regex bug in Safari (elastic#89399)
  [Lens] Fix indexpattern checks for missing references (elastic#88840)
  [Lens] Clean up usage collector (elastic#89109)
  update apm index pattern (elastic#89395)
  [APM] Upgrade ES client (elastic#86594)
  Enable v2 so migrations, disable in FTR tests (elastic#89297)
  [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (elastic#88699)
  Cleanup OSS code from visualizations wizard (elastic#89092)
  [APM] Optimize API test order (elastic#88654)
  Rename conversion function, extract to module scope and add tests. (elastic#89018)
  [core.logging] Add ops logs to the KP logging system (elastic#88070)
  chore(NA): improve ts build refs performance on kbn bootstrap (elastic#89333)
  skip flaky suite (elastic#89379)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/timeline/timeline.tsx
#	x-pack/test/accessibility/config.ts
@TinaHeiligers TinaHeiligers self-assigned this Jan 27, 2021
@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented Jan 27, 2021 •
edited
Loading

The tests are failing in the dashboard saved search row count for the flights sample data set.

We're expecting the saved search to contain 50 rows but only getting 25.

There are a number of potential reasons for the failure. For now, we can re-enable the tests and modify the failing expectation to verify that the saved search contains at least 10 rows. (edit Jan 28, 2021) disable the failing expectation.

Potential causes:

  • the default number of rows displayed in a saved search changed (@kertal I recall something about pagination changed or do possibly know what might be happening here?)
  • the sample data itself changed (unlikely but I'll try to count the rows if possible)
  • the behavior of the FTR has changed or not yet modified to account for recent changes
  • Dashboard behavior changed (@majagrubic does anything jump out at you perhaps?)

@TinaHeiligers TinaHeiligers mentioned this issue Jan 27, 2021
Merged
2 tasks
@kertal
Copy link
Member

kertal commented Jan 28, 2021

@TinaHeiligers it looks like the table vis number changed? so maybe @sulemanof or @stratoula knows since there were some changes in the data table vis recently

@stratoula
Copy link
Contributor

Yes it could be, @sulemanof can you check this?

@kertal
Copy link
Member

kertal commented Jan 28, 2021

sorry, my bad @sulemanof, @stratoula , my look was too quick, definitely a saved search error

@TinaHeiligers
Copy link
Contributor

@kertal @sulemanof I've added the config discover:searchFieldsFromSource flag to the before section for the test to see if that resolves the issue. I wasn't able to reproduce the initial problem locally so testing the change locally doesn't help either. Let's see what CI does with the change

@kertal
Copy link
Member

kertal commented Jan 28, 2021 •
edited
Loading

So I've synced with Tina, and I think it has to do with doc_table:legacy set to false in a previous test. Therefore the EuiDataGrid is displayed, and that's displaying 25 records by default (until the performance is nice).

so my suggestion is cleaning up this setting by using after in the test (ideally in all data grid test)

https://github.com/elastic/kibana/blob/master/test/functional/apps/discover/_data_grid_doc_table.ts#L19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TinaHeiligers TinaHeiligers

Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test skipped-test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flights sample data dashboard visualization TinaHeiligers/kibana
7 participants
@tylersmalley @ryankeairns @kertal @TinaHeiligers @elasticmachine @stratoula @kibanamachine