Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flights sample data dashboard visualization #89460

Merged

Conversation

TinaHeiligers
Copy link
Contributor

…t failure
resolves #89379

Summary

The Chrome UI Functional Tests fail at test/functional/apps/home/_sample_data·ts, specifically in the "homepage app sample data dashboard should render visualizations" test block.

The failure in the dashboard saved search row count for the flights sample data set is because we're expecting the saved search to contain 50 rows but only getting 25.

There are a number of potential reasons for the failure that we can investigate as a follow up issue.

For now, we can re-enable the tests and modify the failing expectation to verify that the saved search contains at least 10 rows.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@TinaHeiligers TinaHeiligers added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0 labels Jan 27, 2021
@TinaHeiligers
Copy link
Contributor Author

@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers marked this pull request as draft January 27, 2021 18:49
@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Jan 28, 2021

@tylersmalley I know this PR doesn't fix the root cause of the failing test but it will allow us to re-enable the test suite.
Should we hold off until we fix the underlying problem (Still unknown) or merge it for now and follow up for a complete fix later?
Fixed!

@TinaHeiligers TinaHeiligers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jan 28, 2021
@TinaHeiligers TinaHeiligers marked this pull request as ready for review January 28, 2021 19:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@TinaHeiligers TinaHeiligers requested review from kertal, majagrubic, tylersmalley and a team and removed request for kertal and majagrubic January 28, 2021 19:57
@TinaHeiligers
Copy link
Contributor Author

cc @kertal @majagrubic Thanks for the pointers on fixing the issue. I had to use a combination of your suggestions.

@@ -33,6 +33,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.common.navigateToApp('discover');
});

after(async function () {
log.debug('reset uiSettings');
await kibanaServer.uiSettings.replace({});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for cleaning, this up!

Comment on lines 28 to 30
await kibanaServer.uiSettings.update({
'discover:searchFieldsFromSource': true,
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it fail without setting discover:searchFieldsFromSource to true?
this should not be necessary, it should return same number of records for saved searched no matter what is set here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kertal yes, it works!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal kertal self-requested a review January 29, 2021 13:12
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thx for the cleanup!

@TinaHeiligers TinaHeiligers changed the title Fix flights sample data dashboard visualization saved search row coun… Fix flights sample data dashboard visualization Jan 29, 2021
@TinaHeiligers TinaHeiligers merged commit a29d4d3 into elastic:master Jan 29, 2021
@TinaHeiligers TinaHeiligers deleted the FT-failures/homepage-sample-data-db branch January 29, 2021 14:10
TinaHeiligers added a commit that referenced this pull request Jan 29, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.12.0 v8.0.0
Projects
None yet
6 participants