Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] x-axis on the instance bubble chart is broken #92631

Closed
nehaduggal opened this issue Feb 24, 2021 · 5 comments · Fixed by #95577
Closed

[APM] x-axis on the instance bubble chart is broken #92631

nehaduggal opened this issue Feb 24, 2021 · 5 comments · Fixed by #95577
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:ElasticCharts Issues related to the elastic-charts library Team:APM All issues that need APM UI Team support Team:DataVis Team label for DataVis Team v7.13.0 v7.14.0

Comments

@nehaduggal
Copy link

Versions: Kibana: 7.12

Issue:

In the new Instance scatter plot chart, the x-axis looks empty and so off with just 1 data point. In the attached screenshot you can see that the instances tpm is 7.6tpm but it looks like the dot is on 0 making it super confusing. We should have some more even interval labels on the x-axis and not show anything with a non 0 tpm as a 0 value.

Screen Shot 2021-02-23 at 8 52 59 PM

@nehaduggal nehaduggal added Team:APM All issues that need APM UI Team support v7.12.0 labels Feb 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv added [zube]: Inbox bug Fixes for quality problems that affect the customer experience and removed [zube]: Inbox labels Feb 24, 2021
@sorenlouv
Copy link
Member

sorenlouv commented Feb 25, 2021

What should we use as the domain (aka range) for the x-axis in this example? imo the ideal domain in this case is [0, 16] which would put the instance in the middle. But the logic to find the upper ound might be odd, something like:

Math.max(median_throughput * 2, maxThroughput)

Other options is simply [0, 7.6] as we normally do. This would place the instance at the very right end of the plot.

smith added a commit to smith/kibana that referenced this issue Feb 25, 2021
smith added a commit that referenced this issue Mar 1, 2021
...until #88852 and #92631 are resolved.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this issue Mar 1, 2021
...until elastic#88852 and elastic#92631 are resolved.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit that referenced this issue Mar 1, 2021
...until #88852 and #92631 are resolved.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
smith added a commit to smith/kibana that referenced this issue Mar 2, 2021
...until elastic#88852 and elastic#92631 are resolved.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
smith added a commit that referenced this issue Mar 2, 2021
@nickofthyme nickofthyme added Feature:ElasticCharts Issues related to the elastic-charts library Team:DataVis Team label for DataVis Team labels Mar 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/datavis (Feature:ElasticCharts)

@elasticmachine
Copy link
Contributor

Pinging @elastic/datavis (Team:DataVis)

@markov00
Copy link
Member

This current behavior is caused by the fact that you are using a linear scale with a dataset that has only 1 single value.
The auto computed domain is basically [7.6,7.6] and matching that to the range (width of the chart) basically renders the chart as in the screenshot.

We can improve that and move the point to the center in this specific case (see elastic/elastic-charts#1095), but in the meantime, as @sqren proposed, adding a fixed domain can fix that. Another workaround for this specific use case it to use the Ordinal scale type for the x-axis instead of the linear, only when you have a single data point. with that, the point will be positioned in the middle of the chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:ElasticCharts Issues related to the elastic-charts library Team:APM All issues that need APM UI Team support Team:DataVis Team label for DataVis Team v7.13.0 v7.14.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants