[index pattern field editor] Update runtime field painless docs url #100014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkime
changed the title
mattkime
added
v8.0.0
v7.14.0
v7.13.0
Feature:Data Views
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
|
@elasticmachine merge upstream |
lcawl
reviewed
May 13, 2021
| const painlessDocsBase = `${docsBase}/elasticsearch/painless/${DOC_LINK_VERSION}`; | ||
|
|
||
| return { | ||
| runtimePainless: `${esDocsBase}/runtime.html#runtime-mapping-fields`, | ||
| runtimePainless: `${docsBase}/kibana/master/managing-index-patterns.html#runtime-fields`, |
There was a problem hiding this comment.
I think instead of hard-coding a version in here, it'd be preferrable to define a const instead. For example:
const kibanaDocsBase = ${docsBase}/kibana/${DOC_LINK_VERSION}`;
Then return the URL like this:
runtimePainless:
${kibanaDocsBase}/managing-index-patterns.html#runtime-fields,
|
FYI: We've been moving to using the doc link service (so that the links are checked as part of our doc build). Somehow this editor was missed from our initial list, so I've added it for cleanup in #88107. |
…kibana into update_runtime_syntax_docs_url
💚 Build SucceededMetrics [docs]Page load bundle
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 13, 2021
…lastic#100014) * update runtime field painless docs url
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 13, 2021
…lastic#100014) * update runtime field painless docs url
gmmorris
added a commit
to chrisronline/kibana
that referenced
this pull request
May 14, 2021
* master: (27 commits) Disable contextMenu when event is not event.kind=event (elastic#100027) Updates the monorepo-packages list (elastic#100096) Removes circular deps for lists in tooling and bumps down byte limit for lists (elastic#100082) [Security Solutions] Breaks down the io-ts packages to decrease plugin size (elastic#100058) fix-typo: Use of `than` instead of `then` (elastic#100030) [Fleet] Fix error when searching for keys whose names have spaces (elastic#100056) [Workplace Search] Fix bug when transitioning to personal dashboard (elastic#100061) [index pattern field editor] Update runtime field painless docs url (elastic#100014) [QA] Switch tests to use importExport - visualize (elastic#98063) [Canvas] Remove unused legacy autocomplete component (elastic#99215) Re-enable formerly flaky shareable test (elastic#98826) [Uptime] [Synthetics Integration] ensure that proxy url is not overwritten (elastic#99944) [Security Solutions][Lists] Trims down list plugin size by breaking out the exception builder into chunks by using react lazy loading (elastic#99989) [Uptime] Increase debounce and add immediate submit to `useQueryBar` (elastic#99675) chore(NA): moving @kbn/docs-utils into bazel (elastic#100051) [Enterprise Search] Fix SchemaFieldTypeSelect axe issues (elastic#100035) Remove outdated comment about schema validation not working (it does work now). (elastic#100055) Rename alert status OK to Recovered and fix some UX issues around disabling a rule while being in an error state (elastic#98135) [Fleet] Do not use async method in plugin setup|start (elastic#100033) Skip flaky functional test suite ...
|
Is this updating the link here? And here? Anywhere else? |
|
@LeeDr only the second one. Nowhere else. |
|
I should include a screenshot next time. |
yctercero
pushed a commit
to yctercero/kibana
that referenced
this pull request
May 25, 2021
…lastic#100014) * update runtime field painless docs url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We now have better content to link to when authoring runtime fields. Lets link to it.