Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Increase debounce and add immediate submit to useQueryBar #99675

Conversation

justinkambic
Copy link
Contributor

Summary

Resolves #94421.

Introduce a longer debounce interval for the Query Bar's change events. Introduce a short-circuit function to cancel the debounce and submit immediately on the form's submit event.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@justinkambic justinkambic added enhancement New value added to drive a business result v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.14.0 labels May 10, 2021
@justinkambic justinkambic self-assigned this May 10, 2021
@justinkambic justinkambic force-pushed the fix/94421-uptime-typeahead-search-debounce branch from d353339 to 9814e71 Compare May 12, 2021 15:51
@justinkambic justinkambic marked this pull request as ready for review May 12, 2021 16:21
@justinkambic justinkambic requested a review from a team as a code owner May 12, 2021 16:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 1.2MB 1.2MB +559.0B

History

  • 💚 Build #125152 succeeded d3533398dcfc068f31e286c3cf42adaef0629770

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

@justinkambic justinkambic added the release_note:skip Skip the PR/issue when compiling release notes label May 12, 2021
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did think it felt a bit slow to me, but I think it's a much better experience.

@justinkambic justinkambic added the auto-backport Deprecated - use backport:version if exact versions are needed label May 13, 2021
@justinkambic justinkambic merged commit 0c2af2f into elastic:master May 13, 2021
@justinkambic justinkambic deleted the fix/94421-uptime-typeahead-search-debounce branch May 13, 2021 20:04
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 13, 2021
…lastic#99675)

* Increase debounce and add immediate submit to `useQueryBar`.

* Reduce debounce to 800ms.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 13, 2021
…99675) (#100072)

* Increase debounce and add immediate submit to `useQueryBar`.

* Reduce debounce to 800ms.

Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
gmmorris added a commit to chrisronline/kibana that referenced this pull request May 14, 2021
* master: (27 commits)
  Disable contextMenu when event is not event.kind=event (elastic#100027)
  Updates the monorepo-packages list (elastic#100096)
  Removes circular deps for lists in tooling and bumps down byte limit for lists (elastic#100082)
  [Security Solutions] Breaks down the io-ts packages to decrease plugin size (elastic#100058)
  fix-typo: Use of `than` instead of `then` (elastic#100030)
  [Fleet] Fix error when searching for keys whose names have spaces (elastic#100056)
  [Workplace Search] Fix bug when transitioning to personal dashboard (elastic#100061)
  [index pattern field editor] Update runtime field painless docs url (elastic#100014)
  [QA] Switch tests to use importExport - visualize (elastic#98063)
  [Canvas] Remove unused legacy autocomplete component (elastic#99215)
  Re-enable formerly flaky shareable test (elastic#98826)
  [Uptime] [Synthetics Integration] ensure that proxy url is not overwritten (elastic#99944)
  [Security Solutions][Lists] Trims down list plugin size by breaking out the exception builder into chunks by using react lazy loading (elastic#99989)
  [Uptime] Increase debounce and add immediate submit to `useQueryBar` (elastic#99675)
  chore(NA): moving @kbn/docs-utils into bazel (elastic#100051)
  [Enterprise Search] Fix SchemaFieldTypeSelect axe issues (elastic#100035)
  Remove outdated comment about schema validation not working (it does work now). (elastic#100055)
  Rename alert status OK to Recovered and fix some UX issues around disabling a rule while being in an error state (elastic#98135)
  [Fleet] Do not use async method in plugin setup|start (elastic#100033)
  Skip flaky functional test suite
  ...
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
…lastic#99675)

* Increase debounce and add immediate submit to `useQueryBar`.

* Reduce debounce to 800ms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime] Typeahead search updates the content for every character entered
4 participants