[Fleet] Integrations UI: Adjust policies list UI #101600

kpollich · 2021-06-08T13:53:14Z

Summary

This PR updates the "Policies" tab of the "Integration Details" page (e.g. http://localhost:5601/app/integrations#/detail/linux-0.3.10/policies) with a few new pieces of functionality:

Adds an "Actions" menu with "Add Agent", "Edit Integration", and "Delete Integration" actions
Adds a "+" button to the "Agents" column of the table to open the "Enroll Agent" flyout if there are no enrolled agents

See designs: https://www.figma.com/proto/G3jnu6rub6x8YExOfTWoO9/Integrations-UI-%2B-Fleet?node-id=802%3A23&scaling=min-zoom

How To Test

Start Kibana + ES on basic
Follow the in-app instructions for setting up a fleet server where agents can be registered
Add a new integration like Linux or Nginx via the "Integrations > Browse" flow
Navigate to your installed integration, then the "Policies" tab, e.g. http://localhost:5601/app/integrations#/detail/nginx-0.5.0/policies
The new "+" icon should appear in the Agents column of the table, and the new Actions menu should appear in the far right column

Screenshots

Show Screenshots

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)

- Add button to open enrollment flyout from package policy list screen - Move necessary components up into `public` in order to open enrollment flyout from within Integrations application

elasticmachine · 2021-06-08T13:53:16Z

Pinging @elastic/fleet (Team:Fleet)

...t/public/applications/integrations/sections/epm/screens/detail/policies/package_policies.tsx

...fleet/public/applications/integrations/sections/epm/screens/detail/policies/actions_menu.tsx

jloleysens

Tested locally and the actions menu and add button work as intended. Great work @kpollich !

...ck/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/index.test.tsx

…/epm/screens/detail/index.test.tsx Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>

jen-huang

Thanks for the changes, LGTM 🚀

kpollich · 2021-06-09T19:07:30Z

@elasticmachine merge upstream

kibanamachine · 2021-06-09T21:07:26Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`fleet`	472	473	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	713.7KB	711.8KB	-1.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`fleet`	425.1KB	426.0KB	+872.0B

History

💛 Build #130077 was flaky edb9460
💛 Build #129855 was flaky 88adc35
💚 Build #129816 succeeded ee1beaf
💔 Build #129801 failed 6988e46

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

* Add "Add Agent" button to package policy list - Add button to open enrollment flyout from package policy list screen - Move necessary components up into `public` in order to open enrollment flyout from within Integrations application * Create initial package policy table actions * Fix context menu link + add a few tests * Fix import in list_layout * Unify package policy actions menu in shared component * Update x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/index.test.tsx Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-06-09T21:09:56Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* Add "Add Agent" button to package policy list - Add button to open enrollment flyout from package policy list screen - Move necessary components up into `public` in order to open enrollment flyout from within Integrations application * Create initial package policy table actions * Fix context menu link + add a few tests * Fix import in list_layout * Unify package policy actions menu in shared component * Update x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/index.test.tsx Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co> Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>

…add-agent-flyout * 'master' of github.com:elastic/kibana: (35 commits) [Cases] Improve connectors mapping (elastic#101145) [ML] Fixes display of job group badges in recognizer wizard (elastic#101775) Fix es_archives path (elastic#101737) [kbnArchiver] convert archive names to root-relative paths (elastic#101839) [Reporting] Make "ScreenCapturePanel" shareable for Canvas (elastic#100623) [Alerting UI] Converted Rules and Connectors management pages to new layout. (elastic#101697) [Fleet] Support granular integrations in policy editor (elastic#101531) [Security Solution][Detections] Update detection alert mappings to ECS v1.10.0 (elastic#101680) [Fleet] Integrations UI: Adjust policies list UI (elastic#101600) chore(NA): moving @kbn/server-route-repository into bazel (elastic#101484) Support owner and description attributes inside the Manifest file, use in API docs (elastic#101786) [Security Solution] fix security empty overview links (elastic#101536) Unskips migration tests now that elastic search is fixed (elastic#101682) Fix endpoint -> integrations onboarding link (elastic#101804) [Alerting] Log warning when rules are not rescheduled due to Saved Object not found error (elastic#101591) Update datafeed_high_count_network_denies.json (elastic#101681) [Index patterns] Field editor example app (elastic#100524) [DOCS] Adding file upload to add data page (elastic#101674) [Security Solution][Endpoint] Adds Endpoint Host Isolation Status common component (elastic#101782) Upgrade ws v7.3.1->v7.4.2 and v6.2.1->v6.2.2 (elastic#101402) ... # Conflicts: # x-pack/plugins/fleet/public/components/agent_enrollment_flyout/agent_policy_selection.tsx # x-pack/plugins/fleet/public/components/agent_enrollment_flyout/index.tsx # x-pack/plugins/fleet/public/components/agent_enrollment_flyout/managed_instructions.tsx # x-pack/plugins/fleet/public/components/agent_enrollment_flyout/standalone_instructions.tsx

…add-integrations-redirect * 'master' of github.com:elastic/kibana: (44 commits) Allow navigating discover flyout via arrow keys (elastic#101772) [Cases] Improve connectors mapping (elastic#101145) [ML] Fixes display of job group badges in recognizer wizard (elastic#101775) Fix es_archives path (elastic#101737) [kbnArchiver] convert archive names to root-relative paths (elastic#101839) [Reporting] Make "ScreenCapturePanel" shareable for Canvas (elastic#100623) [Alerting UI] Converted Rules and Connectors management pages to new layout. (elastic#101697) [Fleet] Support granular integrations in policy editor (elastic#101531) [Security Solution][Detections] Update detection alert mappings to ECS v1.10.0 (elastic#101680) [Fleet] Integrations UI: Adjust policies list UI (elastic#101600) chore(NA): moving @kbn/server-route-repository into bazel (elastic#101484) Support owner and description attributes inside the Manifest file, use in API docs (elastic#101786) [Security Solution] fix security empty overview links (elastic#101536) Unskips migration tests now that elastic search is fixed (elastic#101682) Fix endpoint -> integrations onboarding link (elastic#101804) [Alerting] Log warning when rules are not rescheduled due to Saved Object not found error (elastic#101591) Update datafeed_high_count_network_denies.json (elastic#101681) [Index patterns] Field editor example app (elastic#100524) [DOCS] Adding file upload to add data page (elastic#101674) [Security Solution][Endpoint] Adds Endpoint Host Isolation Status common component (elastic#101782) ... # Conflicts: # x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/index.tsx # x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/components/package_policies/package_policies_table.tsx

* Add "Add Agent" button to package policy list - Add button to open enrollment flyout from package policy list screen - Move necessary components up into `public` in order to open enrollment flyout from within Integrations application * Create initial package policy table actions * Fix context menu link + add a few tests * Fix import in list_layout * Unify package policy actions menu in shared component * Update x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/index.test.tsx Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kpollich added 3 commits June 7, 2021 15:27

Add "Add Agent" button to package policy list

5c15bfe

- Add button to open enrollment flyout from package policy list screen - Move necessary components up into `public` in order to open enrollment flyout from within Integrations application

Create initial package policy table actions

cd0c4bb

Fix context menu link + add a few tests

6988e46

kpollich added release_note:enhancement v8.0.0 Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 8, 2021

kpollich self-assigned this Jun 8, 2021

kpollich requested a review from a team as a code owner June 8, 2021 13:53

kpollich changed the title ~~Integrations UI/adjust policies list UI~~ [Fleet] Integrations UI: Adjust policies list UI Jun 8, 2021

kpollich requested a review from jloleysens June 8, 2021 13:57

Fix import in list_layout

ee1beaf

jen-huang reviewed Jun 8, 2021

View reviewed changes

...t/public/applications/integrations/sections/epm/screens/detail/policies/package_policies.tsx Show resolved Hide resolved

...fleet/public/applications/integrations/sections/epm/screens/detail/policies/actions_menu.tsx Outdated Show resolved Hide resolved

Unify package policy actions menu in shared component

88adc35

jloleysens approved these changes Jun 9, 2021

View reviewed changes

...ck/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/index.test.tsx Outdated Show resolved Hide resolved

Update x-pack/plugins/fleet/public/applications/integrations/sections…

edb9460

…/epm/screens/detail/index.test.tsx Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>

kpollich enabled auto-merge (squash) June 9, 2021 12:02

kpollich disabled auto-merge June 9, 2021 12:59

kpollich requested review from jen-huang and nchaulet June 9, 2021 14:21

jen-huang approved these changes Jun 9, 2021

View reviewed changes

Merge branch 'master' into integrations-ui/adjust-policies-list-ui

2170c87

kpollich enabled auto-merge (squash) June 9, 2021 19:07

kpollich merged commit 9a412d3 into elastic:master Jun 9, 2021

kibanamachine mentioned this pull request Jun 9, 2021

[7.x] [Fleet] Integrations UI: Adjust policies list UI (#101600) #101838

Merged

kpollich deleted the integrations-ui/adjust-policies-list-ui branch June 10, 2021 02:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Integrations UI: Adjust policies list UI #101600

[Fleet] Integrations UI: Adjust policies list UI #101600

kpollich commented Jun 8, 2021 •

edited

Loading

elasticmachine commented Jun 8, 2021

jloleysens left a comment

jen-huang left a comment

kpollich commented Jun 9, 2021

kibanamachine commented Jun 9, 2021

kibanamachine commented Jun 9, 2021

[Fleet] Integrations UI: Adjust policies list UI #101600

[Fleet] Integrations UI: Adjust policies list UI #101600

Conversation

kpollich commented Jun 8, 2021 • edited Loading

Summary

How To Test

Screenshots

Checklist

elasticmachine commented Jun 8, 2021

jloleysens left a comment

Choose a reason for hiding this comment

jen-huang left a comment

Choose a reason for hiding this comment

kpollich commented Jun 9, 2021

kibanamachine commented Jun 9, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

kibanamachine commented Jun 9, 2021

💚 Backport successful

kpollich commented Jun 8, 2021 •

edited

Loading