Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow navigating discover flyout via arrow keys #101772

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Allow navigating discover flyout via arrow keys #101772

merged 1 commit into from
Jun 10, 2021
+38 −1

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Jun 9, 2021

Summary

Small change that will allow navigating the document flyout via the → and ← keys.

Checklist

Delete any items that are not applicable to this PR.

@timroes timroes requested a review from a team June 9, 2021 14:32
@timroes timroes added auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0 labels Jun 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

majagrubic
majagrubic approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Would be nice to test it in different browsers if you haven't already.

@timroes
Copy link
Contributor Author

timroes commented Jun 10, 2021

Tested it on Firefox and Chrome. Maybe someone with a Mac could still test this on Safari?q

dimaanj
dimaanj approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@dimaanj dimaanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in Safari, Chrome, Firefox, and works for both pages discover and context

kertal
kertal approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test as I currently working on reviewing Dimas work, but since everybody is approving it, I also wanna be part of this party (And I wanna express happiness for such a little nice UX improvment )

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 426.4KB 426.7KB +362.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@timroes timroes merged commit 45ed003 into elastic:master Jun 10, 2021
@timroes timroes deleted the discover/flyout-keyboard branch June 10, 2021 09:14
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 10, 2021
@kibanamachine
Allow navigating discover flyout via arrow keys (elastic#101772)
530ff5e
@kibanamachine kibanamachine mentioned this pull request Jun 10, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 10, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into fleet/adjust-…
96e51d9 
…add-integrations-redirect

* 'master' of github.com:elastic/kibana: (44 commits)
  Allow navigating discover flyout via arrow keys (elastic#101772)
  [Cases] Improve connectors mapping (elastic#101145)
  [ML] Fixes display of job group badges in recognizer wizard (elastic#101775)
  Fix es_archives path (elastic#101737)
  [kbnArchiver] convert archive names to root-relative paths (elastic#101839)
  [Reporting] Make "ScreenCapturePanel" shareable for Canvas (elastic#100623)
  [Alerting UI] Converted Rules and Connectors management pages to new layout. (elastic#101697)
  [Fleet] Support granular integrations in policy editor (elastic#101531)
  [Security Solution][Detections] Update detection alert mappings to ECS v1.10.0 (elastic#101680)
  [Fleet] Integrations UI: Adjust policies list UI (elastic#101600)
  chore(NA): moving @kbn/server-route-repository into bazel (elastic#101484)
  Support owner and description attributes inside the Manifest file, use in API docs (elastic#101786)
  [Security Solution] fix security empty overview links (elastic#101536)
  Unskips migration tests now that elastic search is fixed (elastic#101682)
  Fix endpoint -> integrations onboarding link (elastic#101804)
  [Alerting] Log warning when rules are not rescheduled due to Saved Object not found error (elastic#101591)
  Update datafeed_high_count_network_denies.json (elastic#101681)
  [Index patterns] Field editor example app (elastic#100524)
  [DOCS] Adding file upload to add data page (elastic#101674)
  [Security Solution][Endpoint] Adds Endpoint Host Isolation Status common component (elastic#101782)
  ...

# Conflicts:
#	x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/index.tsx
#	x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/components/package_policies/package_policies_table.tsx
kibanamachine added a commit that referenced this pull request Jun 10, 2021
@kibanamachine
Allow navigating discover flyout via arrow keys (#101772) (#101864)
2621efd 
Co-authored-by: Tim Roes <tim.roes@elastic.co>
semd pushed a commit that referenced this pull request Jun 10, 2021
@semd
Allow navigating discover flyout via arrow keys (#101772)
5d8564a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaanj dimaanj dimaanj approved these changes

@majagrubic majagrubic majagrubic approved these changes

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@timroes @elasticmachine @kibanamachine @kertal @majagrubic @dimaanj