Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix formula functional test #102749

Merged
merged 4 commits into from
Jun 21, 2021
Merged

[Lens] Fix formula functional test #102749

merged 4 commits into from
Jun 21, 2021

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jun 21, 2021

Summary

Fixes #102183

Removed previous fix as it was working properly and went for the usual fix for text input: delete char by char the formula when updating it.

Flaky test runner: 100 runs for the whole lens suite => https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1664/

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't run this change, but we've done the same fix in a few other places. LGTM from code only.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit 6f2a97b into elastic:master Jun 21, 2021
@dej611 dej611 deleted the fix/102183-2 branch June 21, 2021 17:17
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 21, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 23, 2021
kibanamachine added a commit that referenced this pull request Jun 23, 2021
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
4 participants