Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix formula functional test #102749

Merged
merged 4 commits into from
Jun 21, 2021
Merged

[Lens] Fix formula functional test #102749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4395cef
:white_check_mark: Clear char by char
dej611 Jun 21, 2021
c5dec14
:fire: Remove test filter
dej611 Jun 21, 2021
a2b12f9
Merge remote-tracking branch 'upstream/master' into fix/102183-2
dej611 Jun 21, 2021
c10eda8
:fire: Remove skip
dej611 Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions x-pack/test/functional/apps/lens/formula.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const browser = getService('browser');
const testSubjects = getService('testSubjects');

// FLAKY: https://github.com/elastic/kibana/issues/102183
describe.skip('lens formula', () => {
describe('lens formula', () => {
it('should transition from count to formula', async () => {
await PageObjects.visualize.gotoVisualizationLandingPage();
await listingTable.searchForItemWithName('lnsXYvis');
Expand Down Expand Up @@ -81,7 +80,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
let element = await find.byCssSelector('.monaco-editor');
expect(await element.getVisibleText()).to.equal(`count(kql='Men\\'s Clothing ')`);

await PageObjects.common.sleep(100);
await PageObjects.lens.typeFormula('count(kql=');
input = await find.activeElement();
await input.type(`Men\'s Clothing`);
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/functional/page_objects/lens_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1066,7 +1066,7 @@ export function LensPageProvider({ getService, getPageObjects }: FtrProviderCont
await find.byCssSelector('.monaco-editor');
await find.clickByCssSelectorWhenNotDisabled('.monaco-editor');
const input = await find.activeElement();
await input.clearValueWithKeyboard();
await input.clearValueWithKeyboard({ charByChar: true });
await input.type(formula);
},
});
Expand Down