[Reporting] fix too_long_frame_exception by passing scroll_id in the request body #102972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
bug
tsullivan
force-pushed
the
reporting/csv-scroll-id-fixes
branch
from
b21ed81
to
618a760
Compare
|
@elasticmachine merge upstream |
tsullivan
force-pushed
the
reporting/csv-scroll-id-fixes
branch
from
fd8f58c
to
7a35363
Compare
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
|
@elasticmachine merge upstream Sorry @tsullivan, the cloud instance behind ci-stats had a little fit so that build wasn't going to succeed due to metrics at least, so I started it over. |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
jloleysens
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Great job finding this @tsullivan ! I had no idea that scroll ids were that big potentially.
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jun 30, 2021
…request body (elastic#102972) * pass scroll_id in the request body not a param * update test to match Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jun 30, 2021
…request body (elastic#102972) * pass scroll_id in the request body not a param * update test to match Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jun 30, 2021
…request body (elastic#102972) * pass scroll_id in the request body not a param * update test to match Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
madirey
pushed a commit
to madirey/kibana
that referenced
this pull request
Jul 6, 2021
…request body (elastic#102972) * pass scroll_id in the request body not a param * update test to match Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #102971
An HTTP line can not be longer than 4096 bytes. This becomes a problem when using scan and scroll with Elasticsearch, and having the scroll ID placed in the path of the URL.
Bad:
When the URL is too long, Elasticsearch may respond with an error:
The scroll ID should be in the POST payload body.
Good:
Checklist
Delete any items that are not applicable to this PR.
Release note
Fixed an issue with CSV export that could limit the size of the export to 500 lines.