[TSVB] Add more functional tests for Table #105060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # test/functional/page_objects/visual_builder_page.ts
DianaDerevyankina
added
Feature:TSVB
VladLasitsa
reviewed
Jul 16, 2021
Comment on lines
739
to
742
| const [, denominatorInput] = await this.find.allByCssSelector( | ||
| '.tvbAggRow [data-test-subj="queryInput"]' | ||
| ); | ||
| await denominatorInput.type(denominator); |
There was a problem hiding this comment.
can we create private function with common logic and in these methods just return needed input?
1 task
alexwizp
reviewed
Jul 16, 2021
|
|
||
| public async setFilterRatioOption(optionType: 'numerator' | 'denominator', query: string) { | ||
| const optionInput = await this.find.byCssSelector( | ||
| `[data-test-subj="${optionType}Row"] [data-test-subj="queryInput"]` |
There was a problem hiding this comment.
@VladLasitsa @dziyanadzeraviankina
we are trying to avoid using css selectors especially if for both components we already added data-test-subj attributes
Please see next example:
Please check other places
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
alexwizp
approved these changes
Jul 20, 2021
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
stratoula
approved these changes
Jul 20, 2021
DianaDerevyankina
added a commit
to DianaDerevyankina/kibana
that referenced
this pull request
Jul 20, 2021
* [TSVB] Add more functional tests for Table * Update filter ratio setting numerator denominator function * Refactor set filter ratio numerator and denominator functions in visual_builder_page.ts * Update setFilterRatioOption function
DianaDerevyankina
added a commit
that referenced
this pull request
Jul 20, 2021
* [TSVB] Add more functional tests for Table * Update filter ratio setting numerator denominator function * Refactor set filter ratio numerator and denominator functions in visual_builder_page.ts * Update setFilterRatioOption function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added functional tests for TSVB
Tablecovering cases mentioned here (#102606)For maintainers