-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NA): moving @kbn/rule-data-utils to babel transpiler #107573
chore(NA): moving @kbn/rule-data-utils to babel transpiler #107573
Conversation
Pinging @elastic/kibana-operations (Team:Operations) |
Pinging @elastic/apm-ui (Team:apm) |
Pinging @elastic/uptime (Team:uptime) |
@elasticmachine merge upstream |
…:mistic/kibana into transpile-kbn-rule-data-utils-with-babel
@elastic/security-threat-hunting @elastic/uptime are we okay to move on here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uptime changes LGTM
@elasticmachine merge upstream |
merge conflict between base and head |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
@elastic/security-threat-hunting I'm going ahead and merge this. Let me know if you have further feedback to address. |
…07573) * chore(NA): moving @kbn/rule-data-utils to babel transpiler * chore(NA): update imports * chore(NA): targetted imports for apm * chore(NA): fix imports Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
…07573) * chore(NA): moving @kbn/rule-data-utils to babel transpiler * chore(NA): update imports * chore(NA): targetted imports for apm * chore(NA): fix imports Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # packages/kbn-rule-data-utils/BUILD.bazel # packages/kbn-rule-data-utils/tsconfig.json # x-pack/plugins/apm/public/components/app/error_group_details/Distribution/index.tsx # x-pack/plugins/apm/public/components/shared/charts/helper/get_alert_annotations.tsx # x-pack/plugins/apm/public/components/shared/charts/latency_chart/index.tsx # x-pack/plugins/observability/public/pages/alerts/alerts_flyout/index.tsx # x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid.tsx # x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid_actions.tsx # x-pack/plugins/observability/public/pages/alerts/decorate_response.ts # x-pack/plugins/observability/public/pages/alerts/render_cell_value.tsx # x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts # x-pack/plugins/rule_registry/server/routes/get_alert_index.ts # x-pack/plugins/rule_registry/server/rule_data_client/types.ts # x-pack/plugins/rule_registry/server/rule_data_plugin_service/index.ts # x-pack/plugins/rule_registry/server/utils/create_persistence_rule_type_factory.ts # x-pack/plugins/timelines/common/search_strategy/timeline/index.ts # x-pack/plugins/timelines/public/components/t_grid/integrated/index.tsx # x-pack/plugins/timelines/public/components/t_grid/standalone/index.tsx # x-pack/plugins/timelines/public/container/index.tsx # x-pack/plugins/timelines/server/search_strategy/timeline/index.ts # x-pack/plugins/uptime/server/lib/alerts/duration_anomaly.test.ts # x-pack/plugins/uptime/server/lib/alerts/duration_anomaly.ts # x-pack/test/plugin_functional/plugins/timelines_test/public/applications/timelines_test/index.tsx
…108214) * chore(NA): moving @kbn/rule-data-utils to babel transpiler * chore(NA): update imports * chore(NA): targetted imports for apm * chore(NA): fix imports Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
…07573) (#108222) * chore(NA): moving @kbn/rule-data-utils to babel transpiler (#107573) * chore(NA): moving @kbn/rule-data-utils to babel transpiler * chore(NA): update imports * chore(NA): targetted imports for apm * chore(NA): fix imports Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # packages/kbn-rule-data-utils/BUILD.bazel # packages/kbn-rule-data-utils/tsconfig.json # x-pack/plugins/apm/public/components/app/error_group_details/Distribution/index.tsx # x-pack/plugins/apm/public/components/shared/charts/helper/get_alert_annotations.tsx # x-pack/plugins/apm/public/components/shared/charts/latency_chart/index.tsx # x-pack/plugins/observability/public/pages/alerts/alerts_flyout/index.tsx # x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid.tsx # x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid_actions.tsx # x-pack/plugins/observability/public/pages/alerts/decorate_response.ts # x-pack/plugins/observability/public/pages/alerts/render_cell_value.tsx # x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts # x-pack/plugins/rule_registry/server/routes/get_alert_index.ts # x-pack/plugins/rule_registry/server/rule_data_client/types.ts # x-pack/plugins/rule_registry/server/rule_data_plugin_service/index.ts # x-pack/plugins/rule_registry/server/utils/create_persistence_rule_type_factory.ts # x-pack/plugins/timelines/common/search_strategy/timeline/index.ts # x-pack/plugins/timelines/public/components/t_grid/integrated/index.tsx # x-pack/plugins/timelines/public/components/t_grid/standalone/index.tsx # x-pack/plugins/timelines/public/container/index.tsx # x-pack/plugins/timelines/server/search_strategy/timeline/index.ts # x-pack/plugins/uptime/server/lib/alerts/duration_anomaly.test.ts # x-pack/plugins/uptime/server/lib/alerts/duration_anomaly.ts # x-pack/test/plugin_functional/plugins/timelines_test/public/applications/timelines_test/index.tsx * chore(NA): remove @kbn/es-query package from deps * chore(NA): merge and solve conflicts * chore(NA): fix imports * chore(NA): fix types * chore(NA): fix lint
One step forward on #69706
That PR moves the @kbn/rule-data-utils from using tsc compiler to babel transpiler to produce the js outputs.