Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): moving @kbn/rule-data-utils to babel transpiler #107573

Merged

Conversation

mistic
Copy link
Member

@mistic mistic commented Aug 3, 2021

One step forward on #69706

That PR moves the @kbn/rule-data-utils from using tsc compiler to babel transpiler to produce the js outputs.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.14.1 labels Aug 3, 2021
@mistic mistic requested a review from jbudz August 3, 2021 18:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic enabled auto-merge (squash) August 3, 2021 19:15
@mistic mistic requested review from a team as code owners August 3, 2021 20:18
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Aug 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@mistic
Copy link
Member Author

mistic commented Aug 4, 2021

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Aug 5, 2021

@elastic/security-threat-hunting @elastic/uptime are we okay to move on here?

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM

@mistic
Copy link
Member Author

mistic commented Aug 6, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1584 1586 +2
observability 242 243 +1
total +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB -500.0B
observability 480.8KB 479.5KB -1.3KB
securitySolution 6.5MB 6.5MB +542.0B
timelines 267.5KB 267.6KB +104.0B
total -1.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 44.7KB 44.7KB +25.0B
infra 149.9KB 150.5KB +571.0B
uptime 35.4KB 36.0KB +571.0B
total +1.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Aug 11, 2021

@elastic/security-threat-hunting I'm going ahead and merge this. Let me know if you have further feedback to address.

@mistic mistic disabled auto-merge August 11, 2021 14:59
@mistic mistic merged commit dfaf540 into elastic:master Aug 11, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 11, 2021
…07573)

* chore(NA): moving @kbn/rule-data-utils to babel transpiler

* chore(NA): update imports

* chore(NA): targetted imports for apm

* chore(NA): fix imports

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x
7.14 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 107573

mistic added a commit to mistic/kibana that referenced this pull request Aug 11, 2021
…07573)

* chore(NA): moving @kbn/rule-data-utils to babel transpiler

* chore(NA): update imports

* chore(NA): targetted imports for apm

* chore(NA): fix imports

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	packages/kbn-rule-data-utils/BUILD.bazel
#	packages/kbn-rule-data-utils/tsconfig.json
#	x-pack/plugins/apm/public/components/app/error_group_details/Distribution/index.tsx
#	x-pack/plugins/apm/public/components/shared/charts/helper/get_alert_annotations.tsx
#	x-pack/plugins/apm/public/components/shared/charts/latency_chart/index.tsx
#	x-pack/plugins/observability/public/pages/alerts/alerts_flyout/index.tsx
#	x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid.tsx
#	x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid_actions.tsx
#	x-pack/plugins/observability/public/pages/alerts/decorate_response.ts
#	x-pack/plugins/observability/public/pages/alerts/render_cell_value.tsx
#	x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts
#	x-pack/plugins/rule_registry/server/routes/get_alert_index.ts
#	x-pack/plugins/rule_registry/server/rule_data_client/types.ts
#	x-pack/plugins/rule_registry/server/rule_data_plugin_service/index.ts
#	x-pack/plugins/rule_registry/server/utils/create_persistence_rule_type_factory.ts
#	x-pack/plugins/timelines/common/search_strategy/timeline/index.ts
#	x-pack/plugins/timelines/public/components/t_grid/integrated/index.tsx
#	x-pack/plugins/timelines/public/components/t_grid/standalone/index.tsx
#	x-pack/plugins/timelines/public/container/index.tsx
#	x-pack/plugins/timelines/server/search_strategy/timeline/index.ts
#	x-pack/plugins/uptime/server/lib/alerts/duration_anomaly.test.ts
#	x-pack/plugins/uptime/server/lib/alerts/duration_anomaly.ts
#	x-pack/test/plugin_functional/plugins/timelines_test/public/applications/timelines_test/index.tsx
kibanamachine added a commit that referenced this pull request Aug 11, 2021
…108214)

* chore(NA): moving @kbn/rule-data-utils to babel transpiler

* chore(NA): update imports

* chore(NA): targetted imports for apm

* chore(NA): fix imports

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
mistic added a commit that referenced this pull request Aug 12, 2021
…07573) (#108222)

* chore(NA): moving @kbn/rule-data-utils to babel transpiler (#107573)

* chore(NA): moving @kbn/rule-data-utils to babel transpiler

* chore(NA): update imports

* chore(NA): targetted imports for apm

* chore(NA): fix imports

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	packages/kbn-rule-data-utils/BUILD.bazel
#	packages/kbn-rule-data-utils/tsconfig.json
#	x-pack/plugins/apm/public/components/app/error_group_details/Distribution/index.tsx
#	x-pack/plugins/apm/public/components/shared/charts/helper/get_alert_annotations.tsx
#	x-pack/plugins/apm/public/components/shared/charts/latency_chart/index.tsx
#	x-pack/plugins/observability/public/pages/alerts/alerts_flyout/index.tsx
#	x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid.tsx
#	x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid_actions.tsx
#	x-pack/plugins/observability/public/pages/alerts/decorate_response.ts
#	x-pack/plugins/observability/public/pages/alerts/render_cell_value.tsx
#	x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts
#	x-pack/plugins/rule_registry/server/routes/get_alert_index.ts
#	x-pack/plugins/rule_registry/server/rule_data_client/types.ts
#	x-pack/plugins/rule_registry/server/rule_data_plugin_service/index.ts
#	x-pack/plugins/rule_registry/server/utils/create_persistence_rule_type_factory.ts
#	x-pack/plugins/timelines/common/search_strategy/timeline/index.ts
#	x-pack/plugins/timelines/public/components/t_grid/integrated/index.tsx
#	x-pack/plugins/timelines/public/components/t_grid/standalone/index.tsx
#	x-pack/plugins/timelines/public/container/index.tsx
#	x-pack/plugins/timelines/server/search_strategy/timeline/index.ts
#	x-pack/plugins/uptime/server/lib/alerts/duration_anomaly.test.ts
#	x-pack/plugins/uptime/server/lib/alerts/duration_anomaly.ts
#	x-pack/test/plugin_functional/plugins/timelines_test/public/applications/timelines_test/index.tsx

* chore(NA): remove @kbn/es-query package from deps

* chore(NA): merge and solve conflicts

* chore(NA): fix imports

* chore(NA): fix types

* chore(NA): fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Operations Team label for Operations Team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.14.1 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants